Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5060

'/' is added incorrectly before '?' in WebSvn url

    • Icon: Bug Bug
    • Resolution: Not A Defect
    • Icon: Major Major
    • subversion-plugin
    • None
    • Hudson 1.336 on Windows Server 2003

      If I set WebSvn URL to http://serverca:81/websvn/listing.php?repname=SCI&path= then after saving configuration it is modified to http://serverca:81/websvn/listing.php/?repname=SCI&path= (note the '/' added before '?').
      The modified url points to the right page on websvn but it is displayed badly (probably without css loaded). If I remove the added '/' the page is shown correctly.

          [JENKINS-5060] '/' is added incorrectly before '?' in WebSvn url

          Marco Ambu created issue -

          Eric Smalling added a comment -

          If you have access to your WebSvn's http configs, here's a work-around we're using successfully:

          In the VirtualHost for :80 or :443 (whichever you use) add the following directive:

          RedirectMatch (.*\.php)/$ $1

          Eric Smalling added a comment - If you have access to your WebSvn's http configs, here's a work-around we're using successfully: In the VirtualHost for :80 or :443 (whichever you use) add the following directive: RedirectMatch (.*\.php)/$ $1

          omax added a comment -

          esmalling, thanks for workaround, it works perfectly!

          omax added a comment - esmalling, thanks for workaround, it works perfectly!

          Code changed in hudson
          User: : andreasmandel
          Path:
          trunk/hudson/plugins/WebSVN2/pom.xml
          trunk/hudson/plugins/WebSVN2/src/main/java/hudson/plugins/websvn2/WebSVN2RepositoryBrowser.java
          trunk/hudson/plugins/WebSVN2/src/main/resources/hudson/plugins/websvn2/WebSVN2RepositoryBrowser/config.jelly
          trunk/hudson/plugins/WebSVN2/src/main/resources/index.jelly
          trunk/hudson/plugins/WebSVN2/src/main/webapp/help-url.html
          http://jenkins-ci.org/commit/34760
          Log:
          Initial revision of WebSVN2 plugin addressing JENKINS-3481, JENKINS-5060

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : andreasmandel Path: trunk/hudson/plugins/WebSVN2/pom.xml trunk/hudson/plugins/WebSVN2/src/main/java/hudson/plugins/websvn2/WebSVN2RepositoryBrowser.java trunk/hudson/plugins/WebSVN2/src/main/resources/hudson/plugins/websvn2/WebSVN2RepositoryBrowser/config.jelly trunk/hudson/plugins/WebSVN2/src/main/resources/index.jelly trunk/hudson/plugins/WebSVN2/src/main/webapp/help-url.html http://jenkins-ci.org/commit/34760 Log: Initial revision of WebSVN2 plugin addressing JENKINS-3481 , JENKINS-5060

          Alan Harder added a comment -

          Just curious, why are you adding a new plugin?

          Alan Harder added a comment - Just curious, why are you adding a new plugin?

          @mindless: To add support for the WebSVN viewer as it exists today. At least what I saw as implementation did not deal with the needed patterns and taking care for the parameter repname as needed when using with multiple repositories.

          Andreas Mandel added a comment - @mindless: To add support for the WebSVN viewer as it exists today. At least what I saw as implementation did not deal with the needed patterns and taking care for the parameter repname as needed when using with multiple repositories.

          Alan Harder added a comment -

          Do you think the changes you're making would break things for people using older WebSVN versions? Just seems like these changes should go in the subversion plugin instead of a new plugin, unless there's a reason to split out.. thanks for working on this!

          Alan Harder added a comment - Do you think the changes you're making would break things for people using older WebSVN versions? Just seems like these changes should go in the subversion plugin instead of a new plugin, unless there's a reason to split out.. thanks for working on this!

          Yes, actually I do not know if it breaks support of older versions of WebSVN but it is very likely. So I can not develop a version that would be backward compatible (if this is even possible). That is the main reason that I made a separate plugin. Nevertheless you are right and it could go into the subversion plugin as WebSVN2 if there is no way to make a WebSVN that works with both versions.

          Andreas Mandel added a comment - Yes, actually I do not know if it breaks support of older versions of WebSVN but it is very likely. So I can not develop a version that would be backward compatible (if this is even possible). That is the main reason that I made a separate plugin. Nevertheless you are right and it could go into the subversion plugin as WebSVN2 if there is no way to make a WebSVN that works with both versions.
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 135144 ] New: JNJira + In-Review [ 174261 ]

          James Dumay added a comment -

          Seems there was a workaround provided and I would hope that we've all upgraded our WebSVN versions in the intervening 7 years

          Closing for now.

          James Dumay added a comment - Seems there was a workaround provided and I would hope that we've all upgraded our WebSVN versions in the intervening 7 years Closing for now.
          James Dumay made changes -
          Resolution New: Not A Defect [ 7 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]

            Unassigned Unassigned
            mambu Marco Ambu
            Votes:
            5 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: