Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50752

ArgumentsAction Can Fail Serialization Of FlowNodes and Build When Given Unserializable input

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Although it shouldn't happen, but occasionally you see issues with unserializable content being inserted into the arguments which ends up breaking serialization. This can fail the whole persistence of the flow graph, causing loss of data.

      Instead we should intercept and filter out unserializable inputs when the action is created.

        Attachments

          Issue Links

            Activity

            svanoort Sam Van Oort created issue -
            svanoort Sam Van Oort made changes -
            Field Original Value New Value
            Description Although it *shouldn't* happen, but occasionally you see issues with unserializable content being inserted into the arguments which ends up breaking serialization. Although it *shouldn't* happen, but occasionally you see issues with unserializable content being inserted into the arguments which ends up breaking serialization. This can fail the whole persistence of the flow graph.

            Instead we should intercept and filter out unserializable inputs when the action is created.
            svanoort Sam Van Oort made changes -
            Link This issue is related to JENKINS-50020 [ JENKINS-50020 ]
            Hide
            svanoort Sam Van Oort added a comment -

            Similar issue in a related domain

            Show
            svanoort Sam Van Oort added a comment - Similar issue in a related domain
            svanoort Sam Van Oort made changes -
            Link This issue is related to JENKINS-50670 [ JENKINS-50670 ]
            svanoort Sam Van Oort made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            svanoort Sam Van Oort made changes -
            Description Although it *shouldn't* happen, but occasionally you see issues with unserializable content being inserted into the arguments which ends up breaking serialization. This can fail the whole persistence of the flow graph.

            Instead we should intercept and filter out unserializable inputs when the action is created.
            Although it *shouldn't* happen, but occasionally you see issues with unserializable content being inserted into the arguments which ends up breaking serialization. This can fail the whole persistence of the flow graph, causing loss of data.

            Instead we should intercept and filter out unserializable inputs when the action is created.
            svanoort Sam Van Oort made changes -
            Issue Type Improvement [ 4 ] Bug [ 1 ]
            svanoort Sam Van Oort made changes -
            Summary ArgumentsAction Should Deal With Unserializable Arguments ArgumentsAction Can Fail Serialization Of FlowNodes and Build When Given Unserializable input
            svanoort Sam Van Oort made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            svanoort Sam Van Oort added a comment -

            Implementation PR

            Show
            svanoort Sam Van Oort added a comment - Implementation PR
            svanoort Sam Van Oort made changes -
            Remote Link This issue links to "workflow-cps-plugin #220 (Web Link)" [ 20410 ]
            Hide
            svanoort Sam Van Oort added a comment -

            API addition

            Show
            svanoort Sam Van Oort added a comment - API addition
            svanoort Sam Van Oort made changes -
            Remote Link This issue links to "workflow-api-plugin #68 (Web Link)" [ 20411 ]
            svanoort Sam Van Oort made changes -
            Link This issue is related to JENKINS-50632 [ JENKINS-50632 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/e9fe93d891cac44d384bd4ade64ea6fc2c4de1f3
            Log:
            Bulletproof against JENKINS-50752 by catching unserializable step arguments

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/e9fe93d891cac44d384bd4ade64ea6fc2c4de1f3 Log: Bulletproof against JENKINS-50752 by catching unserializable step arguments
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/19f72df00ef47f76d039fa40ce2535811baee63a
            Log:
            Merge pull request #220 from svanoort/unserializable-args-JENKINS-50752

            Bulletproof against JENKINS-50752 by catching unserializable step arguments

            Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/64187fdcf999...19f72df00ef4

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/19f72df00ef47f76d039fa40ce2535811baee63a Log: Merge pull request #220 from svanoort/unserializable-args- JENKINS-50752 Bulletproof against JENKINS-50752 by catching unserializable step arguments Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/64187fdcf999...19f72df00ef4
            oleg_nenashev Oleg Nenashev made changes -
            Labels robustness serialization JEP-200 robustness serialization
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The fix has been released in Pipeline: CPS 2.48. I will add it to https://wiki.jenkins.io/display/JENKINS/Plugins+affected+by+fix+for+JEP-200

            Show
            oleg_nenashev Oleg Nenashev added a comment - The fix has been released in Pipeline: CPS 2.48. I will add it to https://wiki.jenkins.io/display/JENKINS/Plugins+affected+by+fix+for+JEP-200
            oleg_nenashev Oleg Nenashev made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue relates to JENKINS-50633 [ JENKINS-50633 ]
            jamesdumay James Dumay made changes -
            Remote Link This issue links to "CloudBees Internal CLTS-2943 (Web Link)" [ 20530 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/pipeline/utility/steps/maven/WriteMavenPomStep.java
            http://jenkins-ci.org/commit/pipeline-utility-steps-plugin/44165d639385cede4367bd4360cbd15339f8542f
            Log:
            JENKINS-50633 - Pick up Pipeline: CPS version with JENKINS-50752

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/pipeline/utility/steps/maven/WriteMavenPomStep.java http://jenkins-ci.org/commit/pipeline-utility-steps-plugin/44165d639385cede4367bd4360cbd15339f8542f Log: JENKINS-50633 - Pick up Pipeline: CPS version with JENKINS-50752

              People

              Assignee:
              svanoort Sam Van Oort
              Reporter:
              svanoort Sam Van Oort
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: