Details
-
Type:
Bug
-
Status: In Progress (View Workflow)
-
Priority:
Major
-
Resolution: Unresolved
-
Component/s: gitlab-oauth-plugin
-
Labels:None
-
Similar Issues:
Description
Hello,
I've installed this plugin and configured an application in my user's applications' panel (note that I'm using a hosted version of GitLab, not the EE). Then, I've configured following values in the plugin:
(ID and secret is obviously truncated). However, when I click on the Login page, it correctly redirects me to GitLab, asks for the authorization, but when it redirects me back to Jenkins, I'm still not logged.
My environment is publicly open, but the server itself is behind a load balancer which redirects requests from https to http. Would that be the issue?
Best,
Rafal
Attachments
Activity
Rafal Janicki
created issue -
No, I'm using the hosted version, not the EE. But I guess it's up to date 
Rafal Janicki
added a comment - No, I'm using the hosted version, not the EE. But I guess it's up to date You can check with https://my.gitlab.hosted.somewere.url.com/help
Thibaud Lepretre
added a comment - You can check with https://my.gitlab.hosted.somewere.url.com/help Sorry, I think I'm using a wrong naming. I mean the version that's hosted on gitlab.com (SaaS), not self-hosted
Rafal Janicki
added a comment - Sorry, I think I'm using a wrong naming. I mean the version that's hosted on gitlab.com (SaaS), not self-hosted Ho OK thank for clarification so yes is 10.7 https://gitlab.com/help
Thibaud Lepretre
added a comment - Ho OK thank for clarification so yes is 10.7 https://gitlab.com/help We couldn't login anymore as well. Changing the java-gitlab-api package from version 1.2.6 to 4.0.0 fixed the issue for us. Obviously the old - and long-time deprecated - API endpoint 'api/v3' isn't working anymore to fetch additional user information against GitLab 10.7.
There is a coding standard issue remaining to be fixed though to pass findbugs testing:
Boxed value is unboxed and then immediately reboxed in org.jenkinsci.plugins.GitLabAuthenticationToken$3.call() [org.jenkinsci.plugins.GitLabAuthenticationToken$3] At GitLabAuthenticationToken.java:[line 271] BX_UNBOXING_IMMEDIATELY_REBOXED
Created an according PR with changed API support to v4 and fixed reboxing issue:
| Field | Original Value | New Value |
|---|---|---|
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | In Review [ 10005 ] |
| Status | In Review [ 10005 ] | In Progress [ 3 ] |
Sorry for the noise. Don't use JIRA and the Jenkins issue workflow too often.^^
Code changed in jenkins
User: Mario Steinitz
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/GitLabAuthenticationToken.java
src/main/webapp/help/realm/gitlab-api-uri-help.html
http://jenkins-ci.org/commit/gitlab-oauth-plugin/3ab60a7802059b0c53556c61132d234dc2b31310
Log:
JENKINS-50838 Change GitLab API support from v3 to v4.
Code changed in jenkins
User: Mohamed EL HABIB
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/GitLabAuthenticationToken.java
src/main/webapp/help/realm/gitlab-api-uri-help.html
http://jenkins-ci.org/commit/gitlab-oauth-plugin/88cd9747a472215fa751469d66e22c738ae7fb74
Log:
Merge pull request #10 from shoreless-ltd/issue-50838
JENKINS-50838 Change GitLab API support from v3 to v4.
Compare: https://github.com/jenkinsci/gitlab-oauth-plugin/compare/268a0d6c32e4...88cd9747a472
Are you using GitLab 10.7? I'm asking because since GitLab 10.7 I have issue with Jenkins GitLab Oauth plugin I have infinite redirection (because I think in my use case I'm have policy that force user to be logged, there is no public access even read-only).
With GitLab 10.6 I had no issues.
I think my issue should be the same as yours if you're using GitLab 10.7.