Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51158

Allow trailing dot in Root URL

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      As commented by James on the previous PR, the trailing dots are valid in URL.

        Attachments

          Issue Links

            Activity

            wfollonier Wadeck Follonier created issue -
            wfollonier Wadeck Follonier made changes -
            Field Original Value New Value
            Description As commented by James on the previous PR, the trailing dots are valid in URL. As [commented|https://github.com/jenkinsci/jenkins/commit/e7eec1cbe60067871689871f12a56d496abe60a2#r28867382] by James on the previous PR, the trailing dots are valid in URL.
            wfollonier Wadeck Follonier made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            wfollonier Wadeck Follonier made changes -
            Remote Link This issue links to "#3424 core (Web Link)" [ 20626 ]
            wfollonier Wadeck Follonier made changes -
            Description As [commented|https://github.com/jenkinsci/jenkins/commit/e7eec1cbe60067871689871f12a56d496abe60a2#r28867382] by James on the previous PR, the trailing dots are valid in URL. As [commented|https://github.com/jenkinsci/jenkins/commit/e7eec1cbe60067871689871f12a56d496abe60a2#r28867382] by James on the previous PR, the trailing dots are valid in URL.

            Not really critical since the trailing dot is not commonly used.
            wfollonier Wadeck Follonier made changes -
            Description As [commented|https://github.com/jenkinsci/jenkins/commit/e7eec1cbe60067871689871f12a56d496abe60a2#r28867382] by James on the previous PR, the trailing dots are valid in URL.

            Not really critical since the trailing dot is not commonly used.
            As [commented|https://github.com/jenkinsci/jenkins/commit/e7eec1cbe60067871689871f12a56d496abe60a2#r28867382] by James on the previous PR, the trailing dots are valid in URL.
            wfollonier Wadeck Follonier made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            wfollonier Wadeck Follonier made changes -
            Link This issue is related to JENKINS-51064 [ JENKINS-51064 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Wadeck Follonier
            Path:
            core/src/main/java/jenkins/util/UrlHelper.java
            core/src/test/java/jenkins/util/UrlHelperTest.java
            http://jenkins-ci.org/commit/jenkins/c79f3f719c3f320ff6f0b17fae7d15ee2c1cbbcb
            Log:
            JENKINS-51158 Improve Root URL validation

            • remove the bug for ipv6
            • remove the support of query that was not expected
            • add support for trailing dots
            • add lots of unit tests
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wadeck Follonier Path: core/src/main/java/jenkins/util/UrlHelper.java core/src/test/java/jenkins/util/UrlHelperTest.java http://jenkins-ci.org/commit/jenkins/c79f3f719c3f320ff6f0b17fae7d15ee2c1cbbcb Log: JENKINS-51158 Improve Root URL validation remove the bug for ipv6 remove the support of query that was not expected add support for trailing dots add lots of unit tests
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Devin Nusbaum
            Path:
            core/src/main/java/jenkins/util/UrlHelper.java
            core/src/test/java/jenkins/util/UrlHelperTest.java
            http://jenkins-ci.org/commit/jenkins/b03beb72f33c13ff57c761fe9a7a6a38fc195729
            Log:
            Merge pull request #3424 from Wadeck/JENINS-51158_IMPROVE_ROOT_URL_VALIDATION

            JENKINS-51158 Improve Root URL validation

            Compare: https://github.com/jenkinsci/jenkins/compare/f33731e7ec7a...b03beb72f33c
            *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

            Functionality will be removed from GitHub.com on January 31st, 2019.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Devin Nusbaum Path: core/src/main/java/jenkins/util/UrlHelper.java core/src/test/java/jenkins/util/UrlHelperTest.java http://jenkins-ci.org/commit/jenkins/b03beb72f33c13ff57c761fe9a7a6a38fc195729 Log: Merge pull request #3424 from Wadeck/JENINS-51158_IMPROVE_ROOT_URL_VALIDATION JENKINS-51158 Improve Root URL validation Compare: https://github.com/jenkinsci/jenkins/compare/f33731e7ec7a...b03beb72f33c * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
            Hide
            dnusbaum Devin Nusbaum added a comment -

            Released in Jenkins 2.124 (rerelease of 2.123). See the changelog.

            Show
            dnusbaum Devin Nusbaum added a comment - Released in Jenkins 2.124 (rerelease of 2.123). See the changelog .
            dnusbaum Devin Nusbaum made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels lts-candidate
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Needs backporting to 2.121.x IMHO

            Show
            oleg_nenashev Oleg Nenashev added a comment - Needs backporting to 2.121.x IMHO
            olivergondza Oliver Gond┼ża made changes -
            Labels lts-candidate 2.121.2-fixed
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Wadeck Follonier
            Path:
            core/src/main/java/jenkins/util/UrlHelper.java
            core/src/test/java/jenkins/util/UrlHelperTest.java
            http://jenkins-ci.org/commit/jenkins/f0311944a059da0a69c7822311e579918d7c2369
            Log:
            JENKINS-51158 Improve Root URL validation

            • remove the bug for ipv6
            • remove the support of query that was not expected
            • add support for trailing dots
            • add lots of unit tests

            (cherry picked from commit c79f3f719c3f320ff6f0b17fae7d15ee2c1cbbcb)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wadeck Follonier Path: core/src/main/java/jenkins/util/UrlHelper.java core/src/test/java/jenkins/util/UrlHelperTest.java http://jenkins-ci.org/commit/jenkins/f0311944a059da0a69c7822311e579918d7c2369 Log: JENKINS-51158 Improve Root URL validation remove the bug for ipv6 remove the support of query that was not expected add support for trailing dots add lots of unit tests (cherry picked from commit c79f3f719c3f320ff6f0b17fae7d15ee2c1cbbcb)

              People

              Assignee:
              wfollonier Wadeck Follonier
              Reporter:
              wfollonier Wadeck Follonier
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: