Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51395

withDockerRegistry([...]) syntax no longer accepted

      abayer's JENKINS-29711 allowed a parameter name to be omitted where there was a single parameter taking a nested structure and there were no other parameters. withDockerRegistry took advantage of this to allow the registry: to be elided. After JENKINS-38018 introduced an (optional) toolName parameter, this syntax stopped working; DSL silently omitted the registry parameter—and silently ignored the url and/or credentialsId parameters! Worse, Snippetizer offers the broken syntax when toolName is unset.

          [JENKINS-51395] withDockerRegistry([...]) syntax no longer accepted

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue blocks JENKINS-38018 [ JENKINS-38018 ]
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-29711 [ JENKINS-29711 ]
          Ivan Fernandez Calvo made changes -
          Assignee Original: Jesse Glick [ jglick ] New: Ivan Fernandez Calvo [ ifernandezcalvo ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "docker-workflow PR 138 (Web Link)" [ 20686 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "Page (Jenkins Wiki)" [ 20687 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-51403 [ JENKINS-51403 ]

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStepTest.java
          http://jenkins-ci.org/commit/docker-workflow-plugin/732e1bbf514a65893ebb381850884385e69b9ae1
          Log:
          JENKINS-51395 At least reproduced problem in test.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStepTest.java http://jenkins-ci.org/commit/docker-workflow-plugin/732e1bbf514a65893ebb381850884385e69b9ae1 Log: JENKINS-51395 At least reproduced problem in test.

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: