Details
-
New Feature
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
Description
When setting the new threshold to 1, if there are new warnings, the plugin marks the build as failure. If the next build will not have any new warnings (even without any change to any file) the status will be change back because the last new warnings are not consider new anymore.
There is another option to set the total threshold. The problem with this way is that whenever a warning is fixed, someone will need to change this threshold manually.
Comparing the total number of warnings with the total number of warnings in the last stable/unstable build might not be enough because someone can commit a change which will fix a warning but will add a new one.
Attachments
Issue Links
- is blocking
-
JENKINS-5344 checkstyle report calculator show difference between identical builds
-
- Closed
-
Activity
shimik
created issue -
| Field | Original Value | New Value |
|---|---|---|
| Component/s | checkstyle [ 15512 ] | |
| Component/s | dry [ 15591 ] | |
| Component/s | findbugs [ 15496 ] | |
| Component/s | tasks-plugin [ 15498 ] | |
| Component/s | warnings [ 15513 ] |
Code changed in hudson
User: : drulli
Path:
trunk/hudson/plugins/analysis-collector/pom.xml
trunk/hudson/plugins/analysis-collector/src/main/java/hudson/plugins/analysis/collector/AnalysisPublisher.java
trunk/hudson/plugins/analysis-collector/src/main/java/hudson/plugins/analysis/collector/AnalysisResult.java
trunk/hudson/plugins/analysis-collector/src/test/java/hudson/plugins/analysis/collector/AnalysisResultTest.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/AbstractProjectAction.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/AbstractResultAction.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/BuildResult.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/BuildResultEvaluator.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/HealthAwarePublisher.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/ResultAction.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/graph/CategoryBuildResultGraph.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/graph/DifferenceGraph.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/util/model/DefaultAnnotationContainer.java
trunk/hudson/plugins/analysis-core/src/test/java/hudson/plugins/analysis/core/BuildResultEvaluatorTest.java
trunk/hudson/plugins/analysis-core/src/test/java/hudson/plugins/analysis/graph/Main.java
trunk/hudson/plugins/analysis-test/pom.xml
trunk/hudson/plugins/analysis-test/src/main/java/hudson/plugins/analysis/test/BuildResultTest.java
trunk/hudson/plugins/checkstyle/pom.xml
trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/CheckStyleMavenResult.java
trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/CheckStylePublisher.java
trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/CheckStyleReporter.java
trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/CheckStyleResult.java
trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/MavenCheckStyleResultAction.java
trunk/hudson/plugins/checkstyle/src/test/java/hudson/plugins/checkstyle/CheckstyleResultTest.java
trunk/hudson/plugins/dry/pom.xml
trunk/hudson/plugins/dry/src/main/java/hudson/plugins/dry/DryMavenResult.java
trunk/hudson/plugins/dry/src/main/java/hudson/plugins/dry/DryPublisher.java
trunk/hudson/plugins/dry/src/main/java/hudson/plugins/dry/DryReporter.java
trunk/hudson/plugins/dry/src/main/java/hudson/plugins/dry/DryResult.java
trunk/hudson/plugins/dry/src/main/java/hudson/plugins/dry/MavenDryResultAction.java
trunk/hudson/plugins/dry/src/test/java/hudson/plugins/dry/DryResultTest.java
trunk/hudson/plugins/findbugs/plugin/pom.xml
trunk/hudson/plugins/findbugs/plugin/src/main/java/hudson/plugins/findbugs/FindBugsMavenResult.java
trunk/hudson/plugins/findbugs/plugin/src/main/java/hudson/plugins/findbugs/FindBugsPublisher.java
trunk/hudson/plugins/findbugs/plugin/src/main/java/hudson/plugins/findbugs/FindBugsReporter.java
trunk/hudson/plugins/findbugs/plugin/src/main/java/hudson/plugins/findbugs/FindBugsResult.java
trunk/hudson/plugins/findbugs/plugin/src/main/java/hudson/plugins/findbugs/MavenFindBugsResultAction.java
trunk/hudson/plugins/findbugs/plugin/src/test/java/hudson/plugins/findbugs/FindBugsResultTest.java
trunk/hudson/plugins/pmd/pom.xml
trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/MavenPmdResultAction.java
trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/PmdMavenResult.java
trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/PmdPublisher.java
trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/PmdReporter.java
trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/PmdResult.java
trunk/hudson/plugins/pmd/src/test/java/hudson/plugins/pmd/PmdResultTest.java
trunk/hudson/plugins/tasks/pom.xml
trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/MavenTasksResultAction.java
trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/TasksMavenResult.java
trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/TasksPublisher.java
trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/TasksReporter.java
trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/TasksResult.java
http://jenkins-ci.org/commit/28055
Log:
JENKINS-5147: Refactored BuildResult. Now a reference build is used to compute the new warnings.
Code changed in hudson
User: : drulli
Path:
trunk/hudson/plugins/analysis-collector/src/main/java/hudson/plugins/analysis/collector/AnalysisResult.java
trunk/hudson/plugins/analysis-collector/src/test/java/hudson/plugins/analysis/collector/AnalysisResultTest.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/BuildHistory.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/BuildResult.java
trunk/hudson/plugins/analysis-test/src/main/java/hudson/plugins/analysis/test/BuildResultTest.java
trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/CheckStyleResult.java
trunk/hudson/plugins/checkstyle/src/test/java/hudson/plugins/checkstyle/CheckstyleResultTest.java
trunk/hudson/plugins/codescanner/.project
trunk/hudson/plugins/dry/src/main/java/hudson/plugins/dry/DryResult.java
trunk/hudson/plugins/dry/src/test/java/hudson/plugins/dry/DryResultTest.java
trunk/hudson/plugins/findbugs/plugin/src/main/java/hudson/plugins/findbugs/FindBugsResult.java
trunk/hudson/plugins/findbugs/plugin/src/test/java/hudson/plugins/findbugs/FindBugsResultTest.java
trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/PmdResult.java
trunk/hudson/plugins/pmd/src/test/java/hudson/plugins/pmd/PmdResultTest.java
trunk/hudson/plugins/warnings/pom.xml
trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/WarningsPublisher.java
trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/WarningsResult.java
trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/WarningsResultAction.java
trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/WarningsResultTest.java
http://jenkins-ci.org/commit/28086
Log:
JENKINS-5147 Refactored build history computation to make it testable.
Code changed in hudson
User: : drulli
Path:
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/BuildResult.java
http://jenkins-ci.org/commit/28156
Log:
JENKINS-5147: Added high scores for successful builds in BuildResult.
Code changed in hudson
User: : drulli
Path:
trunk/hudson/plugins/analysis-collector/src/main/java/hudson/plugins/analysis/collector/AnalysisPublisher.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/BuildResultEvaluator.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/HealthAwarePublisher.java
trunk/hudson/plugins/analysis-core/src/main/resources/util/thresholds.jelly
trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/CheckStylePublisher.java
trunk/hudson/plugins/dry/src/main/java/hudson/plugins/dry/DryPublisher.java
trunk/hudson/plugins/findbugs/plugin/src/main/java/hudson/plugins/findbugs/FindBugsPublisher.java
trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/PmdPublisher.java
trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/TasksPublisher.java
trunk/hudson/plugins/warnings/.classpath
trunk/hudson/plugins/warnings/.settings/org.maven.ide.eclipse.prefs
trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/WarningsPublisher.java
http://jenkins-ci.org/commit/28482
Log:
JENKINS-5147: Added new property to use the delta rather than the set difference of the annotations to compute the number of new warnings.
| Link |
This issue is blocking |
| Status | Open [ 1 ] | In Progress [ 3 ] |
Code changed in hudson
User: : drulli
Path:
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/HealthAwarePublisher.java
trunk/hudson/plugins/analysis-core/src/main/resources/util/thresholds.jelly
trunk/hudson/plugins/analysis-core/src/main/resources/util/thresholds.properties
trunk/hudson/plugins/analysis-core/src/main/resources/util/thresholds_de.properties
trunk/hudson/plugins/analysis-test/src/main/java/hudson/plugins/analysis/test/BuildResultTest.java
http://jenkins-ci.org/commit/28519
Log:
[FIXED JENKINS-5147]: Improved documentation of useDeltaValues field.
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Resolved [ 5 ] |
Myron0815
added a comment - hmmm.. i have some problems/question with this implementation:
> use delta for new warnings:
> If set then the number of new warnings is calculated by subtracting the total number of warnings of the current build from the reference build
I have 9 unstable builds in my history, and 1 very old successful one (Hudson seems to keep the last successful build forever)
Regardless of the changes, the "new warnings" seem always calculated from the old successful build.
So i deleted that one, and now my new warnings dropped to zero; correctly calculating from last unstable build
So is there some priority in getting the reference build?
Whats the definition for reference build? (i expected always the last one as reference)
Is this a bug or a feature i miss to understand?!
Myron0815
added a comment - hmmm.. i have some problems/question with this implementation:
> use delta for new warnings:
> If set then the number of new warnings is calculated by subtracting the total number of warnings of the current build from the reference build
I have 9 unstable builds in my history, and 1 very old successful one (Hudson seems to keep the last successful build forever)
Regardless of the changes, the "new warnings" seem always calculated from the old successful build.
So i deleted that one, and now my new warnings dropped to zero; correctly calculating from last unstable build
So is there some priority in getting the reference build?
Whats the definition for reference build? (i expected always the last one as reference)
Is this a bug or a feature i miss to understand?! The reference build is the last build that has a plugin-status of success. I don't have the code here right now so I don't know how I implemented the fallback if there is no such build.
wrote some b/s... rethinking my issue
seems to work
.
Nevertheless, thanks for your hard work on these nice plugins - much appreciated 
Myron0815
added a comment - - edited wrote some b/s... rethinking my issue
seems to work
.
Nevertheless, thanks for your hard work on these nice plugins - much appreciated | Status | Resolved [ 5 ] | Closed [ 6 ] |
| Workflow | JNJira [ 135231 ] | JNJira + In-Review [ 203346 ] |
Code changed in hudson
User: : drulli
Path:
trunk/hudson/plugins/analysis-collector/pom.xml
trunk/hudson/plugins/analysis-collector/src/main/java/hudson/plugins/analysis/collector/AnalysisResultAction.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/AbstractResultAction.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/BuildResult.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/BuildResultEvaluator.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/HealthAwarePublisher.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/core/ResultAction.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/graph/CategoryBuildResultGraph.java
trunk/hudson/plugins/analysis-core/src/main/java/hudson/plugins/analysis/graph/DifferenceGraph.java
trunk/hudson/plugins/analysis-core/src/test/java/hudson/plugins/analysis/core/BuildResultEvaluatorTest.java
trunk/hudson/plugins/analysis-core/src/test/java/hudson/plugins/analysis/graph/Main.java
trunk/hudson/plugins/checkstyle/pom.xml
trunk/hudson/plugins/checkstyle/src/main/java/hudson/plugins/checkstyle/CheckStyleResultAction.java
trunk/hudson/plugins/dry/pom.xml
trunk/hudson/plugins/dry/src/main/java/hudson/plugins/dry/DryResultAction.java
trunk/hudson/plugins/findbugs/plugin/pom.xml
trunk/hudson/plugins/findbugs/plugin/src/main/java/hudson/plugins/findbugs/FindBugsResultAction.java
trunk/hudson/plugins/pmd/pom.xml
trunk/hudson/plugins/pmd/src/main/java/hudson/plugins/pmd/PmdResultAction.java
trunk/hudson/plugins/tasks/pom.xml
trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/TasksResultAction.java
http://jenkins-ci.org/commit/27904
Log:
JENKINS-5147: Added a first implementation that uses that last successful build as base when computing the new warnings.