Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51495

descriptorRadioList does not honor DescriptorVisibilityFilter

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • core
    • None
    • Jenkins 2.224 (reverted in 2.225)

      descriptorRadioList does not honor DescriptorVisibilityFilter extensions.

      The workaround for this has been to pass an already filtered list of descriptors to descriptorRadioList (ie here):

      f.descriptorRadioList([...], descriptors: h.filterDescriptors(app, MyExtensionPoint.all()))
      

      However this has a side effect as descriptorRadioList is using an index to match frontend selected descriptor with a backend instance, so when a descriptor is hidden (by the visibility filter) in the frontend then backend indexes do not match.

      So, I believe descriptorRadioList should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward).

          [JENKINS-51495] descriptorRadioList does not honor DescriptorVisibilityFilter

          Antonio Muñiz created issue -
          Oleg Nenashev made changes -
          Labels New: newbie-friendly
          CloudBees Inc. made changes -
          Remote Link New: This issue links to "CloudBees Internal CJP-8629 (Web Link)" [ 21119 ]
          Sho Matsumoto made changes -
          Assignee New: Sho Matsumoto [ matsushou ]

          Sho Matsumoto added a comment -

          > So, I believe descriptorRadioList should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward).

          I followed b) plan and stop using indexes and begin using id instead.

          Sho Matsumoto added a comment - > So, I believe  descriptorRadioList  should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward). I followed b) plan and stop using indexes and begin using id instead.
          Baptiste Mathus made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Oleg Nenashev added a comment -

          I am not sure it should be ported to LTS, definitely not to 2.222.1 taking the merge date

          Oleg Nenashev added a comment - I am not sure it should be ported to LTS, definitely not to 2.222.1 taking the merge date
          Oleg Nenashev made changes -
          Released As New: Jenkins 2.224
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Oleg Nenashev made changes -
          Labels Original: newbie-friendly New: 2.222.1-rejected lts-candidate newbie-friendly
          Oleg Nenashev made changes -
          Link New: This issue causes JENKINS-61398 [ JENKINS-61398 ]

            Unassigned Unassigned
            amuniz Antonio Muñiz
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated: