[JENKINS-51584] actions from TransientActionFactories are saved in Builds. - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: core
Labels:
- 2.121.2-fixed

Similar Issues:

Show

Description

Actions created from a TransientActionFactory are persisted in a Run when they should never be persisted.

If you have a TAF that creates an action for any ModelItem then on {{FreeStyleBuild}}s you will end up with 3 duplicate Actions displayed (and 2 will be persisted in the build.xml)

One is created for the hudson.model.Queue$WaitingItem one for the hudson.model.Queue$BuildableItem and the last one for the actual build (which is the one that is not persisted).

build.xml

<?xml version='1.1' encoding='UTF-8'?>
<build>
    <actions>
        <hudson.model.CauseAction>
            <causeBag class="linked-hash-map">
                <entry>
                    <hudson.model.Cause_-UserIdCause>
                        <userId>james</userId>
                    </hudson.model.Cause_-UserIdCause>
                    <int>1</int>
                </entry>
            </causeBag>
        </hudson.model.CauseAction>
        <com.myco.myplugin.MyAction>
            <target>hudson.model.Queue$WaitingItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target>
        </com.myco.myplugin.MyAction>
        <com.myco.myplugin.MyAction>
            <target>hudson.model.Queue$BuildableItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target>
        </com.myco.myplugin.MyAction>
        <jenkins.metrics.impl.TimeInQueueAction>
            <queuingDurationMillis>9</queuingDurationMillis>
        </jenkins.metrics.impl.TimeInQueueAction>
    </actions>
    <queueId>5</queueId>
    <timestamp>1527599156095</timestamp>
    <startTime>1527599156104</startTime>
    <result>SUCCESS</result>
    <duration>3225</duration>
    <charset>windows-1252</charset>
    <keepLog>false</keepLog>
    <builtOn></builtOn>
    <workspace>C:\workarea\yplugin\work\workspace\free</workspace>
    <hudsonVersion>2.107.3</hudsonVersion>
    <scm class="hudson.scm.NullChangeLogParser"/>
    <culprits class="com.google.common.collect.EmptyImmutableSortedSet"/>
</build>

Attachments

Issue Links

relates to

JENKINS-44624 Extending BlueOceanUrlAction + BlueOceanUrlActionFactory leads to duplicate Blue Ocean link

Closed

JENKINS-45476 Multiple Blue Ocean links are displayed

Closed

JENKINS-44964 NPE in logs when browsing Maven projects

Closed

JENKINS-51627 remove "Try Blue" action hacks

Closed

links to

CloudBees Internal CJP-8826

PR#3462

(1 links to)

Activity

Ascending order - Click to sort in descending order

James Nord created issue - 2018-05-29 13:14

James Nord made changes - 2018-05-29 13:15

Field	Original Value	New Value
Description	{{Actions}} created from a {{TransientActionFactory}} are persisted in a {{Run}} when they should never be persisted. If you have a {{TAF}} that creates an action for any {{ModelItem}} then on {{FreeStyleBuild}}s you will end up with 3 duplicate Actions displayed (and 2 will be persisted in the build.xml) One is created for the {{hudson.model.Queue$WaitingItem}} one for the {{hudson.model.Queue$BuildableItem}} and the last one for the actual build (which is the one that is not persisted). {code:java} <?xml version='1.1' encoding='UTF-8'?> <build> <actions> <hudson.model.CauseAction> <causeBag class="linked-hash-map"> <entry> <hudson.model.Cause_-UserIdCause> <userId>james</userId> </hudson.model.Cause_-UserIdCause> <int>1</int> </entry> </causeBag> </hudson.model.CauseAction> <com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction plugin="bluesteel-cjoc@1.2.7-SNAPSHOT"> <target>hudson.model.Queue$WaitingItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target> </com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction> <com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction plugin="bluesteel-cjoc@1.2.7-SNAPSHOT"> <target>hudson.model.Queue$BuildableItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target> </com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction> <jenkins.metrics.impl.TimeInQueueAction plugin="metrics@3.1.2.12"> <queuingDurationMillis>9</queuingDurationMillis> </jenkins.metrics.impl.TimeInQueueAction> </actions> <queueId>5</queueId> <timestamp>1527599156095</timestamp> <startTime>1527599156104</startTime> <result>SUCCESS</result> <duration>3225</duration> <charset>windows-1252</charset> <keepLog>false</keepLog> <builtOn></builtOn> <workspace>C:\workarea\source\github\cloudbees\bluesteel\bluesteel-cjoc\work\workspace\free</workspace> <hudsonVersion>2.107.3-cb-1</hudsonVersion> <scm class="hudson.scm.NullChangeLogParser"/> <culprits class="com.google.common.collect.EmptyImmutableSortedSet"/> </build> {code}	{{Actions}} created from a {{TransientActionFactory}} are persisted in a {{Run}} when they should never be persisted. If you have a {{TAF}} that creates an action for any {{ModelItem}} then on {{FreeStyleBuild}}s you will end up with 3 duplicate Actions displayed (and 2 will be persisted in the build.xml) One is created for the {{hudson.model.Queue$WaitingItem}} one for the {{hudson.model.Queue$BuildableItem}} and the last one for the actual build (which is the one that is not persisted). {code:title=build.xml\|xml} <?xml version='1.1' encoding='UTF-8'?> <build> <actions> <hudson.model.CauseAction> <causeBag class="linked-hash-map"> <entry> <hudson.model.Cause_-UserIdCause> <userId>james</userId> </hudson.model.Cause_-UserIdCause> <int>1</int> </entry> </causeBag> </hudson.model.CauseAction> <com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction plugin="bluesteel-cjoc@1.2.7-SNAPSHOT"> <target>hudson.model.Queue$WaitingItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target> </com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction> <com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction plugin="bluesteel-cjoc@1.2.7-SNAPSHOT"> <target>hudson.model.Queue$BuildableItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target> </com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction> <jenkins.metrics.impl.TimeInQueueAction plugin="metrics@3.1.2.12"> <queuingDurationMillis>9</queuingDurationMillis> </jenkins.metrics.impl.TimeInQueueAction> </actions> <queueId>5</queueId> <timestamp>1527599156095</timestamp> <startTime>1527599156104</startTime> <result>SUCCESS</result> <duration>3225</duration> <charset>windows-1252</charset> <keepLog>false</keepLog> <builtOn></builtOn> <workspace>C:\workarea\source\github\cloudbees\bluesteel\bluesteel-cjoc\work\workspace\free</workspace> <hudsonVersion>2.107.3-cb-1</hudsonVersion> <scm class="hudson.scm.NullChangeLogParser"/> <culprits class="com.google.common.collect.EmptyImmutableSortedSet"/> </build> {code}

James Nord made changes - 2018-05-29 13:17

Description

{{Actions}} created from a {{TransientActionFactory}} are persisted in a {{Run}} when they should never be persisted.

If you have a {{TAF}} that creates an action for any {{ModelItem}} then on {{FreeStyleBuild}}s you will end up with 3 duplicate Actions displayed (and 2 will be persisted in the build.xml)

One is created for the {{hudson.model.Queue$WaitingItem}} one for the {{hudson.model.Queue$BuildableItem}} and the last one for the actual build (which is the one that is not persisted).

{code:title=build.xml|xml}
<?xml version='1.1' encoding='UTF-8'?>
<build>
<actions>
<hudson.model.CauseAction>
<causeBag class="linked-hash-map">
<entry>
<hudson.model.Cause_-UserIdCause>
<userId>james</userId>
</hudson.model.Cause_-UserIdCause>
<int>1</int>
</entry>
</causeBag>
</hudson.model.CauseAction>
<com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction plugin="bluesteel-cjoc@1.2.7-SNAPSHOT">
<target>hudson.model.Queue$WaitingItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target>
</com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction>
<com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction plugin="bluesteel-cjoc@1.2.7-SNAPSHOT">
<target>hudson.model.Queue$BuildableItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target>
</com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction>
<jenkins.metrics.impl.TimeInQueueAction plugin="metrics@3.1.2.12">
<queuingDurationMillis>9</queuingDurationMillis>
</jenkins.metrics.impl.TimeInQueueAction>
</actions>
<queueId>5</queueId>
<timestamp>1527599156095</timestamp>
<startTime>1527599156104</startTime>
<result>SUCCESS</result>
<duration>3225</duration>
<charset>windows-1252</charset>
<keepLog>false</keepLog>
<builtOn></builtOn>
<workspace>C:\workarea\source\github\cloudbees\bluesteel\bluesteel-cjoc\work\workspace\free</workspace>
<hudsonVersion>2.107.3-cb-1</hudsonVersion>
<scm class="hudson.scm.NullChangeLogParser"/>
<culprits class="com.google.common.collect.EmptyImmutableSortedSet"/>
</build>
{code}

{{Actions}} created from a {{TransientActionFactory}} are persisted in a {{Run}} when they should never be persisted.

If you have a {{TAF}} that creates an action for any {{ModelItem}} then on {{FreeStyleBuild}}s you will end up with 3 duplicate Actions displayed (and 2 will be persisted in the build.xml)

One is created for the {{hudson.model.Queue$WaitingItem}} one for the {{hudson.model.Queue$BuildableItem}} and the last one for the actual build (which is the one that is not persisted).

{code:title=build.xml|xml}
<?xml version='1.1' encoding='UTF-8'?>
<build>
    <actions>
        <hudson.model.CauseAction>
            <causeBag class="linked-hash-map">
                <entry>
                    <hudson.model.Cause_-UserIdCause>
                        <userId>james</userId>
                    </hudson.model.Cause_-UserIdCause>
                    <int>1</int>
                </entry>
            </causeBag>
        </hudson.model.CauseAction>
        <com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction plugin="bluesteel-cjoc@1.2.7-SNAPSHOT">
            <target>hudson.model.Queue$WaitingItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target>
        </com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction>
        <com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction plugin="bluesteel-cjoc@1.2.7-SNAPSHOT">
            <target>hudson.model.Queue$BuildableItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target>
        </com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction>
        <jenkins.metrics.impl.TimeInQueueAction plugin="metrics@3.1.2.12">
            <queuingDurationMillis>9</queuingDurationMillis>
        </jenkins.metrics.impl.TimeInQueueAction>
    </actions>
    <queueId>5</queueId>
    <timestamp>1527599156095</timestamp>
    <startTime>1527599156104</startTime>
    <result>SUCCESS</result>
    <duration>3225</duration>
    <charset>windows-1252</charset>
    <keepLog>false</keepLog>
    <builtOn></builtOn>
    <workspace>C:\workarea\source\github\cloudbees\bluesteel\bluesteel-cjoc\work\workspace\free</workspace>
    <hudsonVersion>2.107.3-cb-1</hudsonVersion>
    <scm class="hudson.scm.NullChangeLogParser"/>
    <culprits class="com.google.common.collect.EmptyImmutableSortedSet"/>
</build>
{code}

James Nord made changes - 2018-05-29 13:19

Description

{{Actions}} created from a {{TransientActionFactory}} are persisted in a {{Run}} when they should never be persisted.

If you have a {{TAF}} that creates an action for any {{ModelItem}} then on {{FreeStyleBuild}}s you will end up with 3 duplicate Actions displayed (and 2 will be persisted in the build.xml)

One is created for the {{hudson.model.Queue$WaitingItem}} one for the {{hudson.model.Queue$BuildableItem}} and the last one for the actual build (which is the one that is not persisted).

{code:title=build.xml|xml}
<?xml version='1.1' encoding='UTF-8'?>
<build>
    <actions>
        <hudson.model.CauseAction>
            <causeBag class="linked-hash-map">
                <entry>
                    <hudson.model.Cause_-UserIdCause>
                        <userId>james</userId>
                    </hudson.model.Cause_-UserIdCause>
                    <int>1</int>
                </entry>
            </causeBag>
        </hudson.model.CauseAction>
        <com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction plugin="bluesteel-cjoc@1.2.7-SNAPSHOT">
            <target>hudson.model.Queue$WaitingItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target>
        </com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction>
        <com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction plugin="bluesteel-cjoc@1.2.7-SNAPSHOT">
            <target>hudson.model.Queue$BuildableItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target>
        </com.cloudbees.opscenter.server.bluesteel.action.BlueSteelUrlAction>
        <jenkins.metrics.impl.TimeInQueueAction plugin="metrics@3.1.2.12">
            <queuingDurationMillis>9</queuingDurationMillis>
        </jenkins.metrics.impl.TimeInQueueAction>
    </actions>
    <queueId>5</queueId>
    <timestamp>1527599156095</timestamp>
    <startTime>1527599156104</startTime>
    <result>SUCCESS</result>
    <duration>3225</duration>
    <charset>windows-1252</charset>
    <keepLog>false</keepLog>
    <builtOn></builtOn>
    <workspace>C:\workarea\source\github\cloudbees\bluesteel\bluesteel-cjoc\work\workspace\free</workspace>
    <hudsonVersion>2.107.3-cb-1</hudsonVersion>
    <scm class="hudson.scm.NullChangeLogParser"/>
    <culprits class="com.google.common.collect.EmptyImmutableSortedSet"/>
</build>
{code}

{{Actions}} created from a {{TransientActionFactory}} are persisted in a {{Run}} when they should never be persisted.

If you have a {{TAF}} that creates an action for any {{ModelItem}} then on {{FreeStyleBuild}}s you will end up with 3 duplicate Actions displayed (and 2 will be persisted in the build.xml)

One is created for the {{hudson.model.Queue$WaitingItem}} one for the {{hudson.model.Queue$BuildableItem}} and the last one for the actual build (which is the one that is not persisted).

{code:title=build.xml|xml}
<?xml version='1.1' encoding='UTF-8'?>
<build>
    <actions>
        <hudson.model.CauseAction>
            <causeBag class="linked-hash-map">
                <entry>
                    <hudson.model.Cause_-UserIdCause>
                        <userId>james</userId>
                    </hudson.model.Cause_-UserIdCause>
                    <int>1</int>
                </entry>
            </causeBag>
        </hudson.model.CauseAction>
        <com.myco.myplugin.MyAction>
            <target>hudson.model.Queue$WaitingItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target>
        </com.myco.myplugin.MyAction>
        <com.myco.myplugin.MyAction>
            <target>hudson.model.Queue$BuildableItem:hudson.model.FreeStyleProject@11e31cdf[free]:5</target>
        </com.myco.myplugin.MyAction>
        <jenkins.metrics.impl.TimeInQueueAction>
            <queuingDurationMillis>9</queuingDurationMillis>
        </jenkins.metrics.impl.TimeInQueueAction>
    </actions>
    <queueId>5</queueId>
    <timestamp>1527599156095</timestamp>
    <startTime>1527599156104</startTime>
    <result>SUCCESS</result>
    <duration>3225</duration>
    <charset>windows-1252</charset>
    <keepLog>false</keepLog>
    <builtOn></builtOn>
    <workspace>C:\workarea\yplugin\work\workspace\free</workspace>
    <hudsonVersion>2.107.3</hudsonVersion>
    <scm class="hudson.scm.NullChangeLogParser"/>
    <culprits class="com.google.common.collect.EmptyImmutableSortedSet"/>
</build>
{code}

Oleg Nenashev added a comment - 2018-05-29 16:52

Weird, but I cannot reproduce it.
Please provide version of Jenkins and other plugins you have installed.

Oleg Nenashev added a comment - 2018-05-29 16:52 Weird, but I cannot reproduce it. Please provide version of Jenkins and other plugins you have installed.

James Nord added a comment - 2018-05-29 18:16

weired yes
it affects 2.107 2.121 and possibly much older.

I have a fix I am testing (3 character changes) and is easily reproducible

James Nord added a comment - 2018-05-29 18:16 weired yes it affects 2.107 2.121 and possibly much older. I have a fix I am testing (3 character changes) and is easily reproducible

CloudBees Inc. made changes - 2018-05-30 00:01

Remote Link

This issue links to "CloudBees Internal CJP-8826 (Web Link)" [ 20759 ]

James Nord added a comment - 2018-05-30 10:39

PR with unit test. code fix to follow.

James Nord added a comment - 2018-05-30 10:39 PR with unit test. code fix to follow.

James Nord made changes - 2018-05-30 10:39

Remote Link

This issue links to "PR#3462 (Web Link)" [ 20766 ]

James Nord added a comment - 2018-05-30 10:40 - edited

BlueOcean has run into this issue, see linked tickets and the craxy workaround

James Nord added a comment - 2018-05-30 10:40 - edited BlueOcean has run into this issue, see linked tickets and the craxy workaround

James Nord made changes - 2018-05-30 12:44

Link

This issue relates to ~~JENKINS-44624~~ [ ~~JENKINS-44624~~ ]

James Nord made changes - 2018-05-30 12:44

Link

This issue relates to ~~JENKINS-44964~~ [ ~~JENKINS-44964~~ ]

James Nord made changes - 2018-05-30 12:44

Link

This issue relates to ~~JENKINS-45476~~ [ ~~JENKINS-45476~~ ]

James Nord added a comment - 2018-05-30 14:50

code has been there since the original introduction of TransientActionFactory. I think an over eager refactoring within the IDE was at play. It looks like there are some more iffy refactorings (but not subject to this issue / PR)

James Nord added a comment - 2018-05-30 14:50 code has been there since the original introduction of TransientActionFactory. I think an over eager refactoring within the IDE was at play. It looks like there are some more iffy refactorings (but not subject to this issue / PR)

James Nord made changes - 2018-05-30 15:01

Assignee

James Nord [ teilo ]

James Nord made changes - 2018-05-30 15:01

Status

Open [ 1 ]

In Progress [ 3 ]

James Nord made changes - 2018-05-30 15:01

Status

In Progress [ 3 ]

In Review [ 10005 ]

Jesse Glick added a comment - 2018-05-30 16:50

Probably you lack context to file a fix for the weird code in TryBlueOceanMenu but could you please at least file a bug in blueocean-plugin requesting its removal with the fix of the core bug? (Or earlier, if they just cease to apply the factory overly broadly to ModelObject and actually enumerate the sensible target types.)

Jesse Glick added a comment - 2018-05-30 16:50 Probably you lack context to file a fix for the weird code in TryBlueOceanMenu but could you please at least file a bug in blueocean-plugin requesting its removal with the fix of the core bug? (Or earlier, if they just cease to apply the factory overly broadly to ModelObject and actually enumerate the sensible target types.)

SCM/JIRA link daemon added a comment - 2018-05-31 09:37

Code changed in jenkins
User: James Nord
Path:
test/src/test/java/jenkins/model/TransientActionFactoryTest.java
http://jenkins-ci.org/commit/jenkins/cf3389f33f19c53cb5faf4c4657d95c7549272cf
Log:
~~JENKINS-51584~~ Added unit test showing the issue.

The Actions are created for the hudson.model.Queue$WaitingItem and
hudson.model.Queue$BuildableItem but get persisted in the actions list
of the build.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37 Code changed in jenkins User: James Nord Path: test/src/test/java/jenkins/model/TransientActionFactoryTest.java http://jenkins-ci.org/commit/jenkins/cf3389f33f19c53cb5faf4c4657d95c7549272cf Log: JENKINS-51584 Added unit test showing the issue. The Actions are created for the hudson.model.Queue$WaitingItem and hudson.model.Queue$BuildableItem but get persisted in the actions list of the build.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37

Code changed in jenkins
User: James Nord
Path:
test/src/test/java/jenkins/model/TransientActionFactoryTest.java
http://jenkins-ci.org/commit/jenkins/ed4c94a0a10eacc6fc5dee6783f88f216cb0017d
Log:
~~JENKINS-51584~~ Unit test was not quite correct.

Calling getActions(class) will include actions froma TransientActionFactory.

To get the correct results just call getActions() and then filter the result.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37 Code changed in jenkins User: James Nord Path: test/src/test/java/jenkins/model/TransientActionFactoryTest.java http://jenkins-ci.org/commit/jenkins/ed4c94a0a10eacc6fc5dee6783f88f216cb0017d Log: JENKINS-51584 Unit test was not quite correct. Calling getActions(class) will include actions froma TransientActionFactory. To get the correct results just call getActions() and then filter the result.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37

Code changed in jenkins
User: James Nord
Path:
test/src/test/java/jenkins/model/TransientActionFactoryTest.java
http://jenkins-ci.org/commit/jenkins/5b6acd7c2cd6a1f1784f2fe8b13875bde5a54fa0
Log:
~~JENKINS-51584~~ Unit test was not quite correct.

Calling getActions(class) will include actions froma TransientActionFactory.

To get the correct results just call getActions() and then filter the result.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37 Code changed in jenkins User: James Nord Path: test/src/test/java/jenkins/model/TransientActionFactoryTest.java http://jenkins-ci.org/commit/jenkins/5b6acd7c2cd6a1f1784f2fe8b13875bde5a54fa0 Log: JENKINS-51584 Unit test was not quite correct. Calling getActions(class) will include actions froma TransientActionFactory. To get the correct results just call getActions() and then filter the result.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37

Code changed in jenkins
User: James Nord
Path:
test/src/test/java/jenkins/model/TransientActionFactoryTest.java
http://jenkins-ci.org/commit/jenkins/c4215dc6ad5f974c740bed925aaba655b27e453a
Log:
~~JENKINS-51584~~ Improve unit test to show allocation trace.

improve the unit test to show the allocation trace on failure.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37 Code changed in jenkins User: James Nord Path: test/src/test/java/jenkins/model/TransientActionFactoryTest.java http://jenkins-ci.org/commit/jenkins/c4215dc6ad5f974c740bed925aaba655b27e453a Log: JENKINS-51584 Improve unit test to show allocation trace. improve the unit test to show the allocation trace on failure.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37

Code changed in jenkins
User: James Nord
Path:
core/src/main/java/hudson/model/Queue.java
core/src/main/java/hudson/model/queue/WorkUnitContext.java
http://jenkins-ci.org/commit/jenkins/8ca803819bbd7f5ecaf44179680d6694999e74d4
Log:
~~JENKINS-51584~~ do not store actions from TransientActionFactory.

The code was updated to use the non deprecated getAllActions() to obtain
the list of actions, however this was persisted in the actions causing
the actions from TransientActionFactories to be persisted in Builds.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37 Code changed in jenkins User: James Nord Path: core/src/main/java/hudson/model/Queue.java core/src/main/java/hudson/model/queue/WorkUnitContext.java http://jenkins-ci.org/commit/jenkins/8ca803819bbd7f5ecaf44179680d6694999e74d4 Log: JENKINS-51584 do not store actions from TransientActionFactory. The code was updated to use the non deprecated getAllActions() to obtain the list of actions, however this was persisted in the actions causing the actions from TransientActionFactories to be persisted in Builds.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37

Code changed in jenkins
User: James Nord
Path:
core/src/main/java/hudson/model/Queue.java
core/src/main/java/hudson/model/queue/WorkUnitContext.java
test/src/test/java/jenkins/model/TransientActionFactoryTest.java
http://jenkins-ci.org/commit/jenkins/d4737b2b60438ce0e3cb7a8a6f26675f7c880914
Log:
Merge pull request #3462 from jtnord/~~JENKINS-51584~~

~~JENKINS-51584~~ Actions from a TransientActionFactory should not be persisted

Compare: https://github.com/jenkinsci/jenkins/compare/8872b44cc882...d4737b2b6043
*NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

Functionality will be removed from GitHub.com on January 31st, 2019.

SCM/JIRA link daemon added a comment - 2018-05-31 09:37 Code changed in jenkins User: James Nord Path: core/src/main/java/hudson/model/Queue.java core/src/main/java/hudson/model/queue/WorkUnitContext.java test/src/test/java/jenkins/model/TransientActionFactoryTest.java http://jenkins-ci.org/commit/jenkins/d4737b2b60438ce0e3cb7a8a6f26675f7c880914 Log: Merge pull request #3462 from jtnord/ JENKINS-51584 JENKINS-51584 Actions from a TransientActionFactory should not be persisted Compare: https://github.com/jenkinsci/jenkins/compare/8872b44cc882...d4737b2b6043 * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

James Nord made changes - 2018-05-31 09:39

Resolution		Fixed [ 1 ]
Status	In Review [ 10005 ]	Resolved [ 5 ]

James Nord made changes - 2018-05-31 09:42

Link

This issue relates to ~~JENKINS-51627~~ [ ~~JENKINS-51627~~ ]

James Nord made changes - 2018-05-31 09:45

Labels

lts-candidate

Oleg Nenashev added a comment - 2018-06-06 09:38

Fixed in 2.126

Oleg Nenashev added a comment - 2018-06-06 09:38 Fixed in 2.126

Oliver Gondža made changes - 2018-06-07 06:06

Labels

lts-candidate

2.121.2-fixed

SCM/JIRA link daemon added a comment - 2018-06-08 10:22

Code changed in jenkins
User: James Nord
Path:
core/src/main/java/hudson/model/Queue.java
core/src/main/java/hudson/model/queue/WorkUnitContext.java
test/src/test/java/jenkins/model/TransientActionFactoryTest.java
http://jenkins-ci.org/commit/jenkins/4f576414b544a3d78e7156e6b1d1b12ed7406455
Log:
Merge pull request #3462 from jtnord/~~JENKINS-51584~~

~~JENKINS-51584~~ Actions from a TransientActionFactory should not be persisted

(cherry picked from commit d4737b2b60438ce0e3cb7a8a6f26675f7c880914)

SCM/JIRA link daemon added a comment - 2018-06-08 10:22 Code changed in jenkins User: James Nord Path: core/src/main/java/hudson/model/Queue.java core/src/main/java/hudson/model/queue/WorkUnitContext.java test/src/test/java/jenkins/model/TransientActionFactoryTest.java http://jenkins-ci.org/commit/jenkins/4f576414b544a3d78e7156e6b1d1b12ed7406455 Log: Merge pull request #3462 from jtnord/ JENKINS-51584 JENKINS-51584 Actions from a TransientActionFactory should not be persisted (cherry picked from commit d4737b2b60438ce0e3cb7a8a6f26675f7c880914)

James Nord made changes - 2020-12-10 13:45

Assignee

James Nord [ teilo ]

People

Assignee:: Unassigned

Reporter:: James Nord

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2018-05-29 13:14

Updated:: 2020-12-10 13:45

Resolved:: 2018-05-31 09:39