Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5184

No up/downstream indication when using Parameterized Build Trigger plugin

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • Hudson 1.338
      Parameterized Trigger Plugin 2.0

      (Copy of mail from Tim Arant on Hudson User list)

      I have noticed some issues related to Up-Stream and Down-Stream projects.

      Build other projects

      When this option is checked and a Down-Stream project is supplied, hyper-links appear on each related Project page that there is an Up-Stream or Down-Stream project associated with the Project being viewed,

      Trigger parameterized build on other projects

      When this option is checked and a Down-Stream project is supplied, no hyper-links appear on each related Project page. I realize that this is part of the Trigger plug-in, but it would be nice if this plug-in simply modified the existing "Build other projects" and allowed parameter definition, or, have this plug-in create the hyper-link relationships.

          [JENKINS-5184] No up/downstream indication when using Parameterized Build Trigger plugin

          Ringo De Smet created issue -

          Ringo De Smet added a comment -

          I suspect that the missing up/downstream relations prevent the "Aggregate downstream test results" post-build action to work.

          Ringo De Smet added a comment - I suspect that the missing up/downstream relations prevent the "Aggregate downstream test results" post-build action to work.

          Alan Harder added a comment -

          Code for adding this dependency graph connection was done by huybrechts last August in r20598. Unfortunately this has caused builds to now be triggered twice (JENKINS-5232). May have to roll back that change..

          Alan Harder added a comment - Code for adding this dependency graph connection was done by huybrechts last August in r20598. Unfortunately this has caused builds to now be triggered twice ( JENKINS-5232 ). May have to roll back that change..

          Alan Harder added a comment -

          Need update in Hudson core so this plugin can implement DependecyDeclarer API (which will make Hudson show the Upstream/Downstream jobs on job pages) and provide the build parameters via that interface. Currently that API will just trigger builds always (even after failed/aborted builds) and won't use any parameters.

          Alan Harder added a comment - Need update in Hudson core so this plugin can implement DependecyDeclarer API (which will make Hudson show the Upstream/Downstream jobs on job pages) and provide the build parameters via that interface. Currently that API will just trigger builds always (even after failed/aborted builds) and won't use any parameters.
          Alan Harder made changes -
          Link New: This issue depends on JENKINS-5236 [ JENKINS-5236 ]
          Alan Harder made changes -
          Assignee Original: huybrechts [ huybrechts ] New: Alan Harder [ mindless ]
          Alan Harder made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Alan Harder added a comment -

          Update in Hudson core completed and will be in Hudson 1.341 (JENKINS-5236). I have local changes ready to make use of this in parameterized trigger plugin, and will commit once 1.341 is out. I set it up so it will take advantage of this feature if you have 1.341 or higher, but the plugin will still work with 1.319 or higher.

          Alan Harder added a comment - Update in Hudson core completed and will be in Hudson 1.341 ( JENKINS-5236 ). I have local changes ready to make use of this in parameterized trigger plugin, and will commit once 1.341 is out. I set it up so it will take advantage of this feature if you have 1.341 or higher, but the plugin will still work with 1.319 or higher.

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/plugins/parameterized-trigger/pom.xml
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/AbstractBuildParameters.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTriggerConfig.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/CurrentBuildParameters.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/FileBuildParameters.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/ParameterizedDependency.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/PredefinedBuildParameters.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/SubversionRevisionBuildParameters.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/CurrentBuildParametersTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/DefaultParametersTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/DontBuildTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/FileBuildTriggerConfigTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/PredefinedPropertiesBuildTriggerConfigTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/ResultConditionTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/SubversionRevisionBuildTriggerConfigTest.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=25910
          Log:
          [FIXED JENKINS-5184] Use new DependencyGraph.Dependency API in Hudson core (1.341+)
          to declare downstream projects and invoke them with appropriate parameters.
          Plugin now builds against 1.341, but it is coded to only use the new API when
          present, so minimum Hudson version for this plugin is now 1.319.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/plugins/parameterized-trigger/pom.xml trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/AbstractBuildParameters.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTriggerConfig.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/CurrentBuildParameters.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/FileBuildParameters.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/ParameterizedDependency.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/PredefinedBuildParameters.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/SubversionRevisionBuildParameters.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/CurrentBuildParametersTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/DefaultParametersTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/DontBuildTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/FileBuildTriggerConfigTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/PredefinedPropertiesBuildTriggerConfigTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/ResultConditionTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/SubversionRevisionBuildTriggerConfigTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=25910 Log: [FIXED JENKINS-5184] Use new DependencyGraph.Dependency API in Hudson core (1.341+) to declare downstream projects and invoke them with appropriate parameters. Plugin now builds against 1.341, but it is coded to only use the new API when present, so minimum Hudson version for this plugin is now 1.319.
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

            abayer Andrew Bayer
            ridesmet Ringo De Smet
            Votes:
            7 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved: