-
Bug
-
Resolution: Fixed
-
Critical
-
Java 11 preview
When running on Java 11, some plugins fail to startup with the following error:
INFO: Winstone Servlet Engine v4.0 running: controlPort=disabled Jun 11, 2018 10:01:07 PM jenkins.InitReactorRunner$1 onAttained INFO: Started initialization Jun 11, 2018 10:01:07 PM jenkins.InitReactorRunner$1 onTaskFailed SEVERE: Failed Inspecting plugin /Users/nenashev/Documents/jenkins/test/java10/work/plugins/git-client.jpi java.io.IOException: invalid manifest format at java.base/java.util.jar.Manifest.read(Manifest.java:223) at java.base/java.util.jar.Manifest.<init>(Manifest.java:69) at java.base/java.util.jar.JarFile.getManifestFromReference(JarFile.java:416) at java.base/java.util.jar.JarFile.getManifest(JarFile.java:402) at jenkins.util.AntClassLoader.addPathFile(AntClassLoader.java:504) at jenkins.util.AntWithFindResourceClassLoader.addPathFiles(AntWithFindResourceClassLoader.java:35) at hudson.ClassicPluginStrategy.createClassLoader(ClassicPluginStrategy.java:317) at hudson.ClassicPluginStrategy.createPluginWrapper(ClassicPluginStrategy.java:258) at hudson.PluginManager$1$3$1.run(PluginManager.java:403) at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169) at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:296) at jenkins.model.Jenkins$5.runTask(Jenkins.java:1068) at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:214) at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:832)
[JENKINS-51871] Java 11 Docker Image: Invalid Manifest format when loading Git Client Plugin 2.7.2, JDK 11ea+18 is required
I don't know the cause. The git client plugin being used in your test might be git client plugin 2.7.x. That version of git client plugin intentionally bundled JGit 4.5.4 in order to retain Java 7 compatibility.
You might try git client plugin 3.0.0-beta3 to see if it shows the same failure mode. It bundles JGit 4.11.0 and requires Jenkins 2.60.3 or later.
Can you provide the command line you're using to start Jenkins with JDK 11?
I see in "end of the road for Java EE" and in Java JEP 320 that the java.xml.bind module is no longer available, but don't immediately see how to handle that in Jenkins.
markewaite I just dropped 3 libs into the exploded WAR in JENKINS_HOME/war/WEB-INF/lib , it was enough to get it running
I am working on the Run guidelines now. BTW, Git Client Plugin leads to failure of some other plugins in the default setup flow
Since the failure is happening during install, I'm confident you're using git client plugin 2.7.2. Use 3.0.0-beta3 to see if it gives better results. It is built with Java 8 and JGit 4.11.0. The older version is JDK 7 compatible and is built with JGit 4.5.4
If the git client plugin fails to load, the git plugin which critically depends on it will also fail to load. If the git plugin fails to load, pandemonium ensues.
Confirmed, Git Client (https://github.com/jenkinsci/git-client-plugin/releases/tag/git-client-3.0.0-beta3) installs well from Experimental UC.
What would be the release ETA? If it is not going to happen soon, I will update guidelines
Java 10 and 11 run guidelines BTW: https://github.com/jenkins-infra/jenkins.io/pull/1590
I am looking into the root cause to see what other plugins might be affected. A diff of the git-client MANIFEST.MF between the version shows only version number differences, so my guess is that this is a problem in one of the dependencies of git-client:2.7.2.
I was unable to reproduce this locally running the java11-support branch locally with Java build 11-ea+18. My best guess is that there was an error in a SHA (maybe a corrupted download?), but I would have expected that to be caught earlier in the installation process, so I'm not sure. oleg_nenashev are you still able to reproduce the issue?
dnusbaum yes, I am still able to reproduce it in Docker
1) Run docker run -p 8080:8080 -p 50000:50000 jenkins/jenkins-experimental:latest-jdk11
2) Select "Git plugin" in the installation wizard
https://github.com/jenkinsci/jenkins/pull/3505 will change the image tho. Maybe it makes sense to try again once it's merged
oleg_nenashev Ok, my local version is based on `jdk-11-ea+18`, but the docker images look like they are based on `jdk-11-ea+17`, so maybe that is related. I will investigate further.
dnusbaum jdk-11-ea+18 has not been pushed to Docker yet, so I cannot verify the theory.
According to http://jdk.java.net/11/release-notes the build just adds GoDaddy certificates so there should be no relation
Looks like the release notes are only notable changes. I looked through the history of Manifest.java, and saw this change in 11 build 17: https://bugs.openjdk.java.net/browse/JDK-8200530, which caused a regression which was fixed in 11 build 18: https://bugs.openjdk.java.net/browse/JDK-8204494. I will install build 17 locally to confirm that I can reproduce.
Confirmed locally as specific to JDK 11ea+17 (likely caused by JDK-8200530) and fixed in JDK 11ea+18 (likely fixed by JDK-8204494). There is nothing we need to do other than update our Docker images once the JDK 11ea+18 Docker image is available.
Thanks dnusbaum! I will reopen it and recategorize as a Docker image defect
It seems to be a Git-specific issue. Many other plugins install and work successfully