[JENKINS-52038] When using build step and a choice parameter plugin it accepts any value

Type: Bug
Resolution: Fixed
Priority: Minor
Component/s: pipeline-build-step-plugin
Labels:
None
Environment:
Jenkins 1.107.2-Rolling
pipeline-build-step 2.7 version

Similar Issues:
Powered by SuggestiMate

Show

When using build step and a choice parameter plugin it accepts any value. Also, it accepts parameters that are not defined.

Here we have an example that shows that behavior.

We need two pipeline jobs:

Main job:

stage ('UpstreamJob')\{ 
build job: 'DownstreamJob', parameters: [ 
string(name: 'ARTIFACT_NAME', value: "myArtifact_5.5.5.zip"), 
string(name: 'DEPLOY_PHASE', value: "Production"), 
string(name: 'DEPLOYMENT_COLOR', value: "purple"), 
string(name: 'SOMEEXTRAVAR', value: "Woohoo I can do whatever I want!") 
] 
}

And a Downstream Job:

properties([ 
parameters([ 
string( 
name: 'ARTIFACT_NAME', 
description: 'Name of the artifact to deploy', 
defaultValue: 'myArtifact_1.0.zip' 
), 
choice( 
choices: ["Development"].join("\n"), 
description: 'Only development is allowed!', 
name: 'DEPLOY_PHASE'), 
choice( 
choices: ["blue", "green"].join("\n"), 
description: 'Color of Blue/Green deployment option', 
name: 'DEPLOYMENT_COLOR') 
]) 
])

UserInput = "User Supplied Values:\n" 
params.each\{ 
k, v -> UserInput = UserInput + """ $\{k}\n $\{v}\n""" 
}

echo UserInput

stage ('DownstreamJob')\{ 

echo "The value of SOMEEXTRAVAR: $SOMEEXTRAVAR" 

}

When executing the main job the result is:

User Supplied Values: DEPLOYMENT_COLOR purple DEPLOY_PHASE Production SOMEEXTRAVAR Woohoo I can do whatever I want! ARTIFACT_NAME myArtifact_5.5.5.zip [Pipeline] stage [Pipeline] \{ (DownstreamJob) [Pipeline] } [Pipeline] // stage [Pipeline] End of Pipeline groovy.lang.MissingPropertyException: No such property: SOMEEXTRAVAR for class: groovy.lang.Binding at groovy.lang.Binding.getVariable(Binding.java:63) at

Here we see that the choice value accepts values that are not defined and also the "SOMEEXTRAVAR" that is not a parameter has accepted that value perhaps after executing that step the pipeline build failed telling that there is no valid value for that variable

links to

PR #23

Javier Raez created issue - 2018-06-19 14:04

jang hyemi (Inactive) made changes - 2018-06-22 00:45

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Andrew Bayer made changes - 2019-04-12 18:49

Assignee

New: Andrew Bayer [ abayer ]

Andrew Bayer made changes - 2019-04-12 18:49

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Andrew Bayer added a comment - 2019-04-12 18:50

PR up at https://github.com/jenkinsci/pipeline-build-step-plugin/pull/23

Andrew Bayer added a comment - 2019-04-12 18:50 PR up at https://github.com/jenkinsci/pipeline-build-step-plugin/pull/23

Andrew Bayer made changes - 2019-04-12 18:50

Remote Link

New: This issue links to "PR #23 (Web Link)" [ 22592 ]

Andrew Bayer added a comment - 2019-04-15 14:15

Releasing as Pipeline Input Step plugin 2.9.

Andrew Bayer added a comment - 2019-04-15 14:15 Releasing as Pipeline Input Step plugin 2.9.

Andrew Bayer made changes - 2019-04-15 14:15

Resolution		New: Fixed [ 1 ]
Status	Original: In Review [ 10005 ]	New: Resolved [ 5 ]

Nick Jones made changes - 2019-04-16 09:46

Description

Original: {{When using build step and a choice parameter plugin it accepts any value. Also, it accepts parameters that are not defined.}}

{{}}{{Here we have an example that shows that behavior.}}

We need two pipeline jobs:

Main job:

````

stage ('UpstreamJob')\{
build job: 'DownstreamJob', parameters: [
string(name: 'ARTIFACT_NAME', value: "myArtifact_5.5.5.zip"),
string(name: 'DEPLOY_PHASE', value: "Production"),
string(name: 'DEPLOYMENT_COLOR', value: "purple"),
string(name: 'SOMEEXTRAVAR', value: "Woohoo I can do whatever I want!")
]
}

```

And a DownstreamJob:

````

properties([
parameters([
string(
name: 'ARTIFACT_NAME',
description: 'Name of the artifact to deploy',
defaultValue: 'myArtifact_1.0.zip'
),
choice(
choices: ["Development"].join("\n"),
description: 'Only development is allowed!',
name: 'DEPLOY_PHASE'),
choice(
choices: ["blue", "green"].join("\n"),
description: 'Color of Blue/Green deployment option',
name: 'DEPLOYMENT_COLOR')
])
])

UserInput = "User Supplied Values:\n"
params.each\{
k, v -> UserInput = UserInput + """ $\{k}\n $\{v}\n"""
}

echo UserInput

stage ('DownstreamJob')\{

echo "The value of SOMEEXTRAVAR: $SOMEEXTRAVAR"

}

```

When executing the main job the result is:

````

{{User Supplied Values: DEPLOYMENT_COLOR purple DEPLOY_PHASE Production SOMEEXTRAVAR Woohoo I can do whatever I want! ARTIFACT_NAME myArtifact_5.5.5.zip [Pipeline] stage [Pipeline] \{ (DownstreamJob) [Pipeline] } [Pipeline] // stage [Pipeline] End of Pipeline groovy.lang.MissingPropertyException: No such property: SOMEEXTRAVAR for class: groovy.lang.Binding at groovy.lang.Binding.getVariable(Binding.java:63) at }}

{{```}}

{{Here we see that the choice value accepts values that are not defined and also the "SOMEEXTRAVAR" that is not a parameter has accepted that value perhaps after executing that step the pipeline build failed telling that there is no valid value for that variable}}

New: When using build step and a choice parameter plugin it accepts any value. Also, it accepts parameters that are not defined.

Here we have an example that shows that behavior.

We need two pipeline jobs:

Main job:

{code:java}
stage ('UpstreamJob')\{
build job: 'DownstreamJob', parameters: [
string(name: 'ARTIFACT_NAME', value: "myArtifact_5.5.5.zip"),
string(name: 'DEPLOY_PHASE', value: "Production"),
string(name: 'DEPLOYMENT_COLOR', value: "purple"),
string(name: 'SOMEEXTRAVAR', value: "Woohoo I can do whatever I want!")
]
}
{code}

And a Downstream Job:

{code:java}
properties([
parameters([
string(
name: 'ARTIFACT_NAME',
description: 'Name of the artifact to deploy',
defaultValue: 'myArtifact_1.0.zip'
),
choice(
choices: ["Development"].join("\n"),
description: 'Only development is allowed!',
name: 'DEPLOY_PHASE'),
choice(
choices: ["blue", "green"].join("\n"),
description: 'Color of Blue/Green deployment option',
name: 'DEPLOYMENT_COLOR')
])
])

UserInput = "User Supplied Values:\n"
params.each\{
k, v -> UserInput = UserInput + """ $\{k}\n $\{v}\n"""
}

echo UserInput

stage ('DownstreamJob')\{

echo "The value of SOMEEXTRAVAR: $SOMEEXTRAVAR"

}
{code}

When executing the main job the result is:

{noformat}
User Supplied Values: DEPLOYMENT_COLOR purple DEPLOY_PHASE Production SOMEEXTRAVAR Woohoo I can do whatever I want! ARTIFACT_NAME myArtifact_5.5.5.zip [Pipeline] stage [Pipeline] \{ (DownstreamJob) [Pipeline] } [Pipeline] // stage [Pipeline] End of Pipeline groovy.lang.MissingPropertyException: No such property: SOMEEXTRAVAR for class: groovy.lang.Binding at groovy.lang.Binding.getVariable(Binding.java:63) at
{noformat}

Here we see that the choice value accepts values that are not defined and also the "SOMEEXTRAVAR" that is not a parameter has accepted that value perhaps after executing that step the pipeline build failed telling that there is no valid value for that variable

Assignee:: Andrew Bayer

Reporter:: Javier Raez

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 2018-06-19 14:04

Updated:: 2019-04-16 09:46

Resolved:: 2019-04-15 14:15

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Andrew Bayer added a comment - 2019-04-12 18:50

Expand comment: Andrew Bayer added a comment - 2019-04-12 18:50

Collapse comment: Andrew Bayer added a comment - 2019-04-15 14:15

Expand comment: Andrew Bayer added a comment - 2019-04-15 14:15

People

Dates