Details
-
Improvement
-
Status: Resolved (View Workflow)
-
Major
-
Resolution: Done
-
None
Description
Summary
There are a lot of deprecated things in this test class. In an effort to help stop occasional test flakes in PCT, I'll fix some of that.
Details
- Update the calls to new CpsFlowDefinition, like the one shown here. CpsFlowDefinition is expecting a second argument, a boolean, and most of the calls to it in this test don't have it. I'll change the constructor calls to use the current one.
- Update much (but probably not all) of the sample pipeline code being used in this test, so that it has block-scoped stages. Without which, you'll see a lot of messages like this in your logs:
[Pipeline] { [Pipeline] stage (hey) Using the ‘stage’ step without a block argument is deprecated
I didn't update all the sample pipeline code. That tends to change the flow graph of a pipeline pretty significantly, and I was breaking a lot of the Assert tests that were looking for particular numbers. Maybe some other time.