Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52304

Make the plugin fully configurable via configuration-as-code

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      Artifact Manager S3 1.0

      Description

      Hello, to be honest, I'm not 100% sure if this issue can be solved on CasC side alone. It seems not. I'm filing it here hoping this will be more obvious to the developer(s) of the plugin.

      So, I was able to configure the blob store itself, but didn't find a way to make Jenkins' artifactManager use it.

      unclassified:   s3blobstoreconfig:     container: "${ARTIFACT_MANAGER_S3_BUCKET_NAME}"
          region: "us-east-1"
          prefix: "twiddling/"
      

      And this worked fine, for the artifactManager part, though, I tried many combinations to no avail for now. I think I'd need some way to cross-reference the s3blobstoreconfig above, but I do not think it is possible and if this is the right path. Likely not.

      Does not work:

       artifactManager:    artifactManagerFactories:      - JCloudsArtifactManagerFactory
      

      NOTE: I have a testing image available if anyone needs anything.

        Attachments

          Issue Links

            Activity

            batmat Baptiste Mathus created issue -
            batmat Baptiste Mathus made changes -
            Field Original Value New Value
            Description Hello, to be honest, I'm not 100% sure if this issue can be solved on CasC side alone. It seems not. I'm filing it here hoping this will be more obvious to the developer(s) of the plugin.

            So, I was able to configure the blob store itself, but didn't find a way to make Jenkins' {{artifactManager}} use it.

            {code:yaml}
            unclassified:
              s3blobstoreconfig:
                container: "${ARTIFACT_MANAGER_S3_BUCKET_NAME}"
                region: "us-east-1"
                prefix: "twiddling/"
            {code}

            And this worked fine, for the artifactManager part, though, I tried many combinations to no avail for now. I _think_ I'd need some way to cross-reference the s3blobstoreconfig above, but I do not think it is possible and if this is the right path. Likely not.

            Does not work:
            {code:yaml}
             artifactManager:
               artifactManagerFactories:
                 - JCloudsArtifactManagerFactory
            {code}

            h3. What
            Hello, to be honest, I'm not 100% sure if this issue can be solved on CasC side alone. It seems not. I'm filing it here hoping this will be more obvious to the developer(s) of the plugin.

            So, I was able to configure the blob store itself, but didn't find a way to make Jenkins' {{artifactManager}} use it.

            {code:yaml}
            unclassified:
              s3blobstoreconfig:
                container: "${ARTIFACT_MANAGER_S3_BUCKET_NAME}"
                region: "us-east-1"
                prefix: "twiddling/"
            {code}

            And this worked fine, for the artifactManager part, though, I tried many combinations to no avail for now. I _think_ I'd need some way to cross-reference the s3blobstoreconfig above, but I do not think it is possible and if this is the right path. Likely not.

            Does not work:
            {code:yaml}
             artifactManager:
               artifactManagerFactories:
                 - JCloudsArtifactManagerFactory
            {code}

            NOTE: I have a testing image available if anyone needs anything.
            oleg_nenashev Oleg Nenashev made changes -
            Labels essentials essentials-triggered essentials essentials-triggered jcasc-compatibility
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue relates to JENKINS-50571 [ JENKINS-50571 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal ARC-466 (Web Link)" [ 21146 ]
            Hide
            jglick Jesse Glick added a comment -

            S3BlobStoreConfig should have @Symbol("s3BlobStore") or similar to be pretty, and likewise JCloudsArtifactManagerFactory should have @Symbol("jclouds") to be pretty. Other than that, what you are missing is something to configure provider to refer to a S3BlobStore (which also ought to have @Symbol("s3")). IOW you should already be able to configure it, albeit using ugly symbols.

            Show
            jglick Jesse Glick added a comment - S3BlobStoreConfig should have @Symbol("s3BlobStore") or similar to be pretty, and likewise JCloudsArtifactManagerFactory should have @Symbol("jclouds") to be pretty. Other than that, what you are missing is something to configure provider to refer to a S3BlobStore (which also ought to have @Symbol("s3") ). IOW you should already be able to configure it, albeit using ugly symbols.
            batmat Baptiste Mathus made changes -
            Link This issue blocks JENKINS-50519 [ JENKINS-50519 ]
            Hide
            batmat Baptiste Mathus added a comment - - edited

            Added a PR showing what currently works, and what does not yet (https://github.com/jenkinsci/configuration-as-code-plugin/pull/347).

            Show
            batmat Baptiste Mathus added a comment - - edited Added a PR showing what currently works, and what does not yet ( https://github.com/jenkinsci/configuration-as-code-plugin/pull/347 ).
            batmat Baptiste Mathus made changes -
            Remote Link This issue links to "PR (Web Link)" [ 21165 ]
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "artifact-manager-s3 PR 72 (Web Link)" [ 21178 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "aws-global-configuration PR 4 (Web Link)" [ 21179 ]
            jglick Jesse Glick made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            jglick Jesse Glick made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-52581 [ JENKINS-52581 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "evergreen PR 144 (Web Link)" [ 21186 ]
            oleg_nenashev Oleg Nenashev made changes -
            Released As Artifact Manager S3 1.0
            batmat Baptiste Mathus made changes -
            Labels essentials essentials-triggered jcasc-compatibility essentials essentials-triggered evergreen jcasc-compatibility
            batmat Baptiste Mathus made changes -
            Labels essentials essentials-triggered evergreen jcasc-compatibility essentials essentials-triggered evergreen evergreen-triggered jcasc-compatibility
            batmat Baptiste Mathus made changes -
            Labels essentials essentials-triggered evergreen evergreen-triggered jcasc-compatibility evergreen evergreen-triggered jcasc-compatibility

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              batmat Baptiste Mathus
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: