Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52308

Modernize File Leak Detector

XMLWordPrintable

    • file-leak-detector-plugin 1.8, lib-file-leak-detector 1.15

      Currently FileLeak Detector Plugin uses ASM 6.0-BETA, but in JENKINS-40689 we discovered that ASM 6.2 is required to support Java 10 in Pipeline and other logic. It makes sense to update the detector and the plugin to use new ASM API

          [JENKINS-52308] Modernize File Leak Detector

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Epic Link New: JENKINS-40689 [ 177392 ]

          Oleg Nenashev added a comment -

          Actually it's just Nice 2 have, because the plugin uses the version from the core anyway: https://github.com/jenkinsci/file-leak-detector-plugin/blob/master/pom.xml#L33-L36

          Oleg Nenashev added a comment - Actually it's just Nice 2 have, because the plugin uses the version from the core anyway: https://github.com/jenkinsci/file-leak-detector-plugin/blob/master/pom.xml#L33-L36
          Oleg Nenashev made changes -
          Description Original: Currently FileLeak Detector Plugin uses ASM 6.0-BETA, but in JENKINS-40689 we discovered that ASM 6.2 is required to support Java 10 in Pipeline and other logic. It makes sense to update the detector and the plugin to use new ASM API New: Currently FileLeak Detector Plugin uses ASM 6.0-BETA, but in JENKINS-40689 we discovered that ASM 6.2 is required to support Java 10 in Pipeline and other logic. It makes sense to update the detector and the plugin to use new ASM API

          * https://github.com/jenkinsci/file-leak-detector-plugin/
          * https://github.com/kohsuke/file-leak-detector
          Oleg Nenashev made changes -
          Labels Original: java10 New: java10 newbie-friendly
          Oleg Nenashev made changes -
          Labels Original: java10 newbie-friendly New: java10 java11 newbie-friendly
          Baptiste Mathus made changes -
          Labels Original: java10 java11 newbie-friendly New: java10 java11 newbie-friendly triaged
          Duane Francis made changes -
          Assignee New: Duane Francis [ francoisd ]

          Duane Francis added a comment - - edited

          Which file-leak-detector do we want to update to? 

          Current version is 7.1 for ASM

          3 March 2019: ASM 7.1 (tag ASM_7_1)

          Do we still want to check for 6.2 for ASM?

          Thanks

           

           

          Duane Francis added a comment - - edited Which file-leak-detector do we want to update to?  Current version is 7.1 for ASM 3 March 2019: ASM 7.1 (tag ASM_7_1) Do we still want to check for 6.2 for ASM? Thanks    

          Oleg Nenashev added a comment -

          It would be better to keep the version aligned with Jenkins core. That version comes from https://github.com/kohsuke/package-renamed-asm/blob/asm6/pom.xml#L35 and now it is 6.2

          Updating to a newer version may make sense, but we will need to update ASM in the Jenkins core as well, I believe

           

          CC batmat mramonleon alecharp

           

          Oleg Nenashev added a comment - It would be better to keep the version aligned with Jenkins core. That version comes from  https://github.com/kohsuke/package-renamed-asm/blob/asm6/pom.xml#L35  and now it is 6.2 Updating to a newer version may make sense, but we will need to update ASM in the Jenkins core as well, I believe   CC batmat mramonleon alecharp  

            basil Basil Crow
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: