Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52990

Allow setting priority per category

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      It would be nice if there was a way to alter the priority for a warning by category.

      I'd like to treat certain warnings as high priority (e.g. "tautological const_cast") because they are indicative of problems with the codebase and have no false positives, while others (e.g. "suggest using a smart pointer here") I'd like to treat as low priority.

        Attachments

          Issue Links

            Activity

            simonrichter Simon Richter created issue -
            Hide
            drulli Ulli Hafner added a comment -

            Tools like PMD or CheckStyle define such priorities globally for all users. Would it make sense to define a global mapping table in the parser (which one are you using?)? Or do you think this is something that different teams would handle differently?

            Show
            drulli Ulli Hafner added a comment - Tools like PMD or CheckStyle define such priorities globally for all users. Would it make sense to define a global mapping table in the parser (which one are you using?)? Or do you think this is something that different teams would handle differently?
            Hide
            simonrichter Simon Richter added a comment -

            I'm using both gcc and MSBuild parsers for different projects.

            I think different teams would be using different settings here, as they may have different views on the severity of stylistic warnings.

            I think there is no need to make this parser specific. There is already a setting "Categories to ignore", this feature would add "High/Medium/Low Categories" and/or replace that by a mapping table where users can override default classifications with "High/Medium/Low/Ignore".

            It might also be useful to some people to have a similar mechanism for matches against file names or warning messages and/or combinations of these (e.g. demote certain warnings in third-party components without hiding them), but this would probably increase the complexity quite a bit.

            Show
            simonrichter Simon Richter added a comment - I'm using both gcc and MSBuild parsers for different projects. I think different teams would be using different settings here, as they may have different views on the severity of stylistic warnings. I think there is no need to make this parser specific. There is already a setting "Categories to ignore", this feature would add "High/Medium/Low Categories" and/or replace that by a mapping table where users can override default classifications with "High/Medium/Low/Ignore". It might also be useful to some people to have a similar mechanism for matches against file names or warning messages and/or combinations of these (e.g. demote certain warnings in third-party components without hiding them), but this would probably increase the complexity quite a bit.
            Hide
            drulli Ulli Hafner added a comment -

            I see.

            I wonder if it would make sense to introduce a kind of priority mapping file (local in the workspace) that would map a given warning property to a priority. This would be more powerful and should be simpler to implement than a Ui.

            Show
            drulli Ulli Hafner added a comment - I see. I wonder if it would make sense to introduce a kind of priority mapping file (local in the workspace) that would map a given warning property to a priority. This would be more powerful and should be simpler to implement than a Ui.
            drulli Ulli Hafner made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-52477 [ JENKINS-52477 ]
            drulli Ulli Hafner made changes -
            Link This issue is related to JENKINS-52477 [ JENKINS-52477 ]
            drulli Ulli Hafner made changes -
            Link This issue is related to JENKINS-52551 [ JENKINS-52551 ]
            Hide
            simonrichter Simon Richter added a comment -

            Three disadvantages of a separate file:

            • doesn't allow different project instances in Jenkins to have different settings (e.g. a "janitor" team would be interested in different things than the people working on new features
            • doesn't allow applying different settings to old versions
            • the file would have to contain mappings for multiple compilers (e.g. we build with gcc, clang and Visual Studio), so we'd need a mechanism to avoid conflicts.

            At least for me, it would also be annoying to use, as we don't have CI infrastructure inside the project, so I'd have to maintain a separate branch that gets merged for every build.

            Show
            simonrichter Simon Richter added a comment - Three disadvantages of a separate file: doesn't allow different project instances in Jenkins to have different settings (e.g. a "janitor" team would be interested in different things than the people working on new features doesn't allow applying different settings to old versions the file would have to contain mappings for multiple compilers (e.g. we build with gcc, clang and Visual Studio), so we'd need a mechanism to avoid conflicts. At least for me, it would also be annoying to use, as we don't have CI infrastructure inside the project, so I'd have to maintain a separate branch that gets merged for every build.
            drulli Ulli Hafner made changes -
            Component/s warnings-ng-plugin [ 24526 ]
            Component/s warnings-plugin [ 15513 ]
            drulli Ulli Hafner made changes -
            Link This issue relates to JENKINS-55571 [ JENKINS-55571 ]
            drulli Ulli Hafner made changes -
            Rank Ranked higher
            drulli Ulli Hafner made changes -
            Rank Ranked higher
            drulli Ulli Hafner made changes -
            Link This issue is duplicated by JENKINS-64354 [ JENKINS-64354 ]

              People

              Assignee:
              drulli Ulli Hafner
              Reporter:
              simonrichter Simon Richter
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated: