Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-53285

Update plugins used in Evergreen to remove "Created .../WEB-INF/lib/classes.jar; update plugin to a version created with a newer harness" messages

    XMLWordPrintable

Details

    • Evergreen - Milestone 1

    Description

      Issue

      We get a bunch of WARNINGs back to Sentry backend for Evergreen.

      Typical message:

      Created /evergreen/jenkins/var/plugins/authentication-tokens/WEB-INF/lib/classes.jar; update plugin to a version created with a newer harness
      // or
      Created /evergreen/jenkins/var/plugins/conditional-buildstep/WEB-INF/lib/classes.jar; update plugin to a version created with a newer harness
      ...
      

      Expected

      We should probably make a pass to either update to last versions that might already be fixed, or propose patches around to have this cleaned up.

      list of plugins suffering from this visible through Sentry

      • authentication-tokens
      • conditional-buildstep
      • icon-shim
      • javadoc
      • jsch
      • mapdb-api
      • maven-plugin
      • node-iterator-api
      • run-condition

      Attachments

        Issue Links

          Activity

            imod thanks a bunch!

            batmat Baptiste Mathus added a comment - imod thanks a bunch!

            batmat ok, this now seem not to be needed anymore, but anyway I just released run-condition:1.2

            imod Dominik Bartholdi added a comment - batmat ok, this now seem not to be needed anymore, but anyway I just released run-condition:1.2

            OK, done yesterday through https://github.com/jenkins-infra/evergreen/pull/205/files.
            Do not see run-condition there BTW, possibly someone just removed it earlier. Spawning a brand new instance just now didn't get run-condition installed at least.

            But https://github.com/jenkins-infra/evergreen/pull/205/files didn't percolate yet to being consumed by the fleet. Once done, I'll have another look, I think we will just want to have another look at Sentry in a few days to see if/which messages for this still come in (if any).

            Going to mark this as resolved.

            batmat Baptiste Mathus added a comment - OK, done yesterday through https://github.com/jenkins-infra/evergreen/pull/205/files . Do not see run-condition there BTW, possibly someone just removed it earlier. Spawning a brand new instance just now didn't get run-condition installed at least. But https://github.com/jenkins-infra/evergreen/pull/205/files didn't percolate yet to being consumed by the fleet. Once done, I'll have another look, I think we will just want to have another look at Sentry in a few days to see if/which messages for this still come in (if any). Going to mark this as resolved.
            jglick Jesse Glick added a comment -

            Check to see if you actually need run-condition + conditional-buildstep + parameterized-trigger. As noted elsewhere, these are not useful for Pipeline workflows. If there is a hard dependency chain from the latest version of some plugin you are bundling, that is probably fixable.

            jglick Jesse Glick added a comment - Check to see if you actually need run-condition + conditional-buildstep + parameterized-trigger . As noted elsewhere, these are not useful for Pipeline workflows. If there is a hard dependency chain from the latest version of some plugin you are bundling, that is probably fixable.

            OK, so I filed a PR to update to latest. I expect we should get much less warnings for this in the next days once it percolates through the fleet instances.

            The only one I could not update is run-condition, but this one is already also fixed in its master branch \o/. We just need a release out. But currently, nobody is listed to be allowed to https://github.com/batmat/repository-permissions-updater/blob/master/permissions/plugin-run-condition.yml though imod was maintaining it in the past IIUC.

            batmat Baptiste Mathus added a comment - OK, so I filed a PR to update to latest. I expect we should get much less warnings for this in the next days once it percolates through the fleet instances. The only one I could not update is run-condition , but this one is already also fixed in its master branch \o/. We just need a release out. But currently, nobody is listed to be allowed to https://github.com/batmat/repository-permissions-updater/blob/master/permissions/plugin-run-condition.yml though imod was maintaining it in the past IIUC.
            jglick Jesse Glick added a comment -

            Right. The “code fixes” should in general simply be using a newer parent POM, to pick up a newer maven-hpi-plugin. I think we would expect that all plugins bundled in Evergreen ought to be using recent parents, for various reasons.

            jglick Jesse Glick added a comment - Right. The “code fixes” should in general simply be using a newer parent POM, to pick up a newer maven-hpi-plugin . I think we would expect that all plugins bundled in Evergreen ought to be using recent parents, for various reasons.

            I'm doing a quick pass to update at least things that are already fixed like this case of the maven-plugin (even if we filter its descriptors out, but well ). For things that will need code fixing, I think we'll plan differently and see how/when/if to do it.

            batmat Baptiste Mathus added a comment - I'm doing a quick pass to update at least things that are already fixed like this case of the maven-plugin (even if we filter its descriptors out, but well ). For things that will need code fixing, I think we'll plan differently and see how/when/if to do it.
            jglick Jesse Glick added a comment -

            The maven-plugin version currently being bundled is close to five years old, FYI. Need to fix this or the project will get nicknamed Deciduous!

            jglick Jesse Glick added a comment - The maven-plugin version currently being bundled is close to five years old, FYI. Need to fix this or the project will get nicknamed Deciduous!

            People

              batmat Baptiste Mathus
              batmat Baptiste Mathus
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: