Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5332

Hudson does not put correct client name in P4CLIENT env variable on build nodes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: p4-plugin
    • Labels:
      None
    • Environment:
      Win32 (should be any os)
    • Similar Issues:

      Description

      On builds that are distributed to nodes the Perforce plugin puts the master's client spec name in the P4CLIENT (was PCLIENT) environment variable instead of the node's clientspec name. I believe this is because the buildEnvVars function is called before getPerforceWorkspace.

        Attachments

          Activity

          Descending order - Click to sort in ascending order
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : rpetti
          Path:
          trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java
          https://hudson.dev.java.net/source/browse/hudson/trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java?view=diff&rev=26139&p1=trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java&p2=trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java&r1=26138&r2=26139
          http://jenkins-ci.org/commit/26139
          Log:
          [FIXED JENKINS-5332] refactored P4CLIENT environment variable to pass in modified client name when building on remote nodes

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : rpetti Path: trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java https://hudson.dev.java.net/source/browse/hudson/trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java?view=diff&rev=26139&p1=trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java&p2=trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java&r1=26138&r2=26139 http://jenkins-ci.org/commit/26139 Log: [FIXED JENKINS-5332] refactored P4CLIENT environment variable to pass in modified client name when building on remote nodes
          Hide
          Permalink
          rpetti Rob Petti added a comment -

          buildEnvVars is passing in the base clientname instead of the modified one. I'm in the process of testing my changes, so a fix will be on it's way to trunk shortly.

          Show
          rpetti Rob Petti added a comment - buildEnvVars is passing in the base clientname instead of the modified one. I'm in the process of testing my changes, so a fix will be on it's way to trunk shortly.

            People

            Assignee:
            rpetti Rob Petti
            Reporter:
            cbieneman cbieneman
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: