Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5332

Hudson does not put correct client name in P4CLIENT env variable on build nodes

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • p4-plugin
    • None
    • Win32 (should be any os)

    Description

      On builds that are distributed to nodes the Perforce plugin puts the master's client spec name in the P4CLIENT (was PCLIENT) environment variable instead of the node's clientspec name. I believe this is because the buildEnvVars function is called before getPerforceWorkspace.

      Attachments

        Activity

          Code changed in hudson
          User: : rpetti
          Path:
          trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java
          https://hudson.dev.java.net/source/browse/hudson/trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java?view=diff&rev=26139&p1=trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java&p2=trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java&r1=26138&r2=26139
          http://jenkins-ci.org/commit/26139
          Log:
          [FIXED JENKINS-5332] refactored P4CLIENT environment variable to pass in modified client name when building on remote nodes

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : rpetti Path: trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java https://hudson.dev.java.net/source/browse/hudson/trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java?view=diff&rev=26139&p1=trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java&p2=trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java&r1=26138&r2=26139 http://jenkins-ci.org/commit/26139 Log: [FIXED JENKINS-5332] refactored P4CLIENT environment variable to pass in modified client name when building on remote nodes
          rpetti Rob Petti added a comment -

          buildEnvVars is passing in the base clientname instead of the modified one. I'm in the process of testing my changes, so a fix will be on it's way to trunk shortly.

          rpetti Rob Petti added a comment - buildEnvVars is passing in the base clientname instead of the modified one. I'm in the process of testing my changes, so a fix will be on it's way to trunk shortly.

          People

            rpetti Rob Petti
            cbieneman cbieneman
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: