Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-53720

JDK11 Build Flow: FindBugs fails with RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE in some classes

XMLWordPrintable

    • 2.272

      It seems FindBugs does not 100% support Java 11 code generation.  RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE is displayed randomly for the code which is okay in JDK8.

      [INFO] --- findbugs-maven-plugin:3.0.5:check (findbugs) @ cli --- [INFO] BugInstance size is 3 [INFO] Error size is 0 [INFO] Total bugs: 3 [INFO] Nullcheck of channel at line 112 of value previously dereferenced in hudson.cli.SSHCLI.sshConnection(String, String, List, PrivateKeyProvider, boolean) [hudson.cli.SSHCLI, hudson.cli.SSHCLI] At SSHCLI.java:[line 112]Redundant null check at SSHCLI.java:[line 127] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [INFO] Nullcheck of client at line 99 of value previously dereferenced in hudson.cli.SSHCLI.sshConnection(String, String, List, PrivateKeyProvider, boolean) [hudson.cli.SSHCLI, hudson.cli.SSHCLI] At SSHCLI.java:[line 99]Redundant null check at SSHCLI.java:[line 131] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [INFO] Nullcheck of session at line 109 of value previously dereferenced in hudson.cli.SSHCLI.sshConnection(String, String, List, PrivateKeyProvider, boolean) [hudson.cli.SSHCLI, hudson.cli.SSHCLI] At SSHCLI.java:[line 109]Redundant null check at SSHCLI.java:[line 128] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [INFO]

          [JENKINS-53720] JDK11 Build Flow: FindBugs fails with RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE in some classes

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Epic Link New: JENKINS-40689 [ 177392 ]
          Oleg Nenashev made changes -
          Summary Original: JDK11 Build Flow: FindBugs fails with RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE on some classes New: JDK11 Build Flow: FindBugs fails with RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE in some classes

          Oleg Nenashev added a comment -

          I suppressed this exception for now in the java11-support branch

          Oleg Nenashev added a comment - I suppressed this exception for now in the java11-support branch
          Oleg Nenashev made changes -
          Labels New: java11

          Oleg Nenashev added a comment -

          The approach is to update to SpotBugs AFAICT

          Oleg Nenashev added a comment - The approach is to update to SpotBugs AFAICT
          Oleg Nenashev made changes -
          Labels Original: java11 New: java11 java11-devtools-compatibility
          Baptiste Mathus made changes -
          Labels Original: java11 java11-devtools-compatibility New: java11 java11-devtools-compatibility triaged

          Dont Use added a comment -

          ps, upgraded blueocean (in branch) to spotbugs, it has the same issue. JDK11 produces different bytecode

           

          https://github.com/spotbugs/spotbugs/issues/756

          Dont Use added a comment - ps, upgraded blueocean (in branch) to spotbugs, it has the same issue. JDK11 produces different bytecode   https://github.com/spotbugs/spotbugs/issues/756

          Ivan Fernandez Calvo added a comment - - edited

          this starts happening on the ssh-slaves-plugin today it uses SpodtBugs

          Ivan Fernandez Calvo added a comment - - edited this starts happening on the ssh-slaves-plugin today it uses SpodtBugs

            stefan_spieker Stefan Spieker
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: