• Type: Bug
• Resolution: Fixed
• Priority: Major
• Component/s: evergreen
• Labels:

  • technical-debt

[JENKINS-54119] ESlint rules are not applied on the client

Baptiste Mathus created issue - 2018-10-17 08:55

Baptiste Mathus made changes - 2018-10-17 08:56

Assignee

Original: R. Tyler Croy [ rtyler ]

Baptiste Mathus made changes - 2018-10-17 08:57

Description

Original: h3. Problem statement Since the typescript migration on the evergree-client, we still apply ESLint, but it's a no-op. (I suppose it's looking for .js, and there's none anymore). h3. Expected behavior ESLint should either be ditched on the client side, or enabled through some intermediate tooling (there are apparently a few initiatives around this like https://github.com/eslint/typescript-eslint-parser or even https://palantir.github.io/tslint/)

New: h3. Problem statement Since the typescript migration on the evergree-client, we still apply ESLint, but it's a no-op. (I suppose it's looking for .js, and there's none anymore). h3. Expected behavior ESLint should either be ditched on the client side, or enabled through some intermediate tooling (there are apparently a few initiatives around this like https://github.com/eslint/typescript-eslint-parser or even https://palantir.github.io/tslint/) I think this issue is more than trivially important since ESLint, and {{make lint}} for our case, gives a false sense of consistency preservation, when actually now ESLint is basically ignored for the client side.

R. Tyler Croy made changes - 2019-03-09 20:11

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

R. Tyler Croy made changes - 2019-03-09 20:11

Assignee

New: R. Tyler Croy [ rtyler ]

Osaid made changes - 2024-08-11 01:48

Resolution		New: Fixed [ 1 ]
Status	Original: In Progress [ 3 ]	New: Closed [ 6 ]