Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54325

Support multiple SimplePageDecorators for login and signup page footers

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None
    • 2.156

      In login.jelly, this uses SimplePageDecorator instead of the typical PageDecorator used on most other pages. The latter decorator supports registering multiple instances so that they can all be included in various pages. The former, however, only uses the first instance found. By doing this, plugins cannot override the default login page decorations without needlessly copying code from Jenkins Core to emulate it.

      What I'd like is for the login page to list out all registered decorators for the footer in order rather than just the first one.

      This also applies to the signup.jelly page.

          [JENKINS-54325] Support multiple SimplePageDecorators for login and signup page footers

          Matt Sicker created issue -
          Matt Sicker made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Matt Sicker made changes -
          Assignee New: Matt Sicker [ jvz ]
          Matt Sicker made changes -
          Remote Link New: This issue links to "PR-3710 (Web Link)" [ 21966 ]
          Matt Sicker made changes -
          Summary Original: Support multiple SimplePageDecorators for login page New: Support multiple SimplePageDecorators for login and signup page
          Matt Sicker made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Matt Sicker made changes -
          Description Original: In {{login.jelly}}, this uses {{SimplePageDecorator}} instead of the typical {{PageDecorator}} used on most other pages. The latter decorator supports registering multiple instances so that they can all be included in various pages. The former, however, only uses the first instance found. By doing this, plugins cannot override the default login page decorations without needlessly copying code from Jenkins Core to emulate it.

          What I'd like is for the login page to list out all registered decorators in order rather than just the first one.
          New: In {{login.jelly}}, this uses {{SimplePageDecorator}} instead of the typical {{PageDecorator}} used on most other pages. The latter decorator supports registering multiple instances so that they can all be included in various pages. The former, however, only uses the first instance found. By doing this, plugins cannot override the default login page decorations without needlessly copying code from Jenkins Core to emulate it.

          What I'd like is for the login page to list out all registered decorators in order rather than just the first one.

          This also applies to the {{signup.jelly}} page.
          Matt Sicker made changes -
          Summary Original: Support multiple SimplePageDecorators for login and signup page New: Support multiple SimplePageDecorators for login and signup page footers
          Matt Sicker made changes -
          Description Original: In {{login.jelly}}, this uses {{SimplePageDecorator}} instead of the typical {{PageDecorator}} used on most other pages. The latter decorator supports registering multiple instances so that they can all be included in various pages. The former, however, only uses the first instance found. By doing this, plugins cannot override the default login page decorations without needlessly copying code from Jenkins Core to emulate it.

          What I'd like is for the login page to list out all registered decorators in order rather than just the first one.

          This also applies to the {{signup.jelly}} page.
          New: In {{login.jelly}}, this uses {{SimplePageDecorator}} instead of the typical {{PageDecorator}} used on most other pages. The latter decorator supports registering multiple instances so that they can all be included in various pages. The former, however, only uses the first instance found. By doing this, plugins cannot override the default login page decorations without needlessly copying code from Jenkins Core to emulate it.

          What I'd like is for the login page to list out all registered decorators for the footer in order rather than just the first one.

          This also applies to the {{signup.jelly}} page.
          Wadeck Follonier made changes -
          Remote Link New: This issue links to "PR-3721 (supersedes 3710) (Web Link)" [ 22056 ]

            jvz Matt Sicker
            jvz Matt Sicker
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: