Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54545

Promisify the plugin deletion

    XMLWordPrintable

    Details

    • Similar Issues:
    • Sprint:
      Evergreen - Milestone 2

      Description

      In the storage.ts class, our code to remove plugins (exploded directories and files) is using old-school unlink and remove with callbacks and the likes.

      We should "promisify" it to make it more readable and consistent with the rest of the codebase using Promises.

      See:

      Main pointers about NodeJS's util.promisify:

        Attachments

          Issue Links

            Activity

            batmat Baptiste Mathus created issue -
            batmat Baptiste Mathus made changes -
            Field Original Value New Value
            Labels evergreen technical-debt evergreen newbie-friendly technical-debt
            batmat Baptiste Mathus made changes -
            Description In the storage.ts class, our code to remove plugins (exploded directories and files) is using old-school {{unlink}} and {{remove}} with callbacks and the likes.

            We should "promisify" it to make it more readable and consistent with the rest of the codebase using Promises.

            See:
            * http://2ality.com/2017/05/util-promisify.html
            * http://2ality.com/2017/05/util-promisify.html
            In the storage.ts class, our code to remove plugins (exploded directories and files) is using old-school {{unlink}} and {{remove}} with callbacks and the likes.

            We should "promisify" it to make it more readable and consistent with the rest of the codebase using Promises.

            See:
            * the class to modify https://github.com/jenkins-infra/evergreen/blob/master/distribution/client/src/lib/storage.ts

            Main pointers about NodeJS's {{util.promisify}}:
            * http://2ality.com/2017/05/util-promisify.html
            * http://2ality.com/2017/05/util-promisify.html
            batmat Baptiste Mathus made changes -
            Link This issue blocks JENKINS-54207 [ JENKINS-54207 ]
            Hide
            jennyfive Jen Lijó added a comment - - edited

            Hi Baptiste Mathus! I would like to give a try to this particular one. I have a year of experience developing in Java / Node and have roughly used Jenkins to run e2e tests, I'd like to get more familiar with the whole Jenkins ecosystem, so I thought contributing would be a good idea  Is Evergreen a good point to start for a beginner? Cheers!

            Show
            jennyfive Jen Lijó added a comment - - edited Hi Baptiste Mathus ! I would like to give a try to this particular one. I have a year of experience developing in Java / Node and have roughly used Jenkins to run e2e tests, I'd like to get more familiar with the whole Jenkins ecosystem, so I thought contributing would be a good idea  Is Evergreen a good point to start for a beginner? Cheers!
            jennyfive Jen Lijó made changes -
            Assignee Jen Varela Lijó [ jennyfive ]
            jennyfive Jen Lijó made changes -
            Assignee Jen Varela Lijó [ jennyfive ] Baptiste Mathus [ batmat ]
            batmat Baptiste Mathus made changes -
            Assignee Baptiste Mathus [ batmat ]
            jennyfive Jen Lijó made changes -
            Assignee Jen Varela Lijó [ jennyfive ]
            jennyfive Jen Lijó made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            batmat Baptiste Mathus made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            batmat Baptiste Mathus made changes -
            Remote Link This issue links to "PR (Web Link)" [ 22085 ]
            Hide
            batmat Baptiste Mathus added a comment -

            Merged a few minutes ago \o/ Thanks Jen

            Show
            batmat Baptiste Mathus added a comment - Merged a few minutes ago \o/ Thanks Jen
            batmat Baptiste Mathus made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]

              People

              Assignee:
              jennyfive Jen Lijó
              Reporter:
              batmat Baptiste Mathus
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: