-
Task
-
Resolution: Fixed
-
Minor
-
None
-
-
Evergreen - Milestone 2
Problem statement
We enabled some time ago the fact that reviews were required.
In the go, we also enabled the fact that the branch *must* be up-to-date.
This makes sense in general, but is mostly a waste of time in our time, given we use the merge strategy, i.e. Jenkins will first merge the PR against master, then build it (showing up as pr-merge on the PR status check).
I assume this GitHub settings makes sense for other CI systems or when Jenkins is only configured to build the so-called pr-head.
Expected
We should only require reviews.
We can allow not being up to date with master branch given we build pr-merge.
to clarify, we need to uncheck the bolded line:
[JENKINS-54755] Disable "Require branches to be up to date before merging" on Evergreen repo
| Sprint | New: Evergreen - Milestone 2 [ 516 ] |
| Attachment | New: to be unchecked.png [ 45242 ] |
| Description |
Original:
h3. Problem statement We enabled some time ago the fact that reviews were required. In the go, we also enabled the fact that the branch **must** be up-to-date. This makes sense in general, but is mostly a waste of time in our time, given we use the merge strategy, i.e. Jenkins will first merge the PR against master, then build it (showing up as {{pr-merge}} on the PR status check). I assume this GitHub settings makes sense for other CI systems or when Jenkins is only configured to build the so-called {{pr-head}}. h3. Expected We should only require reviews. We can allow not being up to date with master branch given we build {{pr-merge}}. |
New:
h3. Problem statement We enabled some time ago the fact that reviews were required. In the go, we also enabled the fact that the branch **must** be up-to-date. This makes sense in general, but is mostly a waste of time in our time, given we use the merge strategy, i.e. Jenkins will first merge the PR against master, then build it (showing up as {{pr-merge}} on the PR status check). I assume this GitHub settings makes sense for other CI systems or when Jenkins is only configured to build the so-called {{pr-head}}. h3. Expected We should only require reviews. We can allow not being up to date with master branch given we build {{pr-merge}}. to clarify, we need to uncheck the bolded line: !to be unchecked.png! |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Attachment | New: updated new configuration.png [ 45246 ] |
| Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: In Review [ 10005 ] | New: Resolved [ 5 ] |
I will proceed about this later today or tomorrow I think. Cc rtyler in case you think this should be preserved for a good reason and you possibly actually configured it this way on purpose.
Thanks