Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54992

Terrifying message makes me think Jenkins will delete my github repo

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When you go to delete a multibranch folder that is using Github as a branch source - you will see a message "delete repository". 

      This is usually alarming as the access token used often has permissions to actually do this, but this is not the intent. 

       

      This is due to the Pronoun for GithubSCMSource being "Repository". 

      see https://github.com/jenkinsci/github-branch-source-plugin/blob/github-branch-source-2.4.1/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L544

      and the wording: https://github.com/jenkinsci/github-branch-source-plugin/blob/github-branch-source-2.4.1/src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties#L40

       

      This is then used in https://github.com/jenkinsci/cloudbees-folder-plugin/blob/cloudbees-folder-6.7/src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/tasks-new.properties

       

      which ends up with the scary looking: 

       

        Attachments

          Issue Links

          is caused by

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-38987 SCMHead/SCMSource/SCMNavigator need getPronoun() to assist contextual naming

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link branch-api PR-150

            Activity

            Ascending order - Click to sort in descending order
            michaelneale Michael Neale created issue -
            michaelneale Michael Neale made changes -
            Field Original Value New Value
            Component/s github-branch-source-plugin [ 20858 ]
            bitwiseman Liam Newman made changes -
            Attachment Screen Shot 2019-04-11 at 12.03.39 PM.png [ 46698 ]
            bitwiseman Liam Newman made changes -
            Link This issue is caused by JENKINS-38987 [ JENKINS-38987 ]
            bitwiseman Liam Newman made changes -
            Attachment Screen Shot 2019-04-11 at 12.45.33 PM.png [ 46699 ]
            bitwiseman Liam Newman made changes -
            Remote Link This issue links to "PR-194 (Web Link)" [ 22589 ]
            bitwiseman Liam Newman made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            bitwiseman Liam Newman made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            bitwiseman Liam Newman made changes -
            Remote Link This issue links to "branch-api PR-150 (Web Link)" [ 22710 ]
            bitwiseman Liam Newman made changes -
            Remote Link This issue links to "PR-194 (Web Link)" [ 22589 ]
            bitwiseman Liam Newman made changes -
            Component/s branch-api-plugin [ 18621 ]
            Component/s cloudbees-folder-plugin [ 18137 ]
            Component/s github-branch-source-plugin [ 20858 ]
            bitwiseman Liam Newman made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]

              People

              Assignee:
              fcojfernandez Francisco Fernández
              Reporter:
              michaelneale Michael Neale
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: