Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55150

[jenkins-dev] jenkins-dev:run no longer has hot reload after 2.152

XMLWordPrintable

      Previously, when I ran mvn jenkins-dev:run the instance was running and the Jelly view (and re-compiled classes) were reloaded automatically.

      Since the 2.152 and the PR#3758, the things changed. The documentation cannot be used any longer.

      On 2.152+:

      • mvn jenkins-dev:run starts the instance but the hot reload feature does not work, even after pressing enter (was not required before). At least the jelly views are the ones from src.
      • mvn jenkins-dev:run -f war starts the instance but with the jelly views packaged in the war during a previous mvn clean install -DskipTests. No hot reload.

      After the migration, the mvn jenkins-dev:run is no longer working for 2.151- instances, the log hangs at "Started Jetty Server" forever. I am forced to run with -f war now in order to make it working.

      Request: please re-enable the hot reload feature.

      Ping oleg_nenashev and olamy for their Jetty knowledge.

       

      Acceptance criteria

      • understand the reason this was originally patched
      • fix the issue...

          [JENKINS-55150] [jenkins-dev] jenkins-dev:run no longer has hot reload after 2.152

          Wadeck Follonier created issue -
          Wadeck Follonier made changes -
          Description Original: Previously, when I ran {{mvn jenkins-dev:run}} the instance was running and the Jelly view (and re-compiled classes) were reloaded automatically.

          Since the {{2.152}} and the [PR#3758|https://github.com/jenkinsci/jenkins/pull/3758], the things changed. The [documentation|https://wiki.jenkins.io/display/JENKINS/Building+Jenkins#BuildingJenkins-DebuggingJenkins] cannot be used any longer.

          On 2.152+:
          - {{mvn jenkins-dev:run}} starts the instance but the hot reload feature does not work, even after pressing enter (was not required before). At least the jelly views are the ones from {{src}}.
          - {{mvn jenkins-dev:run -f war}} starts the instance but with the jelly views packaged in the war during a previous {{mvn clean install -DskipTests}}. No hot reload.

          After the migration, the {{mvn jenkins-dev:run}} is no longer working for 2.151- instances, the log hangs at "Started Jetty Server" forever. I am forced to run with {{-f war}} now in order to make it working.

          Request: please re-enable the hot reload feature.

          Ping [~oleg_nenashev] and [~olamy] for their Jelly knowledge.           		New: Previously, when I ran {{mvn jenkins-dev:run}} the instance was running and the Jelly view (and re-compiled classes) were reloaded automatically.

          Since the {{2.152}} and the [PR#3758|https://github.com/jenkinsci/jenkins/pull/3758], the things changed. The [documentation|https://wiki.jenkins.io/display/JENKINS/Building+Jenkins#BuildingJenkins-DebuggingJenkins] cannot be used any longer.

          On 2.152+:
          - {{mvn jenkins-dev:run}} starts the instance but the hot reload feature does not work, even after pressing enter (was not required before). At least the jelly views are the ones from {{src}}.
          - {{mvn jenkins-dev:run -f war}} starts the instance but with the jelly views packaged in the war during a previous {{mvn clean install -DskipTests}}. No hot reload.

          After the migration, the {{mvn jenkins-dev:run}} is no longer working for 2.151- instances, the log hangs at "Started Jetty Server" forever. I am forced to run with {{-f war}} now in order to make it working.

          Request: please re-enable the hot reload feature.

          Ping [~oleg_nenashev] and [~olamy] for their Jetty knowledge.
          Daniel Beck made changes -
          Priority Original: Minor [ 4 ] New: Critical [ 2 ]

          Oleg Nenashev added a comment -

          I assume it is related to Java 11 patches in JENKINS-54599.

          It was working for me, but I did not check the auto-reload of resources

          Oleg Nenashev added a comment - I assume it is related to Java 11 patches in JENKINS-54599 . It was working for me, but I did not check the auto-reload of resources
          Oleg Nenashev made changes -
          Link New: This issue relates to JENKINS-54599 [ JENKINS-54599 ]
          Oleg Nenashev made changes -
          Labels Original: regression New: DEVTOOLS regression

          Oleg Nenashev added a comment - - edited

          https://github.com/jenkinsci/maven-hudson-dev-plugin/pull/9 is a "root cause". Our plugin is a copy-paste of the Jetty dev plugin. Apparently it had some custom patches which I missed

           

          Oleg Nenashev added a comment - - edited https://github.com/jenkinsci/maven-hudson-dev-plugin/pull/9  is a "root cause". Our plugin is a copy-paste of the Jetty dev plugin. Apparently it had some custom patches which I missed  
          Isa Vilacides made changes -
          Labels Original: DEVTOOLS regression New: DEVTOOLS java11 java11-compatibility regression
          Adrien Lecharpentier made changes -
          Labels Original: DEVTOOLS java11 java11-compatibility regression New: DEVTOOLS java11 java11-compatibility regression triaged

          Baptiste Mathus added a comment -

          Maybe we should consider using at some point the upstream plugin, instead of using a fork?

           

           

          Baptiste Mathus added a comment - Maybe we should consider using at some point the upstream plugin, instead of using a fork?    

            Unassigned Unassigned
            wfollonier Wadeck Follonier
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: