Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55205

Review findbugs error with some OS+JDK

XMLWordPrintable

    • saml-1.1.2

      After this PR findbugs claim for some attention

      [INFO] org.jenkinsci.plugins.saml.BundleKeyStore.saveKeyStore(File, KeyStore, String) may fail to clean up java.io.OutputStream [org.jenkinsci.plugins.saml.BundleKeyStore, org.jenkinsci.plugins.saml.BundleKeyStore, org.jenkinsci.plugins.saml.BundleKeyStore, org.jenkinsci.plugins.saml.BundleKeyStore, org.jenkinsci.plugins.saml.BundleKeyStore] Obligation to clean up resource created at BundleKeyStore.java:[line 184] is not dischargedPath continues at BundleKeyStore.java:[line 186]Path continues at BundleKeyStore.java:[line 188]Path continues at BundleKeyStore.java:[line 189]Path continues at BundleKeyStore.java:[line 190] OBL_UNSATISFIED_OBLIGATION

[INFO] The field org.jenkinsci.plugins.saml.SamlAuthenticationToken.session is transient but isn't set by deserialization [org.jenkinsci.plugins.saml.SamlAuthenticationToken] In SamlAuthenticationToken.java SE_TRANSIENT_FIELD_NOT_RESTORED

[INFO] Nullcheck of in at line 30 of value previously dereferenced in org.jenkinsci.plugins.saml.SamlValidateIdPMetadata.process() [org.jenkinsci.plugins.saml.SamlValidateIdPMetadata, org.jenkinsci.plugins.saml.SamlValidateIdPMetadata] At SamlValidateIdPMetadata.java:[line 30]Redundant null check at SamlValidateIdPMetadata.java:[line 38] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE

[INFO]

          [JENKINS-55205] Review findbugs error with some OS+JDK

          Ivan Fernandez Calvo created issue -
          Ivan Fernandez Calvo made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Ivan Fernandez Calvo made changes -
          Remote Link New: This issue links to "PR (Web Link)" [ 22107 ]

          Ivan Fernandez Calvo added a comment -

          there are some error reported by findbugs on Java 11 that are false positive due https://issues.jenkins-ci.org/browse/JENKINS-53692, I will ignore them

          Ivan Fernandez Calvo added a comment - there are some error reported by findbugs on Java 11 that are false positive due https://issues.jenkins-ci.org/browse/JENKINS-53692 , I will ignore them
          Ivan Fernandez Calvo made changes -
          Link New: This issue is related to JENKINS-53692 [ JENKINS-53692 ]
          Ivan Fernandez Calvo made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Ivan Fernandez Calvo made changes -
          Released As New: saml-1.1.2
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]
          Baptiste Mathus made changes -
          Labels New: java11-devtools-compatibility

          Baptiste Mathus added a comment -

          Hello ifernandezcalvo, about that, you might also be interested to watch https://github.com/jenkinsci/plugin-pom/pull/128

          Baptiste Mathus added a comment - Hello ifernandezcalvo , about that, you might also be interested to watch https://github.com/jenkinsci/plugin-pom/pull/128
          Mark Waite made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]

            ifernandezcalvo Ivan Fernandez Calvo
            ifernandezcalvo Ivan Fernandez Calvo
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: