[JENKINS-55426] Using "for in" loop for generating tasks for "parallel" execution, causes all tasks to have last value from iterated collection

Type: Bug
Resolution: Unresolved
Priority: Minor
Component/s: groovy-plugin
Labels:
- groovy
- parallel
Environment:
Jenkins 2.150.1, Pipeline-Groovy Plugin 2.57

Similar Issues:
Powered by SuggestiMate

Show

When I try to generate tasks for parallel execution using the following code:

import jenkins.model.Jenkins

pipeline {
    agent none
    stages {
        stage('Preparing machines') {
            steps {
                script {
                    def machines = ['agent-windows0', 'agent-windows1', 'agent-redhat0', 'agent-redhat1']
                    def machinePreparations = [:]

                    for (machine in machines) {
                        def labelParameters = []
                        labelParameters.add([$class: 'NodeParameterValue', name: 'node_name', labels: [machine], nodeEligibility: [$class: 'AllNodeEligibility']])
                        labelParameters.add([$class: 'StringParameterValue', name: 'ARBITRARY_PARAMETER', value: 'ARBITRARY_VALUE'])

                        machinePreparations[machine] = {
                            stage(machine + ' preparation') {
                                build job: '../Preparation/' + machine, parameters: labelParameters

                                def node = Jenkins.get().nodes.find({it.name == machine})
                                node.setLabelString(node.getLabelString() + 'successful')
                                println(String.format("Job with machine %s successfully done!", machine))
                            }
                        }
                    }

                    parallel machinePreparations
                }
            }
        }
    }
}

I have all the tasks receiving last value from collection ("agent-redhat1") - see screen attached.
This can be partially fixed by saving "machine" variable into another intermediate variable and using this intermediate variable instead:

import jenkins.model.Jenkins

pipeline {
    agent none
    stages {
        stage('Preparing machines') {
            steps {
                script {
                    def machines = ['agent-windows0', 'agent-windows1', 'agent-redhat0', 'agent-redhat1']
                    def machinePreparations = [:]

                    for (machine in machines) {
                        def agentName = machine
                        def labelParameters = []
                        labelParameters.add([$class: 'NodeParameterValue', name: 'node_name', labels: [agentName], nodeEligibility: [$class: 'AllNodeEligibility']])
                        labelParameters.add([$class: 'StringParameterValue', name: 'ARBITRARY_PARAMETER', value: 'ARBITRARY_VALUE'])

                        machinePreparations[agentName] = {
                            stage(agentName + ' preparation') {
                                build job: '../Preparation/' + agentName, parameters: labelParameters

                                def node = Jenkins.get().nodes.find({it.name == agentName})
                                node.setLabelString(node.getLabelString() + 'successful')
                                println(String.format("Job with machine %s successfully done!", agentName))
                            }
                        }
                    }

                    parallel machinePreparations
                }
            }
        }
    }
}

However, this also not fixing problem entirely, see JENKINS-55425

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

image-2020-04-20-14-01-42-072.png
33 kB
2020-04-20 11:01
screen1.jpg
196 kB
2019-01-07 14:51

is blocking

JENKINS-55748 Jenkins cannot execute one job with the same (by value, not adress) parameters, more than once

Open

Alexandr Panshin created issue - 2019-01-07 14:55

Alexandr Panshin made changes - 2019-01-07 14:56

Description

Original: When I try to generate tasks for parallel execution using the following code:
{code:java}
import jenkins.model.Jenkins

pipeline {
    agent none
    stages {
        stage('Preparing machines') {
            steps {
                script {
                    def machines = ['agent-windows0', 'agent-windows1', 'agent-redhat0', 'agent-redhat1']
                    def machinePreparations = [:]

                    for (machine in machines) {
                        def labelParameters = []
                        labelParameters.add([$class: 'NodeParameterValue', name: 'node_name', labels: [machine], nodeEligibility: [$class: 'AllNodeEligibility']])
                        labelParameters.add([$class: 'StringParameterValue', name: 'ARBITRARY_PARAMETER', value: 'ARBITRARY_VALUE'])

                        machinePreparations[machine] = {
                            stage(machine + ' preparation') {
                                build job: '../Preparation/' + machine, parameters: labelParameters

                                def node = Jenkins.get().nodes.find({it.name == machine})
                                node.setLabelString(node.getLabelString() + 'successful')
                                println(String.format("Job with machine %s successfully done!", machine))
                            }
                        }
                    }

                    parallel machinePreparations
                }
            }
        }
    }
}
{code}
I have all the tasks receiving last value from collection ("agent-redhat1") - see screen attached.
This can be partially fixed by saving "machine" variable into another intermediate variable and using this intermediate variable instead:

{code:java}
import jenkins.model.Jenkins

pipeline {
    agent none
    stages {
        stage('Preparing machines') {
            steps {
                script {
                    def machines = ['agent-windows0', 'agent-windows1', 'agent-redhat0', 'agent-redhat1']
                    def machinePreparations = [:]

                    for (machine in machines) {
                        def agentName = machine
                        def labelParameters = []
                        labelParameters.add([$class: 'NodeParameterValue', name: 'node_name', labels: [agentName], nodeEligibility: [$class: 'AllNodeEligibility']])
                        labelParameters.add([$class: 'StringParameterValue', name: 'ARBITRARY_PARAMETER', value: 'ARBITRARY_VALUE'])

                        machinePreparations[agentName] = {
                            stage(agentName + ' preparation') {
                                build job: '../Preparation/' + agentName, parameters: labelParameters

                                def node = Jenkins.get().nodes.find({it.name == agentName})
                                node.setLabelString(node.getLabelString() + 'successful')
                                println(String.format("Job with machine %s successfully done!", agentName))
                            }
                        }
                    }

                    parallel machinePreparations
                }
            }
        }
    }
}
{code}

However, this also not fixing problem entirely, see [#JENKINS-55425]

New: When I try to generate tasks for parallel execution using the following code:
{code:java}
import jenkins.model.Jenkins

pipeline {
    agent none
    stages {
        stage('Preparing machines') {
            steps {
                script {
                    def machines = ['agent-windows0', 'agent-windows1', 'agent-redhat0', 'agent-redhat1']
                    def machinePreparations = [:]

                    for (machine in machines) {
                        def labelParameters = []
                        labelParameters.add([$class: 'NodeParameterValue', name: 'node_name', labels: [machine], nodeEligibility: [$class: 'AllNodeEligibility']])
                        labelParameters.add([$class: 'StringParameterValue', name: 'ARBITRARY_PARAMETER', value: 'ARBITRARY_VALUE'])

                        machinePreparations[machine] = {
                            stage(machine + ' preparation') {
                                build job: '../Preparation/' + machine, parameters: labelParameters

                                def node = Jenkins.get().nodes.find({it.name == machine})
                                node.setLabelString(node.getLabelString() + 'successful')
                                println(String.format("Job with machine %s successfully done!", machine))
                            }
                        }
                    }

                    parallel machinePreparations
                }
            }
        }
    }
}
{code}
I have all the tasks receiving last value from collection ("agent-redhat1") - see screen attached.
This can be partially fixed by saving "machine" variable into another intermediate variable and using this intermediate variable instead:

{code:java}
import jenkins.model.Jenkins

pipeline {
    agent none
    stages {
        stage('Preparing machines') {
            steps {
                script {
                    def machines = ['agent-windows0', 'agent-windows1', 'agent-redhat0', 'agent-redhat1']
                    def machinePreparations = [:]

                    for (machine in machines) {
                        def agentName = machine
                        def labelParameters = []
                        labelParameters.add([$class: 'NodeParameterValue', name: 'node_name', labels: [agentName], nodeEligibility: [$class: 'AllNodeEligibility']])
                        labelParameters.add([$class: 'StringParameterValue', name: 'ARBITRARY_PARAMETER', value: 'ARBITRARY_VALUE'])

                        machinePreparations[agentName] = {
                            stage(agentName + ' preparation') {
                                build job: '../Preparation/' + agentName, parameters: labelParameters

                                def node = Jenkins.get().nodes.find({it.name == agentName})
                                node.setLabelString(node.getLabelString() + 'successful')
                                println(String.format("Job with machine %s successfully done!", agentName))
                            }
                        }
                    }

                    parallel machinePreparations
                }
            }
        }
    }
}
{code}

However, this also not fixing problem entirely, see [JENKINS-55425|https://issues.jenkins-ci.org/browse/JENKINS-55425]

Alexandr Panshin made changes - 2019-01-23 14:50

Link

New: This issue is blocking JENKINS-55748 [ JENKINS-55748 ]

Sergei S made changes - 2020-04-20 11:01

Attachment

New: image-2020-04-20-14-01-42-072.png [ 51000 ]

Jenkins

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates