Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55557

Support oAuth2.0 state parameter

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • github-oauth-plugin
    • None

      The current implementation does not support the `state` parameter in the oAuth2 authorization request it sends to the Github AS when attempting to authorize the plugin for a user.  As such, it is vulnerable to CSRF attacks against redirect URI as described in [1]

       The state parameter is supported by the Github API [2] , so support could be added in the github-oauth-plugin also.

       

      [1] https://tools.ietf.org/html/rfc6819#section-4.4.1.8
      [2] https://developer.github.com/apps/building-oauth-apps/authorizing-oauth-apps/#web-application-flow

            sag47 Sam Gleske
            ikakavas Ioannis Kakavas
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: