• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Component/s: warnings-ng-plugin
• Labels:

  • help-wanted

[JENKINS-55574] interpolate variables in filters strings

Brian J Murrell created issue - 2019-01-14 12:18

Ulli Hafner made changes - 2019-01-14 21:55

Description

Original: It would be nice if variables could be interpolated into the strings for the filters. Currently, the filter strings are in quotes. Without quotes they could just be a string which contains a regular expression subject to variable interpolation: {noformat} def arch = 'bar' def myregex = '.*\\/foobar-\${arch}\\/' ... recordIssues filters: [excludeFile(myregex)], tools: [gcc4()] {noformat} The backslash in front of {{$\{arch\}}} escapes the {{$}} from the RE. if one wanted it escaped from variable interpolation one would need to add another backslash such as {{\\$\{arch\}}} Being able to define a list of {{excludeFile()}}s in a single variable would be even more useful though. not sure how that could work though.

New: It would be nice if variables could be interpolated into the strings for the filters. Currently, the filter strings are in quotes. Without quotes they could just be a string which contains a regular expression subject to variable interpolation: {noformat} def arch = 'bar' def myregex = '.*\\/foobar-\${arch}\\/' ... recordIssues filters: [excludeFile(myregex)], tools: [gcc4()] {noformat} The backslash in front of {{$\{arch\}}} escapes the {{$}} from the RE. if one wanted it escaped from variable interpolation one would need to add another backslash such as {{\\$\{arch\}}} Being able to define a list of {{excludeFile()}} s in a single variable would be even more useful though. not sure how that could work though.

Ulli Hafner made changes - 2019-01-15 11:25

Rank

New: Ranked higher

Ulli Hafner made changes - 2019-01-15 11:28

Rank

New: Ranked higher

Ulli Hafner made changes - 2019-01-15 11:41

Rank

New: Ranked higher

Ulli Hafner made changes - 2019-02-13 12:23

Assignee	Original: Ulli Hafner [ drulli ]
Labels		New: help-wanted

Ulli Hafner made changes - 2020-03-04 21:07

Rank

New: Ranked lower

Collapse comment: Kalle Niemitalo added a comment - 2020-03-05 07:09

Kalle Niemitalo added a comment - 2020-03-05 07:09

Can't you use Groovy's string interpolation instead? I believe this should work already:

def arch = 'bar'
def myregex = ".*\\/foobar-${arch}\\/"
recordIssues filters: [excludeFile(myregex)], tools: [gcc4()]

Here though, string interpolation would happen before the regular expression is parsed. So if arch can contain regular expression metacharacters but you want to match them as literal characters instead, then you might have to quote arch before inserting it to the regular expression:

def myregex = ".*\\/foobar-${java.util.regex.Pattern.quote(arch)}\\/"

I did not test any of this, though.

Expand comment: Kalle Niemitalo added a comment - 2020-03-05 07:09

Kalle Niemitalo added a comment - 2020-03-05 07:09 Can't you use Groovy's string interpolation instead? I believe this should work already: def arch = 'bar' def myregex = ".*\\/foobar-${arch}\\/" recordIssues filters: [excludeFile(myregex)], tools: [gcc4()] Here though, string interpolation would happen before the regular expression is parsed. So if arch can contain regular expression metacharacters but you want to match them as literal characters instead, then you might have to quote arch before inserting it to the regular expression: def myregex = ".*\\/foobar-${java.util.regex.Pattern.quote(arch)}\\/" I did not test any of this, though.