Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55609

Submitted JCL no longer supports variable substitution

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: zos-connector-plugin
    • Labels:
      None
    • Environment:
      Jenkins 2.150.1 on Windows 10 1809 64-bit
      IBM z/OS Connector 2.0.1
      EnvInject API Plugin 1.5
      Environment Injector Plugin 2.1.6
    • Similar Issues:
    • Released As:
      attachment

      Description

      Prior to version 2 of the plugin, the JCL that was submitted allowed for variable substitution within the job.  We used this extensively (generating timestamps, starting/stopping configurable CICS regions, etc) in the JCL that we have and were running on a regular basis.

      I can't think of a simple way to replicate this.  The best I can think of is an intermediate step from checkout to injection where a shell or command script is run to perform the substitutions prior to the submission.  But this feels a bit awkward, and error prone.

      I'd really like to see this functionality restored, if possible.

      Happy to look into it myself, just might take a while.

        Attachments

          Activity

          strattondrs Daniel Stratton created issue -
          strattondrs Daniel Stratton made changes -
          Field Original Value New Value
          Environment Jenkins 2.150.1 on Windows 10 1809 64-bit
          IBM z/OS Connector 2.0.1
          EnvInject API Plugin 1.5
          Environment Injector Plugin 2.1.6
          Hide
          candiduslynx Alexander Shcherbakov added a comment -

          I'll create new version with such support and will upload it here by tomorrow.

          Kindly verify this version and give feedback before I go and release it.

          Show
          candiduslynx Alexander Shcherbakov added a comment - I'll create new version with such support and will upload it here by tomorrow. Kindly verify this version and give feedback before I go and release it.
          candiduslynx Alexander Shcherbakov made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          candiduslynx Alexander Shcherbakov made changes -
          Attachment zos-connector.hpi [ 45757 ]
          Hide
          candiduslynx Alexander Shcherbakov added a comment -

          Will either drop issue in a week if no response or update (if have ability to test myself).

          Show
          candiduslynx Alexander Shcherbakov added a comment - Will either drop issue in a week if no response or update (if have ability to test myself).
          candiduslynx Alexander Shcherbakov made changes -
          Released As attachment
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Fixed but Unreleased [ 10203 ]
          candiduslynx Alexander Shcherbakov made changes -
          Comment [ I've uploaded new version as attachment. I'll wait for a week before releasing if I have no feedback from you. ]
          candiduslynx Alexander Shcherbakov made changes -
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          candiduslynx Alexander Shcherbakov made changes -
          Attachment zos-connector.hpi [ 45757 ]
          candiduslynx Alexander Shcherbakov made changes -
          Attachment zos-connector.hpi [ 45758 ]
          strattondrs Daniel Stratton made changes -
          Attachment tests.7z [ 45760 ]
          Hide
          strattondrs Daniel Stratton added a comment -

          I've successfully tested the snapshot in our environment.  Tests include:

          • Starting a Freestyle job (with parms) that starts a CICS region
          • Starting a Freestyle job (with parms) that stops a CICS region
          • Starting a pipeline job that invokes the stop and start jobs to bounce a region
          • Started a Freestyle job that runs a simple job on the mainframe with a substituted timestamp for generating an archive

          The job definitions aren't attached, but I have included the groovy, pipeline and JCL (using File System SCM) that I used for my tests.  Nothing flash, but they all work again as expected.  I still have others that need testing but that relies on an IPL cycle which isn't slated for a while.  But given these work, I fully expect those to work as well.

          Thanks heaps for the fast turnaround on this.

          Show
          strattondrs Daniel Stratton added a comment - I've successfully tested the snapshot in our environment.  Tests include: Starting a Freestyle job (with parms) that starts a CICS region Starting a Freestyle job (with parms) that stops a CICS region Starting a pipeline job that invokes the stop and start jobs to bounce a region Started a Freestyle job that runs a simple job on the mainframe with a substituted timestamp for generating an archive The job definitions aren't attached, but I have included the groovy, pipeline and JCL (using File System SCM) that I used for my tests.  Nothing flash, but they all work again as expected.  I still have others that need testing but that relies on an IPL cycle which isn't slated for a while.  But given these work, I fully expect those to work as well. Thanks heaps for the fast turnaround on this.
          Hide
          candiduslynx Alexander Shcherbakov added a comment -

          released as 2.1.0

          Show
          candiduslynx Alexander Shcherbakov added a comment - released as 2.1.0
          candiduslynx Alexander Shcherbakov made changes -
          Status Fixed but Unreleased [ 10203 ] Resolved [ 5 ]
          candiduslynx Alexander Shcherbakov made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            Assignee:
            candiduslynx Alexander Shcherbakov
            Reporter:
            strattondrs Daniel Stratton
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: