Details
-
Bug
-
Status: Resolved (View Workflow)
-
Trivial
-
Resolution: Fixed
-
-
Jenkins 2.164
Description
When the master goes out of disk space, it is put offline by the hudson.node_monitors.AbstractDiskSpaceMonitor system.
The message has a blank where the node name should be:
Putting back online as there is enough disk space again
I think this is just because c.getName() returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.
Acceptance criteria
- This should show master instead of a space as the node name, i.e.
Putting back master online as there is enough disk space
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system. The message has a blank where the node name should be: {{Putting back online as there is enough disk space again}} I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. h3. Acceptance criteria * This should show {{master}} instead of a space as the node name |
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system. The message has a blank where the node name should be: {{Putting back online as there is enough disk space again}} I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. h3. Acceptance criteria * This should show {{master}} instead of a space as the node name |
| Description |
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system. The message has a blank where the node name should be: {{Putting back online as there is enough disk space again}} I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. h3. Acceptance criteria * This should show {{master}} instead of a space as the node name |
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system. The message has a blank where the node name should be: {{Putting back online as there is enough disk space again}} I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. h3. Acceptance criteria * This should show {{master}} instead of a space as the node name |
| Assignee | Nisarg Shah [ nisarg14 ] |
| Comment | [ Okay and Can I get just one help that how can I test my change in code. Like how would i run that code and check whether that issue has solved or not? ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Attachment | Capture1.JPG [ 45958 ] |
| Comment | [ I have tested this fix and I am attaching the screenshot of the result obtained. !Capture1.JPG! ] |
| Comment |
[ [~batmat] I have tested the fix and I am attaching the screenshot of the result obtained. !Capture1.JPG|thumbnail! ] |
| Attachment | Capture2.JPG [ 45959 ] |
| Attachment | Capture1.JPG [ 45960 ] |
| Description |
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system. The message has a blank where the node name should be: {{Putting back online as there is enough disk space again}} I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. h3. Acceptance criteria * This should show {{master}} instead of a space as the node name |
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system. The message has a blank where the node name should be: {{Putting back online as there is enough disk space again}} I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. h3. Acceptance criteria * This should show {{master}} instead of a space as the node name, i.e. {{Putting back *master* online as there is enough disk space}} |
| Attachment | Capture3.JPG [ 45977 ] |
| Attachment | Capture3 - Copy.JPG [ 45978 ] |
| Attachment | Capture4 - Copy.JPG [ 45979 ] |
| Attachment | Capture2 - Copy.JPG [ 45980 ] |
| Attachment | image-2019-02-09-00-30-55-101.png [ 45981 ] |
| Comment |
[ [~batmat] I am attaching screenshot of message after the fix. First photo is when there was an out of disk event detected. Second photo is when master node came online as the disk gets some empty space. And I think this fulfills the acceptance criteria. !image-2019-02-09-00-30-55-101.png|width=735,height=370! !Capture4 - Copy.JPG|width=598,height=263! ] |
| Attachment | Capture5 - Copy.JPG [ 45982 ] |
| Status | In Progress [ 3 ] | In Review [ 10005 ] |
| Labels | evergreen-triggered fosdem2019 newbie-friendly | evergreen-triggered fosdem2019 lts-candidate newbie-friendly |
| Released As | Jenkins 2.164 | |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10005 ] | Resolved [ 5 ] |
| Labels | evergreen-triggered fosdem2019 lts-candidate newbie-friendly | evergreen-triggered fosdem2019 newbie-friendly |