Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55787

Switch labels from entry to checkbox

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.179

      Description

      This is the preferred style:


      As opposed to:


      or

       

      I'm going to point to this issue for a bunch of plugins.

       

      Note: my initial efforts relied on using optionalBlock instead of entry + checkbox. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving label's from the entry to the checkbox. The rendering won't generally change from the examples above.

       

      Please don't close this ticket when an individual PR is merged, I'm using the same ticket for many plugins.

        Attachments

          Issue Links

            Activity

            jsoref Josh Soref created issue -
            jsoref Josh Soref made changes -
            Field Original Value New Value
            Component/s github-plugin [ 15896 ]
            Component/s workflow-cps-global-lib-plugin [ 21714 ]
            jsoref Josh Soref made changes -
            Component/s git-plugin [ 15543 ]
            jsoref Josh Soref made changes -
            Component/s mercurial-plugin [ 15502 ]
            jsoref Josh Soref made changes -
            Component/s mailer-plugin [ 17522 ]
            jsoref Josh Soref made changes -
            Component/s bitbucket-branch-source-plugin [ 21428 ]
            jsoref Josh Soref made changes -
            Issue Type Bug [ 1 ] Improvement [ 4 ]
            jsoref Josh Soref made changes -
            Component/s ssh-slaves-plugin [ 15578 ]
            jsoref Josh Soref made changes -
            Component/s wix-plugin [ 17462 ]
            jsoref Josh Soref made changes -
            Component/s tap-plugin [ 15874 ]
            jsoref Josh Soref made changes -
            Summary Switch from entry to optional block Switch labels from entry to checkbox
            jsoref Josh Soref made changes -
            Description This is the preferred style:

            !https://user-images.githubusercontent.com/2119212/51774426-47af6f00-20c0-11e9-8f58-ce82bd17dee4.png!
            As opposed to:

            !https://user-images.githubusercontent.com/2119212/51774439-539b3100-20c0-11e9-9c96-6569a173d80c.png!
            or
            !https://user-images.githubusercontent.com/2119212/51774473-6f9ed280-20c0-11e9-922c-42ea7ddedd34.png!

             

            --

            I'm going to point to this issue for a bunch of plugins.
            This is the preferred style:

            !https://user-images.githubusercontent.com/2119212/51774426-47af6f00-20c0-11e9-8f58-ce82bd17dee4.png!
             As opposed to:

            !https://user-images.githubusercontent.com/2119212/51774439-539b3100-20c0-11e9-9c96-6569a173d80c.png!
             or
             !https://user-images.githubusercontent.com/2119212/51774473-6f9ed280-20c0-11e9-922c-42ea7ddedd34.png!

             



            I'm going to point to this issue for a bunch of plugins.

             

            Note: my initial efforts relied on using optionalBlock instead of entry+checkbox. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving fields from the entry to the checkbox. The rendering won't generally change from the examples above.
            jsoref Josh Soref made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            olamy Olivier Lamy made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            olamy Olivier Lamy made changes -
            Labels jira-plugin-3.0.6
            jsoref Josh Soref made changes -
            Resolution Fixed [ 1 ]
            Status Closed [ 6 ] Reopened [ 4 ]
            kinow Bruno P. Kinoshita made changes -
            Status Reopened [ 4 ] Open [ 1 ]
            kinow Bruno P. Kinoshita made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Fixed but Unreleased [ 10203 ]
            kinow Bruno P. Kinoshita made changes -
            Status Fixed but Unreleased [ 10203 ] Resolved [ 5 ]
            kinow Bruno P. Kinoshita made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] In Review [ 10005 ]
            jsoref Josh Soref made changes -
            Component/s datadog-plugin [ 20826 ]
            jsoref Josh Soref made changes -
            Component/s qc-plugin [ 15759 ]
            jsoref Josh Soref made changes -
            Component/s hubot-steps-plugin [ 21960 ]
            jsoref Josh Soref made changes -
            Labels jira-plugin-3.0.6 jira-plugin-3.0.6 pipeline-model-definition-plugin
            jsoref Josh Soref made changes -
            Labels jira-plugin-3.0.6 pipeline-model-definition-plugin jira-plugin-3.0.6 pipeline-model-definition-plugin xunit
            nrayapati Naresh Rayapati made changes -
            Component/s hubot-steps-plugin [ 21960 ]
            warden Radek Antoniuk made changes -
            Labels jira-plugin-3.0.6 pipeline-model-definition-plugin xunit pipeline-model-definition-plugin xunit
            oleg_nenashev Oleg Nenashev made changes -
            Released As Jenkins 2.179
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            jsoref Josh Soref made changes -
            Component/s analysis-core-plugin [ 15709 ]
            jsoref Josh Soref made changes -
            Component/s timestamper-plugin [ 15749 ]
            jsoref Josh Soref made changes -
            Remote Link This issue links to "timestamper-plugin#32 (Web Link)" [ 23522 ]
            jsoref Josh Soref made changes -
            Component/s jobconfighistory-plugin [ 15683 ]
            jsoref Josh Soref made changes -
            Remote Link This issue links to "jobConfigHistory-plugin#105 (Web Link)" [ 23523 ]
            jsoref Josh Soref made changes -
            Link This issue relates to JENKINS-56109 [ JENKINS-56109 ]
            jsoref Josh Soref made changes -
            Remote Link This issue links to "mailer-plugin#52 (Web Link)" [ 23524 ]
            jsoref Josh Soref made changes -
            Component/s jclouds-plugin [ 16529 ]
            jsoref Josh Soref made changes -
            Remote Link This issue links to "jclouds-plugin#132 (Web Link)" [ 23525 ]
            felfert Fritz Elfert made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            jsoref Josh Soref made changes -
            Issue Type Improvement [ 4 ] Epic [ 10001 ]
            jsoref Josh Soref made changes -
            Description This is the preferred style:

            !https://user-images.githubusercontent.com/2119212/51774426-47af6f00-20c0-11e9-8f58-ce82bd17dee4.png!
             As opposed to:

            !https://user-images.githubusercontent.com/2119212/51774439-539b3100-20c0-11e9-9c96-6569a173d80c.png!
             or
             !https://user-images.githubusercontent.com/2119212/51774473-6f9ed280-20c0-11e9-922c-42ea7ddedd34.png!

             



            I'm going to point to this issue for a bunch of plugins.

             

            Note: my initial efforts relied on using optionalBlock instead of entry+checkbox. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving fields from the entry to the checkbox. The rendering won't generally change from the examples above.
            This is the preferred style:

            !https://user-images.githubusercontent.com/2119212/51774426-47af6f00-20c0-11e9-8f58-ce82bd17dee4.png!
             As opposed to:

            !https://user-images.githubusercontent.com/2119212/51774439-539b3100-20c0-11e9-9c96-6569a173d80c.png!
             or
             !https://user-images.githubusercontent.com/2119212/51774473-6f9ed280-20c0-11e9-922c-42ea7ddedd34.png!

             



            I'm going to point to this issue for a bunch of plugins.

             

            Note: my initial efforts relied on using {{optionalBlock}} instead of {{entry}} + {{checkbox}}. Unfortunately this interacts poorly w/ the form submission magic, and so rather than continue down that path, I'm switching to moving {{label}}'s from the {{entry}} to the {{checkbox}}. The rendering won't generally change from the examples above.

             

            Please don't close this ticket when an individual PR is merged, I'm using the same ticket for many plugins.
            markewaite Mark Waite made changes -
            Status Reopened [ 4 ] Open [ 1 ]
            basil Basil Crow made changes -
            Component/s timestamper-plugin [ 15749 ]
            markewaite Mark Waite made changes -
            Link This issue is related to JENKINS-61870 [ JENKINS-61870 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue relates to JENKINS-62437 [ JENKINS-62437 ]
            markewaite Mark Waite made changes -
            Component/s git-plugin [ 15543 ]
            jsoref Josh Soref made changes -
            Status Open [ 1 ] In Progress [ 3 ]

              People

              Assignee:
              jsoref Josh Soref
              Reporter:
              jsoref Josh Soref
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated: