Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55943

Add possibility to select osDisk SKU

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Duplicate
    • Component/s: _unsorted
    • Labels:
      None
    • Similar Issues:

      Description

      When using templates and managed disks, in Azure it is possible to define the osDisk type during creation (HDD, Standard_SSD, Premium_SSD).
      It would great if one could define the type for each Azure Virtual Machine Template.

        Attachments

          Activity

          Hide
          jieshe Jie Shen added a comment -

          Thanks, I have put this in backlog.

          Show
          jieshe Jie Shen added a comment - Thanks, I have put this in backlog.
          Hide
          stefanscherer Stefan Scherer added a comment -

          Any updates? Any help needed? (I don't know the codebase, but I could try if it's similar to eg. osDiskSize)

          Show
          stefanscherer Stefan Scherer added a comment - Any updates? Any help needed? (I don't know the codebase, but I could try if it's similar to eg. osDiskSize)
          Show
          jieshe Jie Shen added a comment - Stefan Scherer Feel free to create a PR. Some useful pages :  https://docs.microsoft.com/en-us/azure/templates/microsoft.compute/2019-03-01/virtualmachines#OSDisk  and  https://docs.microsoft.com/en-us/azure/templates/microsoft.compute/2019-03-01/virtualmachines#ManagedDiskParameters .
          Hide
          stefanscherer Stefan Scherer added a comment -

          Thanks,

          I searched through the codebase and I think this variable 

          "storageAccountType": "Standard_LRS",

          in https://github.com/jenkinsci/azure-vm-agents-plugin/blob/dev/src/main/resources/customImageTemplateWithManagedDisk.json#L15 doesn't get changed.

           

          Show
          stefanscherer Stefan Scherer added a comment - Thanks, I searched through the codebase and I think this variable  "storageAccountType": "Standard_LRS", in  https://github.com/jenkinsci/azure-vm-agents-plugin/blob/dev/src/main/resources/customImageTemplateWithManagedDisk.json#L15  doesn't get changed.  
          Hide
          stefanscherer Stefan Scherer added a comment -

          I've also created JENKINS-59752 which is about the same topic, having better disk performance for the OS disk. This would be even more interesting for us.

          Show
          stefanscherer Stefan Scherer added a comment - I've also created JENKINS-59752 which is about the same topic, having better disk performance for the OS disk. This would be even more interesting for us.
          Hide
          jieshe Jie Shen added a comment -

          The "storageAccountType" is changed dynamically at https://github.com/jenkinsci/azure-vm-agents-plugin/blob/4a0960ef24fb9724968abb832d9b58b4380b0e86/src/main/java/com/microsoft/azure/vmagent/AzureVMManagementServiceDelegate.java#L517 . But it seems that not all the templates' OSdisk item has the "managedDisk" property. 

          Show
          jieshe Jie Shen added a comment - The "storageAccountType" is changed dynamically at https://github.com/jenkinsci/azure-vm-agents-plugin/blob/4a0960ef24fb9724968abb832d9b58b4380b0e86/src/main/java/com/microsoft/azure/vmagent/AzureVMManagementServiceDelegate.java#L517  . But it seems that not all the templates' OSdisk item has the "managedDisk" property. 
          Hide
          one_random_dev Random Dev added a comment -

          Any updates on this, not really sure this is tied to storage account type.

          I believe storage account type is related to the disk storage type?

          On Azure if I navigate to the disk resource the storage types available are:
          Standard_HDD
          Standard_SSD
          Premium_SSD
          Ultra Disk

          on the storage account type dropdown I can only see Standard_LRS and Premium LRS
          maybe this setting is not related, but if not can you provide a way to select the storage type in the disk that will be attached to the VM?

          Thanks in advance, great plugin overall

          Show
          one_random_dev Random Dev added a comment - Any updates on this, not really sure this is tied to storage account type. I believe storage account type is related to the disk storage type? On Azure if I navigate to the disk resource the storage types available are: Standard_HDD Standard_SSD Premium_SSD Ultra Disk on the storage account type dropdown I can only see Standard_LRS and Premium LRS maybe this setting is not related, but if not can you provide a way to select the storage type in the disk that will be attached to the VM? Thanks in advance, great plugin overall
          Hide
          timja Tim Jacomb added a comment -

          All issues have been transferred to GitHub.

          See https://github.com/jenkinsci/azure-vm-agents-plugin/issues

          Search the issue title to find it.

          (This is a bulk comment and can't link to the specific issue)

          Show
          timja Tim Jacomb added a comment - All issues have been transferred to GitHub. See https://github.com/jenkinsci/azure-vm-agents-plugin/issues Search the issue title to find it. (This is a bulk comment and can't link to the specific issue)

            People

            Assignee:
            jieshe Jie Shen
            Reporter:
            claasd Claas Diederichs
            Votes:
            3 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: