Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55973

Update Jenkins POM and Core to SpotBugs

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Plugin POM has successfully moved to SpotBugs in 3.36: https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md#336 .

      Now we could do the same in Parent POM for Jenkins components, and in the Jenkins core itself.

       

      CC batmat casz teilo

       

          [JENKINS-55973] Update Jenkins POM and Core to SpotBugs

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Link New: This issue relates to JENKINS-44123 [ JENKINS-44123 ]

          James Nord added a comment -

          yes please and replace the JSR-305 annotations \o/

          James Nord added a comment - yes please and replace the JSR-305 annotations \o/
          Jesse Glick made changes -
          Remote Link New: This issue links to "jenkins #4604 (Web Link)" [ 24906 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Jesse Glick added a comment -

          What is the overall status here? Core is patched; do we need something done in plugin POMs?

          Jesse Glick added a comment - What is the overall status here? Core is patched; do we need something done in plugin POMs?
          ikedam made changes -
          Description Original: Plugin POM has successfully moved to SpotBugs in 2.36: [https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md#336] .

          Now we could do the same in Parent POM for Jenkins components, and in the Jenkins core itself.

           

          CC [~batmat] [~casz] [~teilo]

                      		New: Plugin POM has successfully moved to SpotBugs in 3.36: [https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md#336] .

          Now we could do the same in Parent POM for Jenkins components, and in the Jenkins core itself.

           

          CC [~batmat] [~casz] [~teilo]

           

          ikedam added a comment -

          More details about removing / replacing JSR-305:
          (as many plugins would refer #4604 for replacing jsr-305)

          ikedam added a comment - More details about removing / replacing JSR-305: (as many plugins would refer #4604 for replacing jsr-305) JSR-305 is in Dormant status: https://jcp.org/en/jsr/detail?id=305 https://spotbugs.readthedocs.io/en/latest/migration.html#com-google-code-findbugs-jsr305 You can find discussions about preferring findbugs annotations to jsr305 annotations here: https://github.com/google/guava/issues/2960 https://github.com/spotbugs/spotbugs/pull/180 Related versions in jenkins: jenkins-2.181 switched findbugs to spotbugs: https://github.com/jenkinsci/jenkins/pull/4062 jenkins-2.231 no longer use jsr-305 annotations: https://github.com/jenkinsci/jenkins/pull/4604 jenkins-2.326 no longer depends on jsr-305: https://github.com/jenkinsci/jenkins/pull/6066 plugin-pom-3.36 switched findbugs to spotbugs: https://github.com/jenkinsci/plugin-pom/pull/128

          Basil Crow added a comment -

          At some point in the past few months I swept all active core components and switched them to SpotBugs and the latest parent POM.

          Basil Crow added a comment - At some point in the past few months I swept all active core components and switched them to SpotBugs and the latest parent POM.
          Basil Crow made changes -
          Assignee New: Basil Crow [ basil ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

            basil Basil Crow
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: