Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-56016

Input step submitter parameter is ignored for administrators

    XMLWordPrintable

Details

    • Bug
    • Status: Fixed but Unreleased (View Workflow)
    • Major
    • Resolution: Fixed
    • pipeline-input-step-plugin
    • None
    • Jenkins 2.151.0
      Pipeline Input Step: 2.9

    Description

      I use the following snippet in my DSL pipeline

      operators = "ldapUserGroup"
ChoiceParameterDefinition choice = new ChoiceParameterDefinition('continue', ['YES'] as String[], 'Description')
returnValue = input message: 'DEPLOY ?', 
                    parameters: [choice], 
                    submitter: operators, 
                    submitterParameter: 'approver'

      I am not part of the ldapUserGroup thus I would expect the pipeline not to continue. However the pipeline continues anyway.

      07:39:05 Approved by Surname Lastname
[Pipeline] }

      The same happens if i use a particular userID or list of userIDs rather than an ldapGroup

      operators = "userID0001,userID0002"
ChoiceParameterDefinition choice = new ChoiceParameterDefinition('continue', ['YES'] as String[], 'Description')
returnValue = input message: 'DEPLOY ?', 
                    parameters: [choice], 
                    submitter: operators, 
                    submitterParameter: 'approver'

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-48998 Can't approve pipeline input step to proceed even when a global admin

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • In Review
          links to

          Web Link jenkinsci/pipeline-input-step-plugin#39

          Activity

            Ascending order - Click to sort in descending order
            papanito papanito created issue -
            papanito papanito made changes -
            Field Original Value New Value
            Description I use the following snippet in my DSL pipeline

             
            {code:java}
            operators = "ldapUserGroup"
            ChoiceParameterDefinition choice = new ChoiceParameterDefinition('continue', ['YES'] as String[], 'Description')
            returnValue = input message: 'DEPLOY ?',
                                parameters: [choice],
                                submitter: operators,
                                submitterParameter: 'approver'
            {code}
            I am not part of the {{ldapUserGroup}} thus I would expect the pipeline not to continue. However the pipeline continues anyway.

             

             
            {code:java}
            07:39:05 Approved by Surname Lastname
            [Pipeline] }
            {code}
             

            The same happens if i use a particular userID or list of userIDs rather than an ldapGroup
            {code:java}
            operators = "userID0001,userID0002"
            ChoiceParameterDefinition choice = new ChoiceParameterDefinition('continue', ['YES'] as String[], 'Description')
            returnValue = input message: 'DEPLOY ?',
                                parameters: [choice],
                                submitter: operators,
                                submitterParameter: 'approver'
            {code}             		I use the following snippet in my DSL pipeline
            {code:java}
            operators = "ldapUserGroup"
            ChoiceParameterDefinition choice = new ChoiceParameterDefinition('continue', ['YES'] as String[], 'Description')
            returnValue = input message: 'DEPLOY ?',
                                parameters: [choice],
                                submitter: operators,
                                submitterParameter: 'approver'
            {code}
            I am not part of the {{ldapUserGroup}} thus I would expect the pipeline not to continue. However the pipeline continues anyway.
            {code:java}
            07:39:05 Approved by Surname Lastname
            [Pipeline] }
            {code}
            The same happens if i use a particular userID or list of userIDs rather than an ldapGroup
            {code:java}
            operators = "userID0001,userID0002"
            ChoiceParameterDefinition choice = new ChoiceParameterDefinition('continue', ['YES'] as String[], 'Description')
            returnValue = input message: 'DEPLOY ?',
                                parameters: [choice],
                                submitter: operators,
                                submitterParameter: 'approver'
            {code}
            dnusbaum Devin Nusbaum made changes -
            Summary Input Submitter parameter ignored Input step submitter parameter is ignored for administrators
            dnusbaum Devin Nusbaum made changes -
            Remote Link This issue links to "jenkinsci/pipeline-input-step-plugin#39 (Web Link)" [ 23601 ]
            dnusbaum Devin Nusbaum made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            dnusbaum Devin Nusbaum made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            dnusbaum Devin Nusbaum made changes -
            Assignee Adrian Wyssmann [ papanito ]
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Fixed but Unreleased [ 10203 ]
            dnusbaum Devin Nusbaum made changes -
            Link This issue is caused by JENKINS-48998 [ JENKINS-48998 ]

            People

              papanito papanito
              papanito papanito
              Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: