• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: pipeline-maven-plugin
• Labels:

  None
• Environment:

  Pipeline Maven Integration Plugin 3.6.7

[JENKINS-56232] Maven Local Repository is always seen as relative when it should be absolute

Lasse Lindqvist created issue - 2019-02-21 10:23

Lasse Lindqvist made changes - 2019-02-21 10:24

Description

Original: Using Jenkinsfile with withMaven(mavenLocalRepo: '${user.home}/.m2/$EXECUTOR_NUMBER/repository') resolves the local repository path to {code:java} -Dmaven.repo.local=/home/jenkins/workspace/somerepository/${user.home}/.m2/2/repository: bad substitution {code} so user.home does not get resolved. This is fine if not possible now. But also using withMaven(mavenLocalRepo: '~/.m2/$EXECUTOR_NUMBER/repository') resolves the local repository path to {code:java} -Dmaven.repo.local=/home/jenkins/workspace/somerepository/~/.m2/2/repository: bad substitution {code} Using withMaven(mavenLocalRepo: '$WORKSPACE/../../.m2/$EXECUTOR_NUMBER/repository') can be used to escape from a single non-permanent workspace to use a common local repository, but this is not ideal. Concerned code seems to be here: https://github.com/jenkinsci/pipeline-maven-plugin/blob/pipeline-maven-3.6.7/jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution2.java#L662

New: Using Jenkinsfile with withMaven(mavenLocalRepo: '${user.home}/.m2/$EXECUTOR_NUMBER/repository') resolves the local repository path to {code:java} -Dmaven.repo.local=/home/jenkins/workspace/somerepository/${user.home}/.m2/2/repository: bad substitution {code} so user.home does not get resolved. This is fine if not possible now. But also using withMaven(mavenLocalRepo: '~/.m2/$EXECUTOR_NUMBER/repository') resolves the local repository path to {code:java} -Dmaven.repo.local=/home/jenkins/workspace/somerepository/~/.m2/2/repository {code} Using withMaven(mavenLocalRepo: '$WORKSPACE/../../.m2/$EXECUTOR_NUMBER/repository') can be used to escape from a single non-permanent workspace to use a common local repository, but this is not ideal. Concerned code seems to be here: https://github.com/jenkinsci/pipeline-maven-plugin/blob/pipeline-maven-3.6.7/jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution2.java#L662

Cyrille Le Clerc made changes - 2019-02-22 10:58

Assignee

Original: Alvaro Lobato [ alobato ]

New: Cyrille Le Clerc [ cleclerc ]

Cyrille Le Clerc made changes - 2019-04-22 21:55

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Cyrille Le Clerc made changes - 2019-04-22 21:55

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Collapse comment: Lasse Lindqvist added a comment - 2019-04-23 07:33

Lasse Lindqvist added a comment - 2019-04-23 07:33

The related commit is here: https://github.com/jenkinsci/pipeline-maven-plugin/commit/496eb784e2e9a0fd9e463922f6001848c2d5eda6

Expand comment: Lasse Lindqvist added a comment - 2019-04-23 07:33

Lasse Lindqvist added a comment - 2019-04-23 07:33 The related commit is here: https://github.com/jenkinsci/pipeline-maven-plugin/commit/496eb784e2e9a0fd9e463922f6001848c2d5eda6

Collapse comment: Cyrille Le Clerc added a comment - 2019-04-23 11:40

Cyrille Le Clerc added a comment - 2019-04-23 11:40

Fixed in 3.6.10

Expand comment: Cyrille Le Clerc added a comment - 2019-04-23 11:40

Cyrille Le Clerc added a comment - 2019-04-23 11:40 Fixed in 3.6.10

Cyrille Le Clerc made changes - 2019-05-29 14:11

Resolution		New: Fixed [ 1 ]
Status	Original: In Review [ 10005 ]	New: Closed [ 6 ]

Collapse comment: Horst Krause added a comment - 2021-06-14 09:49

Horst Krause added a comment - 2021-06-14 09:49

Note: The fix just checks if the mavenLocalRepo starts with a slash ("/") to detect absolute path. So using "~/.m2/any-repo-name" still won't work.

Expand comment: Horst Krause added a comment - 2021-06-14 09:49

Horst Krause added a comment - 2021-06-14 09:49 Note: The fix just checks if the mavenLocalRepo starts with a slash ("/") to detect absolute path. So using "~/.m2/any-repo-name" still won't work.