[JENKINS-56248] P4Plugin Polls Workspaces With Disabled Polling (poll: false)

Type: Bug
Resolution: Unresolved
Priority: Major
Component/s: p4-plugin
Labels:
- P4_B
Environment:
Jenkins: 2.150.3 (official docker image)
P4 Plugin: 1.9.6

Similar Issues:
Powered by SuggestiMate

Show

Hello

P4Plugin polls all workspaces used in job even if poll parameter is disabled in checkout.

Steps to reproduce

Create pipeline job test4 (see below)
Start pipeline job test4
See "Perforce Software Polling Log" and Perforce Server Log

pipeline {
    agent(none)
 
    options {
        ansiColor("xterm")
        buildDiscarder(logRotator(numToKeepStr: "10"))
        disableConcurrentBuilds()
        disableResume()
        skipDefaultCheckout(true)
        timestamps()
    }
 
    triggers {
        pollSCM("* * * * *")
    }
 
    stages {
        stage("Master") {
            agent {
                label("master")
            }
 
            steps {
                checkout perforce(credential: 'perforce-ticket-jenkins', populate: flushOnly(pin: '', quiet: false),
                        workspace: streamSpec(charset: 'none', format: 'test4-master', pinHost: true, streamName: '//playground/jenkins-main'))
            }
        }
 
        stage("Win-1") {
            agent {
                label("k02-bld-win-01")
            }
 
            steps {
                checkout changelog: false, poll: false, scm: perforce(credential: 'perforce-ticket-jenkins', populate: flushOnly(pin: '', quiet: false),
                        workspace: streamSpec(charset: 'none', format: 'test4-win-1', pinHost: true, streamName: '//playground/jenkins-main'))
            }
        }

        stage("Win-2") {
            agent {
                label("k02-bld-win-02")
            }
 
            steps {
                checkout changelog: false, poll: false, scm: perforce(credential: 'perforce-ticket-jenkins', populate: flushOnly(pin: '', quiet: false),
                        workspace: streamSpec(charset: 'none', format: 'test4-win-2', pinHost: true, streamName: '//playground/jenkins-main'))
            }
        }
    }
}

Perforce Software Polling Log

Started on Feb 22, 2019 3:45:00 PM
P4: Polling on: master with:test4-master
Found last change 1180191 on syncID test4-master
... p4 client -o test4-master +
... p4 info +
... p4 info +
... p4 client -o test4-master +
...   No change in client detected.
 
P4 Task: establishing connection.
... server: perforce:1666
... node: k02-jenkins
P4: Polling with range: 1180191,now
... p4 changes -m20 //test4-master/...@1180191,now +
... p4 repos -C +
P4: Polling on: master with:test4-win-1
Found last change 1180191 on syncID test4-win-1
... p4 client -o test4-win-1 +
... p4 info +
... p4 info +
... p4 client -o test4-win-1 +
...   No change in client detected.
 
P4 Task: establishing connection.
... server: perforce:1666
... node: k02-jenkins
P4: Polling with range: 1180191,now
... p4 changes -m20 //test4-win-1/...@1180191,now +
... p4 repos -C +
P4: Polling on: master with:test4-win-2
Found last change 1180191 on syncID test4-win-2
... p4 client -o test4-win-2 +
... p4 info +
... p4 info +
... p4 client -o test4-win-2 +
...   No change in client detected.
 
P4 Task: establishing connection.
... server: perforce:1666
... node: k02-jenkins
P4: Polling with range: 1180191,now
... p4 changes -m20 //test4-win-2/...@1180191,now +
... p4 repos -C +
Done. Took 0.14 sec
No changes

Perforce Server Error Log

4,1550834520,532931606,2019/02/22 13:22:00 532931606,210535,1,jenkins,test4-win-1,user-repos,10.10.20.103,jenkins.p4-plugin,1.9.6/Linux,-C,error,6,95,Client %27test4-win-1%27 can only be used from host %27k02-bld-win-01%27.
 
4,1550834520,580422337,2019/02/22 13:22:00 580422337,210544,1,jenkins,test4-win-2,user-repos,10.10.20.103,jenkins.p4-plugin,1.9.6/Linux,-C,error,6,95,Client %27test4-win-2%27 can only be used from host %27k02-bld-win-02%27.

As you can see jenkins tries to poll all three workspaces: test4-master (poll: true) + test4-win-1 (poll: false) + test4-win-2 (poll: false) from master.

Cause

WorkflowJob.poll() uses PerforceScm.getKey() to find a polling baseline for workspaces.

PerforceScm.getKey() returns the same SCM key for different workspaces because it doesn't include a workspace name.

Result: WorkflowJob.poll() polls all workspaces with the same SCM key.

PR

I have created a pull request with a possible fix of this problem:

https://github.com/jenkinsci/p4-plugin/pull/95

Please fix this bug.

Thank you

is related to

JENKINS-47553 Pipeline 'poll' option in checkout ignored if using libraries for sync

Reopened

Mykola Ulianytskyi created issue - 2019-02-22 14:09

Karl Wirth made changes - 2019-02-25 10:53

Labels

New: P4_SUPPORT

Karl Wirth made changes - 2019-02-25 10:53

Assignee

New: Karl Wirth [ p4karl ]

Karl Wirth added a comment - 2019-02-25 10:53

Hi lystor, Thanks for highlighting this. I will try to repro it and let you know my findings.

Karl Wirth added a comment - 2019-02-25 10:53 Hi lystor , Thanks for highlighting this. I will try to repro it and let you know my findings.

Karl Wirth added a comment - 2019-02-25 16:58

lystor - Behavior confirmed. Forwarding to development team.

Even though 'poll: false' is set we are still creating a SyncID and polling for the second sync. My test was simpler all on the master:

pipeline {
  agent { label 'master' }
  stages {
    stage("Repro") {
      steps {
        script {
           echo "Starting"

           checkout poll: true, scm: perforce(credential: 'JenkinsMasterAdminUser', populate: autoClean(delete: true, modtime: false, parallel: [enable: false, minbytes: '1024', minfiles: '1', threads: '4'], pin: '', quiet: false, replace: true, tidy: false), workspace: manualSpec(charset: 'none', cleanup: false, name: 'jenkins-${NODE_NAME}-${JOB_NAME}-${EXECUTOR_NUMBER}-sub1', pinHost: false, spec: clientSpec(allwrite: false, backup: true, changeView: '', clobber: true, compress: false, line: 'LOCAL', locked: false, modtime: false, rmdir: false, serverID: '', streamName: '', type: 'WRITABLE', view: '//depot/pipeline_poll_false/sub1/...  //${P4_CLIENT}/...')))

           checkout poll: false, scm: perforce(credential: 'JenkinsMasterAdminUser', populate: autoClean(delete: true, modtime: false, parallel: [enable: false, minbytes: '1024', minfiles: '1', threads: '4'], pin: '', quiet: false, replace: true, tidy: false), workspace: manualSpec(charset: 'none', cleanup: false, name: 'jenkins-${NODE_NAME}-${JOB_NAME}-${EXECUTOR_NUMBER}-sub2', pinHost: false, spec: clientSpec(allwrite: false, backup: true, changeView: '', clobber: true, compress: false, line: 'LOCAL', locked: false, modtime: false, rmdir: false, serverID: '', streamName: '', type: 'WRITABLE', view: '//depot/pipeline_poll_false/sub2/...  //${P4_CLIENT}/...')))

           sh 'echo WS IS $P4_CLIENT'

        }
      }
    }
  }
}

SyncIDs I see are:

Perforce Software Polling Log

Started on Feb 25, 2019 4:51:07 PM
P4: Polling on: master with:jenkins-master-Pipeline_Poll_False_Test2-0
Found last change 246 on syncID jenkins-NODE_NAME-Pipeline_Poll_False_Test2-EXECUTOR_NUMBER
... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0 +
... p4 info +
... p4 info +
... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0 +
...   No change in client detected.

P4 Task: establishing connection.
... server: vm-kwirth-swarm182-xenial:1666
... node: vm-kwirth-swarm182-xenial
P4: Polling with range: 246,now
... p4 changes -m20 //jenkins-master-Pipeline_Poll_False_Test2-0/...@246,now +
... p4 repos -C +
P4: Polling on: master with:jenkins-master-Pipeline_Poll_False_Test2-0-sub1
Found last change 242 on syncID jenkins-NODE_NAME-Pipeline_Poll_False_Test2-EXECUTOR_NUMBER-sub1
... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0-sub1 +
... p4 info +
... p4 info +
... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0-sub1 +
...   No change in client detected.

P4 Task: establishing connection.
... server: vm-kwirth-swarm182-xenial:1666
... node: vm-kwirth-swarm182-xenial
P4: Polling with range: 242,now
... p4 changes -m20 //jenkins-master-Pipeline_Poll_False_Test2-0-sub1/...@242,now +
... p4 repos -C +
P4: Polling on: master with:jenkins-master-Pipeline_Poll_False_Test2-0-sub2
Found last change 247 on syncID jenkins-NODE_NAME-Pipeline_Poll_False_Test2-EXECUTOR_NUMBER-sub2
... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0-sub2 +
... p4 info +
... p4 info +
... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0-sub2 +
...   No change in client detected.

It should not be polling on on syncID "jenkins-NODE_NAME-Pipeline_Poll_False_Test2-EXECUTOR_NUMBER-sub2".

Karl Wirth added a comment - 2019-02-25 16:58 lystor - Behavior confirmed. Forwarding to development team. Even though 'poll: false' is set we are still creating a SyncID and polling for the second sync. My test was simpler all on the master: pipeline { agent { label 'master' } stages { stage( "Repro" ) { steps { script { echo "Starting" checkout poll: true , scm: perforce(credential: 'JenkinsMasterAdminUser' , populate: autoClean(delete: true , modtime: false , parallel: [enable: false , minbytes: '1024' , minfiles: '1' , threads: '4' ], pin: '', quiet: false , replace: true , tidy: false ), workspace: manualSpec(charset: ' none ', cleanup: false , name: ' jenkins-${NODE_NAME}-${JOB_NAME}-${EXECUTOR_NUMBER}-sub1 ', pinHost: false , spec: clientSpec(allwrite: false , backup: true , changeView: ' ', clobber: true , compress: false , line: ' LOCAL ', locked: false , modtime: false , rmdir: false , serverID: ' ', streamName: ' ', type: ' WRITABLE ', view: ' //depot/pipeline_poll_false/sub1/... //${P4_CLIENT}/...'))) checkout poll: false , scm: perforce(credential: 'JenkinsMasterAdminUser' , populate: autoClean(delete: true , modtime: false , parallel: [enable: false , minbytes: '1024' , minfiles: '1' , threads: '4' ], pin: '', quiet: false , replace: true , tidy: false ), workspace: manualSpec(charset: ' none ', cleanup: false , name: ' jenkins-${NODE_NAME}-${JOB_NAME}-${EXECUTOR_NUMBER}-sub2 ', pinHost: false , spec: clientSpec(allwrite: false , backup: true , changeView: ' ', clobber: true , compress: false , line: ' LOCAL ', locked: false , modtime: false , rmdir: false , serverID: ' ', streamName: ' ', type: ' WRITABLE ', view: ' //depot/pipeline_poll_false/sub2/... //${P4_CLIENT}/...'))) sh 'echo WS IS $P4_CLIENT' } } } } } SyncIDs I see are: Perforce Software Polling Log Started on Feb 25, 2019 4:51:07 PM P4: Polling on: master with:jenkins-master-Pipeline_Poll_False_Test2-0 Found last change 246 on syncID jenkins-NODE_NAME-Pipeline_Poll_False_Test2-EXECUTOR_NUMBER ... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0 + ... p4 info + ... p4 info + ... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0 + ... No change in client detected. P4 Task: establishing connection. ... server: vm-kwirth-swarm182-xenial:1666 ... node: vm-kwirth-swarm182-xenial P4: Polling with range: 246,now ... p4 changes -m20 //jenkins-master-Pipeline_Poll_False_Test2-0/...@246,now + ... p4 repos -C + P4: Polling on: master with:jenkins-master-Pipeline_Poll_False_Test2-0-sub1 Found last change 242 on syncID jenkins-NODE_NAME-Pipeline_Poll_False_Test2-EXECUTOR_NUMBER-sub1 ... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0-sub1 + ... p4 info + ... p4 info + ... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0-sub1 + ... No change in client detected. P4 Task: establishing connection. ... server: vm-kwirth-swarm182-xenial:1666 ... node: vm-kwirth-swarm182-xenial P4: Polling with range: 242,now ... p4 changes -m20 //jenkins-master-Pipeline_Poll_False_Test2-0-sub1/...@242,now + ... p4 repos -C + P4: Polling on: master with:jenkins-master-Pipeline_Poll_False_Test2-0-sub2 Found last change 247 on syncID jenkins-NODE_NAME-Pipeline_Poll_False_Test2-EXECUTOR_NUMBER-sub2 ... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0-sub2 + ... p4 info + ... p4 info + ... p4 client -o jenkins-master-Pipeline_Poll_False_Test2-0-sub2 + ... No change in client detected. It should not be polling on on syncID "jenkins-NODE_NAME-Pipeline_Poll_False_Test2-EXECUTOR_NUMBER-sub2".

Karl Wirth made changes - 2019-02-25 16:58

Assignee

Original: Karl Wirth [ p4karl ]

Karl Wirth made changes - 2019-02-25 16:58

Labels

Original: P4_SUPPORT

New: P4_A

Mykola Ulianytskyi made changes - 2019-03-06 09:33

Description

Original: Hello

P4Plugin polls all workspaces used in job even if poll parameter is disabled in checkout.
h2. Steps to reproduce
# Create pipeline job test4 (see below)
# Start pipeline job test4
# See "Perforce Software Polling Log" and Perforce Server Log

{code:java}
pipeline {
    agent(none)

    options {
        ansiColor("xterm")
        buildDiscarder(logRotator(numToKeepStr: "10"))
        disableConcurrentBuilds()
        disableResume()
        skipDefaultCheckout(true)
        timestamps()
    }

    triggers {
        pollSCM("* * * * *")
    }

    stages {
        stage("Master") {
            agent {
                label("master")
            }

            steps {
                checkout perforce(credential: 'perforce-ticket-jenkins', populate: flushOnly(pin: '', quiet: false),
                        workspace: streamSpec(charset: 'none', format: 'test4-master', pinHost: true, streamName: '//playground/jenkins-main'))
            }
        }

        stage("Win-1") {
            agent {
                label("k02-bld-win-01")
            }

            steps {
                checkout changelog: false, poll: false, scm: perforce(credential: 'perforce-ticket-jenkins', populate: flushOnly(pin: '', quiet: false),
                        workspace: streamSpec(charset: 'none', format: 'test4-win-1', pinHost: true, streamName: '//playground/jenkins-main'))
            }
        }

        stage("Win-2") {
            agent {
                label("k02-bld-win-02")
            }

            steps {
                checkout changelog: false, poll: false, scm: perforce(credential: 'perforce-ticket-jenkins', populate: flushOnly(pin: '', quiet: false),
                        workspace: streamSpec(charset: 'none', format: 'test4-win-2', pinHost: true, streamName: '//playground/jenkins-main'))
            }
        }
    }
}
{code}

h2. Perforce Software Polling Log

{code:java}
Started on Feb 22, 2019 3:45:00 PM
P4: Polling on: master with:test4-master
Found last change 1180191 on syncID test4-master
... p4 client -o test4-master +
... p4 info +
... p4 info +
... p4 client -o test4-master +
...   No change in client detected.

P4 Task: establishing connection.
... server: perforce:1666
... node: k02-jenkins
P4: Polling with range: 1180191,now
... p4 changes -m20 //test4-master/...@1180191,now +
... p4 repos -C +
P4: Polling on: master with:test4-win-1
Found last change 1180191 on syncID test4-win-1
... p4 client -o test4-win-1 +
... p4 info +
... p4 info +
... p4 client -o test4-win-1 +
...   No change in client detected.

P4 Task: establishing connection.
... server: perforce:1666
... node: k02-jenkins
P4: Polling with range: 1180191,now
... p4 changes -m20 //test4-win-1/...@1180191,now +
... p4 repos -C +
P4: Polling on: master with:test4-win-2
Found last change 1180191 on syncID test4-win-2
... p4 client -o test4-win-2 +
... p4 info +
... p4 info +
... p4 client -o test4-win-2 +
...   No change in client detected.

P4 Task: establishing connection.
... server: perforce:1666
... node: k02-jenkins
P4: Polling with range: 1180191,now
... p4 changes -m20 //test4-win-2/...@1180191,now +
... p4 repos -C +
Done. Took 0.14 sec
No changes
{code}

h2. Perforce Server Error Log
{code:java}
4,1550834520,532931606,2019/02/22 13:22:00 532931606,210535,1,jenkins,test4-win-1,user-repos,10.10.20.103,jenkins.p4-plugin,1.9.6/Linux,-C,error,6,95,Client %27test4-win-1%27 can only be used from host %27k02-bld-win-01%27.

4,1550834520,580422337,2019/02/22 13:22:00 580422337,210544,1,jenkins,test4-win-2,user-repos,10.10.20.103,jenkins.p4-plugin,1.9.6/Linux,-C,error,6,95,Client %27test4-win-2%27 can only be used from host %27k02-bld-win-02%27.

{code}

As you can see jenkins tries to poll all three workspaces: *test4-master* (poll: true) + *test4-win-1* (poll: false) + *test4-win-2* (poll: false) from master.

Please fix this bug.

Thank you

New: Hello

P4Plugin polls all workspaces used in job even if poll parameter is disabled in checkout.
h2. Steps to reproduce
# Create pipeline job test4 (see below)
# Start pipeline job test4
# See "Perforce Software Polling Log" and Perforce Server Log

{code:java}
pipeline {
    agent(none)

    options {
        ansiColor("xterm")
        buildDiscarder(logRotator(numToKeepStr: "10"))
        disableConcurrentBuilds()
        disableResume()
        skipDefaultCheckout(true)
        timestamps()
    }

    triggers {
        pollSCM("* * * * *")
    }

    stages {
        stage("Master") {
            agent {
                label("master")
            }

            steps {
                checkout perforce(credential: 'perforce-ticket-jenkins', populate: flushOnly(pin: '', quiet: false),
                        workspace: streamSpec(charset: 'none', format: 'test4-master', pinHost: true, streamName: '//playground/jenkins-main'))
            }
        }

        stage("Win-1") {
            agent {
                label("k02-bld-win-01")
            }

            steps {
                checkout changelog: false, poll: false, scm: perforce(credential: 'perforce-ticket-jenkins', populate: flushOnly(pin: '', quiet: false),
                        workspace: streamSpec(charset: 'none', format: 'test4-win-1', pinHost: true, streamName: '//playground/jenkins-main'))
            }
        }

        stage("Win-2") {
            agent {
                label("k02-bld-win-02")
            }

            steps {
                checkout changelog: false, poll: false, scm: perforce(credential: 'perforce-ticket-jenkins', populate: flushOnly(pin: '', quiet: false),
                        workspace: streamSpec(charset: 'none', format: 'test4-win-2', pinHost: true, streamName: '//playground/jenkins-main'))
            }
        }
    }
}
{code}

h2. Perforce Software Polling Log

{code:java}
Started on Feb 22, 2019 3:45:00 PM
P4: Polling on: master with:test4-master
Found last change 1180191 on syncID test4-master
... p4 client -o test4-master +
... p4 info +
... p4 info +
... p4 client -o test4-master +
...   No change in client detected.

P4 Task: establishing connection.
... server: perforce:1666
... node: k02-jenkins
P4: Polling with range: 1180191,now
... p4 changes -m20 //test4-master/...@1180191,now +
... p4 repos -C +
P4: Polling on: master with:test4-win-1
Found last change 1180191 on syncID test4-win-1
... p4 client -o test4-win-1 +
... p4 info +
... p4 info +
... p4 client -o test4-win-1 +
...   No change in client detected.

P4 Task: establishing connection.
... server: perforce:1666
... node: k02-jenkins
P4: Polling with range: 1180191,now
... p4 changes -m20 //test4-win-1/...@1180191,now +
... p4 repos -C +
P4: Polling on: master with:test4-win-2
Found last change 1180191 on syncID test4-win-2
... p4 client -o test4-win-2 +
... p4 info +
... p4 info +
... p4 client -o test4-win-2 +
...   No change in client detected.

P4 Task: establishing connection.
... server: perforce:1666
... node: k02-jenkins
P4: Polling with range: 1180191,now
... p4 changes -m20 //test4-win-2/...@1180191,now +
... p4 repos -C +
Done. Took 0.14 sec
No changes
{code}

h2. Perforce Server Error Log
{code:java}
4,1550834520,532931606,2019/02/22 13:22:00 532931606,210535,1,jenkins,test4-win-1,user-repos,10.10.20.103,jenkins.p4-plugin,1.9.6/Linux,-C,error,6,95,Client %27test4-win-1%27 can only be used from host %27k02-bld-win-01%27.

4,1550834520,580422337,2019/02/22 13:22:00 580422337,210544,1,jenkins,test4-win-2,user-repos,10.10.20.103,jenkins.p4-plugin,1.9.6/Linux,-C,error,6,95,Client %27test4-win-2%27 can only be used from host %27k02-bld-win-02%27.

{code}

As you can see jenkins tries to poll all three workspaces: *test4-master* (poll: true) + *test4-win-1* (poll: false) + *test4-win-2* (poll: false) from master.

h2. Cause

WorkflowJob.poll() uses PerforceScm.getKey() to find a polling baseline for workspaces.

PerforceScm.getKey() returns the same SCM key for different workspaces because it doesn't include a workspace name.

Result: WorkflowJob.poll() polls all workspaces with the same SCM key.
h2. PR

I have created a pull request with a possible fix of this problem:

https://github.com/jenkinsci/p4-plugin/pull/95

Please fix this bug.

Thank you

Karl Wirth made changes - 2019-04-04 14:00

Labels

Original: P4_A

New: P4_B

Paul Allen made changes - 2019-06-04 14:08

Assignee

New: Charusheela Bopardikar [ cbopardikar ]

Assignee:: Charusheela Bopardikar

Reporter:: Mykola Ulianytskyi

Votes:: 4 Vote for this issue

Watchers:: 12 Start watching this issue

Created:: 2019-02-22 14:09

Updated:: 2021-01-21 08:09

Jenkins

Details

Description

Steps to reproduce

Perforce Software Polling Log

Perforce Server Error Log

Cause

PR

Attachments

Issue Links

Activity

Collapse comment: Karl Wirth added a comment - 2019-02-25 10:53

Expand comment: Karl Wirth added a comment - 2019-02-25 10:53

Collapse comment: Karl Wirth added a comment - 2019-02-25 16:58

Expand comment: Karl Wirth added a comment - 2019-02-25 16:58

People

Dates