• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • Jenkins ver. 2.150.3
      GitHub Branch Source Plugin 2.4.2

      I have a GitHub Organisation configured and it is operating fairly satisfactorily.  It finds PRs when they are opened and builds them, and so on, quite successfully.

      But every now and then it will build not only the PR but also the branch that the PR is on, adding a continuous-integration/jenkins/branch commit status to the PR.

      This is wasteful in the least a can be confusing to the PR submitters about why they have this strange new commit status occasionally.

      I suppose this could happen legitimately if there is latency between pushing to a new branch on GitHub and opening the PR for it.  Is there any delay on building new branches to account for this sort of behaviour?  If not, perhaps there should be?

          [JENKINS-56255] occasionally builds the branch for a PR also

          Brian J Murrell created issue -

          The other possibility for this issue is to have a whiltelist filter of branches to build and ignore the rest assuming they will eventually become a PR.

          Brian J Murrell added a comment - The other possibility for this issue is to have a whiltelist filter of branches to build and ignore the rest assuming they will eventually become a PR.

          Any response here?  Having the branch build for PRs that are opened within a very small number of seconds of pushing the branch is quite annoying at best and frequently confusing for users who don't understand the workings of the github-branch-source-plugin.

          Brian J Murrell added a comment - Any response here?  Having the branch build for PRs that are opened within a very small number of seconds of pushing the branch is quite annoying at best and frequently confusing for users who don't understand the workings of the github-branch-source-plugin.

          This is starting to happen more frequently and is wreaking havoc in our CI system.  Users are constantly confused about failed continuous-integration/jenkins/branch commit statuses in their GitHub PRs and some of these branch builds are overwriting statuses of the PR build.

           I wonder why there hasn't been any response to my queries about this bug.  Have I done something wrong in the way I filed this issue in so much as it's being ignored?

          Brian J Murrell added a comment - This is starting to happen more frequently and is wreaking havoc in our CI system.  Users are constantly confused about failed  continuous-integration/jenkins/branch commit statuses in their GitHub PRs and some of these branch builds are overwriting statuses of the PR build.  I wonder why there hasn't been any response to my queries about this bug.  Have I done something wrong in the way I filed this issue in so much as it's being ignored?
          Brian J Murrell made changes -
          Priority Original: Major [ 3 ] New: Critical [ 2 ]

          Liam Newman added a comment -

          brianjmurrell
          No, you haven't done anything wrong. Just not enough resources.
          I understand your frustration. Is there any pattern to when this happens?

          My guess is this is a race condition related to scanning, but we'll see.

          What is the config for your multibranch pipeline?

          Liam Newman added a comment - brianjmurrell No, you haven't done anything wrong. Just not enough resources. I understand your frustration. Is there any pattern to when this happens? My guess is this is a race condition related to scanning, but we'll see. What is the config for your multibranch pipeline?

          bitwiseman

          Is there any pattern to when this happens?

          I have not been able to determine any pattern, no.

          My guess is this is a race condition related to scanning, but we'll see.

          Indeed, that is my guess also.  Can you describe the algorithm that the plugin is using to decide when a branch is not a branch but is a PR?

          What is the config for your multibranch pipeline?

           What is the best way to convey that to you?

          Brian J Murrell added a comment - bitwiseman Is there any pattern to when this happens? I have not been able to determine any pattern, no. My guess is this is a race condition related to scanning, but we'll see. Indeed, that is my guess also.  Can you describe the algorithm that the plugin is using to decide when a branch is not a branch but is a PR? What is the config for your multibranch pipeline?  What is the best way to convey that to you?

          Liam Newman added a comment -

          brianjmurrell
          If you want to take a screenshot or attach a copy of your config.xml, either of those would be good.

          Liam Newman added a comment - brianjmurrell If you want to take a screenshot or attach a copy of your config.xml, either of those would be good.
          Brian J Murrell made changes -
          Attachment New: image-2019-06-28-07-49-51-334.png [ 47813 ]

          Hopefully this is what you are looking for:

          Brian J Murrell added a comment - Hopefully this is what you are looking for:

            Unassigned Unassigned
            brianjmurrell Brian J Murrell
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: