• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Component/s: pipeline-model-definition-plugin
• Labels:

  None
• Environment:

  Fresh Jenkins LTS 2.150.3 install
  'recommended' plugins, including [Pipeline: Declarative Plugin|https://plugins.jenkins.io/pipeline-model-definition] version 1.3.6

1. 

   pipeline__Jenkins__and_Mozilla_Firefox.png

   100 kB

   2019-03-19 15:55

2. 

   test.png

   48 kB

   2019-03-13 13:34

3. log

   2 kB

   2019-03-13 13:34

4. Jenkinsfile

   2 kB

   2019-03-13 13:34

[JENKINS-56544] failFast option for parallel stages sets build status to ABORTED when failure is inside of a stage with an agent

Ray Kivisto created issue - 2019-03-13 13:37

Ray Kivisto made changes - 2019-03-13 13:38

Environment

New: Fresh Jenkins LTS 2.150.3 install 'recommended' plugins, including [Pipeline: Declarative Plugin|https://plugins.jenkins.io/pipeline-model-definition] version 1.3.6

Devin Nusbaum made changes - 2019-03-19 13:36

Assignee

Original: Andrew Bayer [ abayer ]

New: Devin Nusbaum [ dnusbaum ]

Devin Nusbaum made changes - 2019-03-19 13:36

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Ray Kivisto made changes - 2019-03-19 15:55

Attachment

New: pipeline__Jenkins__and_Mozilla_Firefox.png [ 46518 ]

Devin Nusbaum made changes - 2019-03-19 21:52

Remote Link

New: This issue links to "jenkinsci/pipeline-model-definition-plugin#322 (Web Link)" [ 22511 ]

Devin Nusbaum made changes - 2019-03-19 21:52

Summary

Original: failFast option for parallel stages sets build status to ABORTED when failure is inside of a nested parallel stage

New: failFast option for parallel stages sets build status to ABORTED when failure is inside of a stage with an agent

Devin Nusbaum made changes - 2019-03-19 21:53

Description

Original: h3. Symptom With a Pipeline using parallel stages with {{failFast true}} enabled, when a nested stage fails, the final build result is showing as {{ABORTED}} instead of {{FAILURE}} A similar bug was recently fixed JENKINS-55459 which corrected the build status result when using non-nested parallel stages with {{failFast true}} enabled, but it seems it did not catch the case where a nested stage inside of one of the parallel stages fails. h3. Evidence The fix for JENKINS-55459 was delivered under version 1.3.5 of the [Pipeline: Declarative Plugin|https://plugins.jenkins.io/pipeline-model-definition], I am testing version 1.3.6. I started up a brand new Jenkins LTS 2.150.3 instance, with the 'recommended' plugins, including [Pipeline: Declarative Plugin|https://plugins.jenkins.io/pipeline-model-definition] version 1.3.6 I ran the testcase inside of JENKINS-55459 and the build status is correctly marked as failed, so the fix from JENKINS-55459 was correct. When I run the attached [^Jenkinsfile] , the build still shows as {{ABORTED}}: !test.png! {code} ... ERROR: script returned exit code 1 Finished: ABORTED {code} Here is the full log: [^log] I expected the build status to be marked as {{FAILURE}}, not {{ABORTED}}. h3. Hypothesis I believe the fix from JENKINS-55459 worked, but does not account for failures inside of nested stages within the parallel stages.

New: h3. Symptom With a Pipeline using parallel stages with {{failFast true}} enabled, when a stage with an agent fails, the final build result is showing as {{ABORTED}} instead of {{FAILURE}} A similar bug was recently fixed JENKINS-55459 which corrected the build status result when using non-nested parallel stages with {{failFast true}} enabled, but it seems it did not catch the case where a nested stage inside of one of the parallel stages fails. h3. Evidence The fix for JENKINS-55459 was delivered under version 1.3.5 of the [Pipeline: Declarative Plugin|https://plugins.jenkins.io/pipeline-model-definition], I am testing version 1.3.6. I started up a brand new Jenkins LTS 2.150.3 instance, with the 'recommended' plugins, including [Pipeline: Declarative Plugin|https://plugins.jenkins.io/pipeline-model-definition] version 1.3.6 I ran the testcase inside of JENKINS-55459 and the build status is correctly marked as failed, so the fix from JENKINS-55459 was correct. When I run the attached [^Jenkinsfile] , the build still shows as {{ABORTED}}: !test.png! {code} ... ERROR: script returned exit code 1 Finished: ABORTED {code} Here is the full log: [^log] I expected the build status to be marked as {{FAILURE}}, not {{ABORTED}}. h3. Hypothesis I believe the fix from JENKINS-55459 worked, but does not account for failures inside of stages with agents within the parallel stages.

Devin Nusbaum made changes - 2019-03-19 21:53

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Devin Nusbaum made changes - 2019-03-19 21:54

Link

New: This issue relates to JENKINS-55459 [ JENKINS-55459 ]

Andrew Bayer made changes - 2019-03-20 15:23

Resolution		New: Fixed [ 1 ]
Status	Original: In Review [ 10005 ]	New: Fixed but Unreleased [ 10203 ]

Load more newer history items