-
Improvement
-
Resolution: Unresolved
-
Minor
Using the default RFC_2109 cookie handling from httpclient results in logs full of this warning.
Mar 22, 2019 7:46:25 AM stashpullrequestbuilder.stashpullrequestbuilder.StashRepository getTargetPullRequests INFO: Fetch PullRequests (dashboard-tf-release). Mar 22, 2019 7:46:25 AM org.apache.commons.httpclient.HttpMethodBase processCookieHeaders WARNING: Cookie rejected: "$Version=0; crowd.token_key=**; $Path=/; $Domain=domain.com". Domain attribute "domain.com" violates RFC 2109: domain must start with a dot
something like this in stashapiclient should work
httpGet.getParams().setParameter(ClientPNames.COOKIE_POLICY, CookiePolicy.BROWSER_COMPATIBILITY);
[JENKINS-56685] Stash Pullrequest Builder modify cookie handling
Environment | Original: Jenkins 2.163 stash-pullrequest-builder@1.7.0 | New: Jenkins 2.163 stash-pullrequest-builder@1.7.0 stash-pullrequest-builder@1.8.0 |