Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-56685

Stash Pullrequest Builder modify cookie handling

    XMLWordPrintable

Details

    Description

      Using the default RFC_2109 cookie handling from httpclient results in logs full of this warning.

      Mar 22, 2019 7:46:25 AM stashpullrequestbuilder.stashpullrequestbuilder.StashRepository getTargetPullRequests
      INFO: Fetch PullRequests (dashboard-tf-release).
      Mar 22, 2019 7:46:25 AM org.apache.commons.httpclient.HttpMethodBase processCookieHeaders
      WARNING: Cookie rejected: "$Version=0; crowd.token_key=**; $Path=/; $Domain=domain.com". Domain attribute "domain.com" violates RFC 2109: domain must start with a dot 

      something like this in stashapiclient should work

      httpGet.getParams().setParameter(ClientPNames.COOKIE_POLICY, CookiePolicy.BROWSER_COMPATIBILITY);
      

      Attachments

        Activity

          bran2k7 Brandon Johnson created issue -
          bran2k7 Brandon Johnson made changes -
          Field Original Value New Value
          Environment Jenkins 2.163 stash-pullrequest-builder@1.7.0 Jenkins 2.163 stash-pullrequest-builder@1.7.0 stash-pullrequest-builder@1.8.0

          People

            jbochenski Jakub Bochenski
            bran2k7 Brandon Johnson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: