[JENKINS-56885] It is possible to save a Node without host configuration

Type: Bug
Resolution: Fixed
Priority: Major
Component/s: core, ssh-plugin, ssh-slaves-plugin, trilead-api-plugin
Labels:
- jenkins
- ssh-slave
Environment:
org.jenkins-ci.main:jenkins-war:2.170
org.jenkins-ci:crypto-util:1.1
org.jenkins-ci.modules:sshd:2.6
org.kohsuke:trilead-putty-extension:1.2
org.jenkins-ci.modules:ssh-cli-auth:1.5
org.jenkins-ci.plugins:ssh-slaves:1.29.4

Similar Issues:
Powered by SuggestiMate

Show
Released As:
ssh-slaves-1.30.0

If you do not set the host field in the Node configuration it is possible to save it, then when it tries to connect fails with an NPE

Agent connection log

ERROR: Unexpected error in launching a agent. This is probably a bug in Jenkins.
java.lang.NullPointerException
at com.trilead.ssh2.KnownHosts.hostnameMatches(KnownHosts.java:313)
at com.trilead.ssh2.KnownHosts.getAllKnownHostEntries(KnownHosts.java:260)
at com.trilead.ssh2.KnownHosts.recommendHostkeyAlgorithms(KnownHosts.java:504)
at com.trilead.ssh2.KnownHosts.getPreferredServerHostkeyAlgorithmOrder(KnownHosts.java:282)
at hudson.plugins.sshslaves.verifiers.KnownHostsFileKeyVerificationStrategy.getPreferredKeyAlgorithms(KnownHostsFileKeyVerificationStrategy.java:92)
at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:837)
at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:833)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
 [04/04/19 15:40:41] Launch failed - cleaning up connection

Config.xml

<?xml version='1.1' encoding='UTF-8'?>
<slave>
   <name>agentNullHost</name>
   <description>agent description</description>
   <remoteFS>/home/jenkins</remoteFS>
   <numExecutors>1</numExecutors>
   <mode>NORMAL</mode>
   <retentionStrategy class="hudson.slaves.RetentionStrategy$Always"/>
    <launcher class="hudson.plugins.sshslaves.SSHLauncher" plugin="ssh-slaves@1.29.4">
       <port>22</port>
       <credentialsId>my-credentials</credentialsId>
       <launchTimeoutSeconds>210</launchTimeoutSeconds>
       <maxNumRetries>10</maxNumRetries>
       <retryWaitTime>15</retryWaitTime>
       <sshHostKeyVerificationStrategy class="hudson.plugins.sshslaves.verifiers.NonVerifyingKeyVerificationStrategy"/>
       <tcpNoDelay>true</tcpNoDelay>
  </launcher>
  <label>linux</label>
  <nodeProperties/>
</slave>

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Screenshot from 2019-04-08 16-45-27.png
19 kB
2019-04-08 14:45
Screenshot 2019-04-07 at 14.41.35.png
172 kB
2019-04-07 13:19
Screenshot 2019-04-07 at 14.41.02.png
58 kB
2019-04-07 13:19
Screenshot from 2019-04-05 13-00-24.png
21 kB
2019-04-05 11:01

links to

Hao Maio created issue - 2019-04-04 13:54

Ivan Fernandez Calvo added a comment - 2019-04-04 14:31

It is weird this is tested on the unit test and does not fail, and I have a bunch of agent in both ways configured, Did it happens after an upgrade? if so Did you restarted Jenkins to get the new plugin?
Could you attach the JENKINS_HOME/nodes/NODE_NAME/config.xml?

Ivan Fernandez Calvo added a comment - 2019-04-04 14:31 It is weird this is tested on the unit test and does not fail, and I have a bunch of agent in both ways configured, Did it happens after an upgrade? if so Did you restarted Jenkins to get the new plugin? Could you attach the JENKINS_HOME/nodes/NODE_NAME/config.xml?

Hao Maio made changes - 2019-04-05 08:21

Description

New: 1)
| |Host Key Verification Strategy| Known hosts for Verification Strategy|

ERROR: Unexpected error in launching a agent. This is probably a bug in Jenkins.
java.lang.NullPointerException
at com.trilead.ssh2.KnownHosts.hostnameMatches(KnownHosts.java:313)
at com.trilead.ssh2.KnownHosts.getAllKnownHostEntries(KnownHosts.java:260)
at com.trilead.ssh2.KnownHosts.recommendHostkeyAlgorithms(KnownHosts.java:504)
at com.trilead.ssh2.KnownHosts.getPreferredServerHostkeyAlgorithmOrder(KnownHosts.java:282)
at hudson.plugins.sshslaves.verifiers.KnownHostsFileKeyVerificationStrategy.getPreferredKeyAlgorithms(KnownHostsFileKeyVerificationStrategy.java:92)
at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:837)
at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:833)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[04/04/19 15:40:41] Launch failed - cleaning up connection

2)
| |Host Key Verification Strategy| Non verifying Verification Strategy|

[SSH] Opening SSH connection to null:22.

EDIT 05-04-2019

-----------------------------

*Config.xml*

<?xml version='1.1' encoding='UTF-8'?>
<slave>
   <name>slave01</name>
   <description>Slave for building and packaging (the delivery)</description>
   <remoteFS>/home/userName/jenkins_slave_node</remoteFS>
   <numExecutors>1</numExecutors>
   <mode>NORMAL</mode>
   <retentionStrategy class="hudson.slaves.RetentionStrategy$Always"/>
    <launcher class="hudson.plugins.sshslaves.SSHLauncher" plugin="ssh-slaves@1.29.4">
       <port>22</port>
       <credentialsId>xxxxxxxx-xxxx-xxxx-8dd0-f9d5a90c058d</credentialsId>
   <launchTimeoutSeconds>210</launchTimeoutSeconds>
       <maxNumRetries>10</maxNumRetries>
   <retryWaitTime>15</retryWaitTime>
       <sshHostKeyVerificationStrategy class="hudson.plugins.sshslaves.verifiers.NonVerifyingKeyVerificationStrategy"/>
   <tcpNoDelay>true</tcpNoDelay>
</launcher>
<label>deliver packaging customer_release</label>
<nodeProperties/>
</slave>

Hao Maio added a comment - 2019-04-05 08:23

ifernandezcalvo : I added the config.xml, and yes jenkins had been restarted, before trying to launch the node.

Hao Maio added a comment - 2019-04-05 08:23 ifernandezcalvo : I added the config.xml, and yes jenkins had been restarted, before trying to launch the node.

Ivan Fernandez Calvo added a comment - 2019-04-05 08:45

Your configuration does not have a host, I dunno why, it is not correct. If you edit the configuration from the UI there is no way to save it without a host, so try saving it correctly.

<?xml version='1.1' encoding='UTF-8'?>
<slave>
  <name>test-agent</name>
  <description>test JENKINS-56885</description>
  <remoteFS>/home/jenkins</remoteFS>
  <numExecutors>1</numExecutors>
  <mode>NORMAL</mode>
  <retentionStrategy class="hudson.slaves.RetentionStrategy$Always"/>
  <launcher class="hudson.plugins.sshslaves.SSHLauncher" plugin="ssh-slaves@1.29.4">
    <host>192.168.1.125</host> <!-- YOUR CONFIGURATION DOES NOT HAVE HOST -->
    <port>22</port>
    <credentialsId>25a7cd49-5d24-454f-aef4-fc14bbf89ab1</credentialsId>
    <launchTimeoutSeconds>210</launchTimeoutSeconds>
    <maxNumRetries>10</maxNumRetries>
    <retryWaitTime>15</retryWaitTime>
    <sshHostKeyVerificationStrategy class="hudson.plugins.sshslaves.verifiers.ManuallyTrustedKeyVerificationStrategy">
      <requireInitialManualTrust>false</requireInitialManualTrust>
    </sshHostKeyVerificationStrategy>
    <tcpNoDelay>true</tcpNoDelay>
  </launcher>
  <label>local-test</label>
  <nodeProperties/>
</slave>

Ivan Fernandez Calvo added a comment - 2019-04-05 08:45 Your configuration does not have a host, I dunno why, it is not correct. If you edit the configuration from the UI there is no way to save it without a host, so try saving it correctly. <?xml version= '1.1' encoding= 'UTF-8' ?> <slave> <name>test-agent</name> <description>test JENKINS-56885</description> <remoteFS>/home/jenkins</remoteFS> <numExecutors>1</numExecutors> <mode>NORMAL</mode> <retentionStrategy class= "hudson.slaves.RetentionStrategy$Always" /> <launcher class= "hudson.plugins.sshslaves.SSHLauncher" plugin= "ssh-slaves@1.29.4" > <host>192.168.1.125</host>  <port>22</port> <credentialsId>25a7cd49-5d24-454f-aef4-fc14bbf89ab1</credentialsId> <launchTimeoutSeconds>210</launchTimeoutSeconds> <maxNumRetries>10</maxNumRetries> <retryWaitTime>15</retryWaitTime> <sshHostKeyVerificationStrategy class= "hudson.plugins.sshslaves.verifiers.ManuallyTrustedKeyVerificationStrategy" > <requireInitialManualTrust> false </requireInitialManualTrust> </sshHostKeyVerificationStrategy> <tcpNoDelay> true </tcpNoDelay> </launcher> <label>local-test</label> <nodeProperties/> </slave>

Hao Maio made changes - 2019-04-05 11:01

Attachment

New: Screenshot from 2019-04-05 13-00-24.png [ 46641 ]

Hao Maio added a comment - 2019-04-05 11:06

I did saved it over the GUI, but havent entered any host. It was the only enter field without any question mark icon. I havent even realized that it exists ... So, you enter there the host ip of the master ?

Hao Maio added a comment - 2019-04-05 11:06 I did saved it over the GUI, but havent entered any host. It was the only enter field without any question mark icon. I havent even realized that it exists ... So, you enter there the host ip of the master ?

Ivan Fernandez Calvo made changes - 2019-04-05 14:16

Summary

Original: hostnameMatches -> NullPointerException

New: It is possible to save a Node without host configuration

Ivan Fernandez Calvo added a comment - 2019-04-05 14:18

you have to put there the DNS name or IP of the machine you want to use as Agent, it should not be the master name or IP because you already have some executors on the master configured by default thus put the master as Agent does not have any sense.

Ivan Fernandez Calvo added a comment - 2019-04-05 14:18 you have to put there the DNS name or IP of the machine you want to use as Agent, it should not be the master name or IP because you already have some executors on the master configured by default thus put the master as Agent does not have any sense.

Ivan Fernandez Calvo made changes - 2019-04-05 14:24

Description

Original: 1)
| |Host Key Verification Strategy| Known hosts for Verification Strategy|

ERROR: Unexpected error in launching a agent. This is probably a bug in Jenkins.
java.lang.NullPointerException
at com.trilead.ssh2.KnownHosts.hostnameMatches(KnownHosts.java:313)
at com.trilead.ssh2.KnownHosts.getAllKnownHostEntries(KnownHosts.java:260)
at com.trilead.ssh2.KnownHosts.recommendHostkeyAlgorithms(KnownHosts.java:504)
at com.trilead.ssh2.KnownHosts.getPreferredServerHostkeyAlgorithmOrder(KnownHosts.java:282)
at hudson.plugins.sshslaves.verifiers.KnownHostsFileKeyVerificationStrategy.getPreferredKeyAlgorithms(KnownHostsFileKeyVerificationStrategy.java:92)
at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:837)
at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:833)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[04/04/19 15:40:41] Launch failed - cleaning up connection

2)
| |Host Key Verification Strategy| Non verifying Verification Strategy|

[SSH] Opening SSH connection to null:22.

EDIT 05-04-2019

-----------------------------

*Config.xml*

<?xml version='1.1' encoding='UTF-8'?>
<slave>
   <name>slave01</name>
   <description>Slave for building and packaging (the delivery)</description>
   <remoteFS>/home/userName/jenkins_slave_node</remoteFS>
   <numExecutors>1</numExecutors>
   <mode>NORMAL</mode>
   <retentionStrategy class="hudson.slaves.RetentionStrategy$Always"/>
    <launcher class="hudson.plugins.sshslaves.SSHLauncher" plugin="ssh-slaves@1.29.4">
       <port>22</port>
       <credentialsId>xxxxxxxx-xxxx-xxxx-8dd0-f9d5a90c058d</credentialsId>
   <launchTimeoutSeconds>210</launchTimeoutSeconds>
       <maxNumRetries>10</maxNumRetries>
   <retryWaitTime>15</retryWaitTime>
       <sshHostKeyVerificationStrategy class="hudson.plugins.sshslaves.verifiers.NonVerifyingKeyVerificationStrategy"/>
   <tcpNoDelay>true</tcpNoDelay>
</launcher>
<label>deliver packaging customer_release</label>
<nodeProperties/>
</slave>

New: If you do not set the host field in the Node configuration it is possible to save it, then when it tries to connect fails with an NPE

!Screenshot from 2019-04-05 13-00-24.png!

Agent connection log

{code}
ERROR: Unexpected error in launching a agent. This is probably a bug in Jenkins.
java.lang.NullPointerException
at com.trilead.ssh2.KnownHosts.hostnameMatches(KnownHosts.java:313)
at com.trilead.ssh2.KnownHosts.getAllKnownHostEntries(KnownHosts.java:260)
at com.trilead.ssh2.KnownHosts.recommendHostkeyAlgorithms(KnownHosts.java:504)
at com.trilead.ssh2.KnownHosts.getPreferredServerHostkeyAlgorithmOrder(KnownHosts.java:282)
at hudson.plugins.sshslaves.verifiers.KnownHostsFileKeyVerificationStrategy.getPreferredKeyAlgorithms(KnownHostsFileKeyVerificationStrategy.java:92)
at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:837)
at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:833)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[04/04/19 15:40:41] Launch failed - cleaning up connection
{code}

*Config.xml*

{code}
<?xml version='1.1' encoding='UTF-8'?>
<slave>
   <name>agentNullHost</name>
   <description>agent description</description>
   <remoteFS>/home/jenkins</remoteFS>
   <numExecutors>1</numExecutors>
   <mode>NORMAL</mode>
   <retentionStrategy class="hudson.slaves.RetentionStrategy$Always"/>
    <launcher class="hudson.plugins.sshslaves.SSHLauncher" plugin="ssh-slaves@1.29.4">
       <port>22</port>
       <credentialsId>my-credentials</credentialsId>
   <launchTimeoutSeconds>210</launchTimeoutSeconds>
       <maxNumRetries>10</maxNumRetries>
   <retryWaitTime>15</retryWaitTime>
       <sshHostKeyVerificationStrategy class="hudson.plugins.sshslaves.verifiers.NonVerifyingKeyVerificationStrategy"/>
   <tcpNoDelay>true</tcpNoDelay>
</launcher>
<label>linux</label>
<nodeProperties/>
</slave>
{code}

Assignee:: Ivan Fernandez Calvo

Reporter:: Hao Maio

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 2019-04-04 13:54

Updated:: 2020-02-01 17:08

Resolved:: 2019-04-16 08:41

Jenkins

Details

Description

Attachments

Attachments

Issue Links

Activity

Collapse comment: Ivan Fernandez Calvo added a comment - 2019-04-04 14:31

Expand comment: Ivan Fernandez Calvo added a comment - 2019-04-04 14:31

Collapse comment: Hao Maio added a comment - 2019-04-05 08:23

Expand comment: Hao Maio added a comment - 2019-04-05 08:23

Collapse comment: Ivan Fernandez Calvo added a comment - 2019-04-05 08:45

Expand comment: Ivan Fernandez Calvo added a comment - 2019-04-05 08:45

Collapse comment: Hao Maio added a comment - 2019-04-05 11:06

Expand comment: Hao Maio added a comment - 2019-04-05 11:06

Collapse comment: Ivan Fernandez Calvo added a comment - 2019-04-05 14:18

Expand comment: Ivan Fernandez Calvo added a comment - 2019-04-05 14:18

People

Dates