-
Bug
-
Resolution: Unresolved
-
Major
-
None
-
Hudson 1.343, using email-ext plugin
I suppose this is compatibility problem with the plugin email-ext.
What occurs is the following :
Mail title : 5 » promotion » Promo1 - Build # 5 - Building!
Mail body : 5 » promotion » Promo1 5
email-ext config title : $DEFAULT_SUBJECT
emain-ext config body : $PROJECT_NAME $BUILD_NUMBER
I tried to set a variable like you did with PROMOTED_URL using the following but I failed (Indeed, PROMOTED_URL is not resolved)
In Promotion.java:67
<code>
@Override
public EnvVars getEnvironment(TaskListener listener) throws IOException, InterruptedException
</code>
[JENKINS-5692] Manual promotion : Bad build number and project name in ext-email
tdutreui
created issue -
damickjj
made changes -
| Attachment | New: promoted_builds.patch [ 19412 ] |
I would add my vote for applying patch proposed by damickjj.
I use it in my environment. In addition to this patch, I also removed PROMOTED_URL variable from environment, as it will be exposed as PROMOTED_BUILD_URL variable. Though it breaks backward compatibility, so it is up to you to decide on this.
My changes are available at https://github.com/svd/hudson-promoted-builds/commits/promotion-env
svd
added a comment - - edited I would add my vote for applying patch proposed by damickjj.
I use it in my environment. In addition to this patch, I also removed PROMOTED_URL variable from environment, as it will be exposed as PROMOTED_BUILD_URL variable. Though it breaks backward compatibility, so it is up to you to decide on this.
My changes are available at https://github.com/svd/hudson-promoted-builds/commits/promotion-env 
Peter Hayes
added a comment - I didn't notice this issue until I committed similar changes into the plugin. I did something similar except that I focused only on passing through the promoted builds parameters, not the entire build environment. Here's my commit:
https://github.com/jenkinsci/promoted-builds-plugin/commit/fa28c7807f88f9ec8ca9e691e24fa796ee90f6df
Will that meet your needs or do you need the entire environment? I can't tell from this issue what variables you are trying to access.
Peter Hayes
added a comment - I didn't notice this issue until I committed similar changes into the plugin. I did something similar except that I focused only on passing through the promoted builds parameters, not the entire build environment. Here's my commit:
https://github.com/jenkinsci/promoted-builds-plugin/commit/fa28c7807f88f9ec8ca9e691e24fa796ee90f6df
Will that meet your needs or do you need the entire environment? I can't tell from this issue what variables you are trying to access. Peter Hayes
made changes -
| Assignee | New: Peter Hayes [ petehayes ] |
damickjj
added a comment - Mainly using:
JOB_NAME
SVN_REVISION
BUILD_NUMBER
BUILD_ID
BUILD_URL
and other environment variables defined for that job.
I want to make sure these are from the build, not the promotion job which is why i added the namespace "PROMOTED_" since the build url was link to the promotion, not the actual build. But it's been a while, maybe this works right now?
damickjj
added a comment - Mainly using:
JOB_NAME
SVN_REVISION
BUILD_NUMBER
BUILD_ID
BUILD_URL
and other environment variables defined for that job.
I want to make sure these are from the build, not the promotion job which is why i added the namespace "PROMOTED_" since the build url was link to the promotion, not the actual build. But it's been a while, maybe this works right now? svd
added a comment - Making build parameters available is another great idea! I like both.
Like damickjj mentioned, various environment variables may be needed for some people, while others may need parameter values.
svd
added a comment - Making build parameters available is another great idea! I like both.
Like damickjj mentioned, various environment variables may be needed for some people, while others may need parameter values. Peter Hayes
added a comment - PROMOTED_URL has been there and then I also added PROMOTED_JOB_NAME and PROMOTED_NUMBER. I just added BUILD_ID. Is SVN_REVISION the revision of the build being promoted or is it the revision of the workspace at the time the build is promoted?
Peter Hayes
added a comment - PROMOTED_URL has been there and then I also added PROMOTED_JOB_NAME and PROMOTED_NUMBER. I just added BUILD_ID. Is SVN_REVISION the revision of the build being promoted or is it the revision of the workspace at the time the build is promoted? 
I added this to prefix the promoted build's environment into the promotion tasks. Then in my emailext config i could use: ${ENV,var="PROMOTED_BUILD_URL"} etc...
Hope this helps, I'd love to see this get added to the mainline..
Index: src/main/java/hudson/plugins/promoted_builds/Promotion.java
{ return getTarget().getAction(PromotedBuildAction.class).getPromotion(getParent().getName()); }===================================================================
— src/main/java/hudson/plugins/promoted_builds/Promotion.java (revision 30880)
+++ src/main/java/hudson/plugins/promoted_builds/Promotion.java (working copy)
@@ -61,10 +61,14 @@
public Status getStatus()
-
{ // append promoted build's env + e.put("PROMOTED_" + key, parentEnv.get(key)); + }+
@Override
public EnvVars getEnvironment(TaskListener listener) throws IOException, InterruptedException {
EnvVars e = super.getEnvironment(listener);
+ EnvVars parentEnv = this.getTarget().getEnvironment(listener);
+ for (String key : parentEnv.keySet())
String rootUrl = Hudson.getInstance().getRootUrl();
if(rootUrl!=null)
e.put("PROMOTED_URL",rootUrl+getTarget().getUrl());