-
Improvement
-
Resolution: Fixed
-
Minor
-
None
Calling sshCommand forces the allocation of PTY, however running commands on servers where there is no proper PTY support (win32-openssh) can generate failures such as garbage output, ...
Being able to disable/enable PTY allocation would help for these environments
EDIT:
There is PTY setting at the remote level, but actually not sure why I had to make it true at the command level, I think it needs to be defaulted false as there is no impact for LINUX boxes either way, I have tested it. Made a PR.
And this PTY is also applicable for other steps, so instead it is good to have it at the remote level.
- links to
[JENKINS-56989] Default pty to false for sshCommand
| Remote Link | New: This issue links to "Pull request (Web Link)" [ 22590 ] |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
| Summary | Original: Allow explicit enabling/disabling of PTY with sshCommand | New: Default pty to false for sshCommand |
| Description |
Original:
Calling sshCommand forces the allocation of PTY, however running commands on servers where there is no proper PTY support (win32-openssh) can generate failures such as garbage output, ... Being able to disable/enable PTY allocation would help for these environments |
New:
Calling sshCommand forces the allocation of PTY, however running commands on servers where there is no proper PTY support (win32-openssh) can generate failures such as garbage output, ... Being able to disable/enable PTY allocation would help for these environments EDIT: There is PTY setting at the remote level, but actually not sure why I had to make it true at the command level, so feel like it needs to be defaulted to `false`. Made a PR: |
| Description |
Original:
Calling sshCommand forces the allocation of PTY, however running commands on servers where there is no proper PTY support (win32-openssh) can generate failures such as garbage output, ... Being able to disable/enable PTY allocation would help for these environments EDIT: There is PTY setting at the remote level, but actually not sure why I had to make it true at the command level, so feel like it needs to be defaulted to `false`. Made a PR: |
New:
Calling sshCommand forces the allocation of PTY, however running commands on servers where there is no proper PTY support (win32-openssh) can generate failures such as garbage output, ... Being able to disable/enable PTY allocation would help for these environments EDIT: There is PTY setting at the remote level, but actually not sure why I had to make it true at the command level, so it needs to be defaulted to `false`. Made a PR: |
| Description |
Original:
Calling sshCommand forces the allocation of PTY, however running commands on servers where there is no proper PTY support (win32-openssh) can generate failures such as garbage output, ... Being able to disable/enable PTY allocation would help for these environments EDIT: There is PTY setting at the remote level, but actually not sure why I had to make it true at the command level, so it needs to be defaulted to `false`. Made a PR: |
New:
Calling sshCommand forces the allocation of PTY, however running commands on servers where there is no proper PTY support (win32-openssh) can generate failures such as garbage output, ... Being able to disable/enable PTY allocation would help for these environments EDIT: There is PTY setting at the remote level, but actually not sure why I had to make it true at the command level, I think it needs to be defaulted false as there is no impact for LINUX boxes either way, I have tested it. Made a PR: |
Follow up PR: https://github.com/jenkinsci/ssh-steps-plugin/pull/19
I performed a pull request to handle this issue