Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-57179

Allow posting comment when voting on Swarm Review

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • p4-plugin

      The p4approve step doesn't post the description as a comment when using either the VOTE_UP or VOTE_DOWN status.

      The Swarm API for voting doesn't accept a comment parameter, but a separate post request can be made to add a comment after voting.

          [JENKINS-57179] Allow posting comment when voting on Swarm Review

          Stuart Rowe created issue -
          Stuart Rowe made changes -
          Assignee New: Stuart Rowe [ stuartrowe ]
          Stuart Rowe made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Stuart Rowe added a comment -

          https://github.com/jenkinsci/p4-plugin/pull/97

          Stuart Rowe added a comment - https://github.com/jenkinsci/p4-plugin/pull/97
          Karl Wirth made changes -
          Assignee Original: Stuart Rowe [ stuartrowe ] New: Karl Wirth [ p4karl ]
          Karl Wirth made changes -
          Assignee Original: Karl Wirth [ p4karl ] New: Paul Allen [ p4paul ]
          Karl Wirth made changes -
          Labels New: P4_B

          Paul Allen added a comment -

          Released in 1.10.0

          Paul Allen added a comment - Released in 1.10.0
          Paul Allen made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Closed [ 6 ]

            p4paul Paul Allen
            stuartrowe Stuart Rowe
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: