-
Improvement
-
Resolution: Fixed
-
Minor
-
None
The latest OkHttp (v2.7.5) is over three years old. The web has come a long way. There are a significant number of Jenkins JIRA and Zendesk issues related to using this ancient library in key plugins.
We should upgrade Jenkins to use OkHttp3.
NOTES:
- OkHttp 2.x and 3.x exist in separate packages and can run side-by-side without conflict. However, different versions of 3.x (and okhttp3 4.x) may be incompatible if clients are using obsolete classes/methods.
- OkHttp 3.12.2 is the last version that is reasonably compatible with 2.7.5. Upgrading will require some changes but not huge ones.
- OkHttp 3.13.1 has some notable incompatibilities with 2.7.5, but also some better defaults.
- OkHttp 3.14.1 removes OkHttpUrlFactory which is a serious version-incompatible API change for several plugins. The github-api library pulled in a shim that provides a workaround OkHttpUrlFactory.
Early exploration of this upgrade was started to test whether it would address issues such as JENKINS-54126.
Finding so far while using 3.12.2:
- okio v2.2.x is needed for okhttp3.
- Some special class loading settings are needed to get the right versions okhttp3 and okio to be loaded.
(Last updated May 4, 2020):
The rebuilt incremental can be found at:
https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/github-branch-source/2.7.2-rc1149.0f9fd89495cc/
This version uses okhttp3 and is compatible with github-api-plugin 1.110+.
- is related to
-
JENKINS-54126 Jenkinsfile not found in PR on GitHub -- Does not meet criteria
-
- Closed
-
[JENKINS-57411] Upgrade github-branch-source-plugin to use okhttp3
| Link |
New:
This issue is related to |
| Description |
New:
The latest OkHttp (v2.7.5) is over three years old. The web has come a long way. There are a significant number of Jenkins JIRA and Zendesk issues related to using this ancient library in key plugins. We should upgrade Jenkins to use OkHttp3. NOTES: * OkHttp 2.x and 3.x exist and separate packages and can run side-by-side without conflict. However, different versions of 3.x may be incompatible if clients are using obsolete classes/methods. * OkHttp 3.12.2 is the last version that is reasonably compatible with 2.7.5. Upgrading will require some changes but not huge ones. * OkHttp 3.13.1 has some notable incompatibilities with 2.7.5, but also some better defaults. * OkHttp 3.14.1 removes UrlFactory which is a serious version-incompatible API change for several plugins. |
| Description |
Original:
The latest OkHttp (v2.7.5) is over three years old. The web has come a long way. There are a significant number of Jenkins JIRA and Zendesk issues related to using this ancient library in key plugins. We should upgrade Jenkins to use OkHttp3. NOTES: * OkHttp 2.x and 3.x exist and separate packages and can run side-by-side without conflict. However, different versions of 3.x may be incompatible if clients are using obsolete classes/methods. * OkHttp 3.12.2 is the last version that is reasonably compatible with 2.7.5. Upgrading will require some changes but not huge ones. * OkHttp 3.13.1 has some notable incompatibilities with 2.7.5, but also some better defaults. * OkHttp 3.14.1 removes UrlFactory which is a serious version-incompatible API change for several plugins. |
New:
The latest OkHttp (v2.7.5) is over three years old. The web has come a long way. There are a significant number of Jenkins JIRA and Zendesk issues related to using this ancient library in key plugins. We should upgrade Jenkins to use OkHttp3. NOTES: * OkHttp 2.x and 3.x exist and separate packages and can run side-by-side without conflict. However, different versions of 3.x may be incompatible if clients are using obsolete classes/methods. * OkHttp 3.12.2 is the last version that is reasonably compatible with 2.7.5. Upgrading will require some changes but not huge ones. * OkHttp 3.13.1 has some notable incompatibilities with 2.7.5, but also some better defaults. * OkHttp 3.14.1 removes UrlFactory which is a serious version-incompatible API change for several plugins. Early exploration of this upgrade was started to test whether it would address issues such ass Finding so far while using 3.12.2: * okio v2.2.x is needed for okhttp3. * Some special class loading settings are needed to get the right versions okhttp3 and okio to be loaded. * |
| Description |
Original:
The latest OkHttp (v2.7.5) is over three years old. The web has come a long way. There are a significant number of Jenkins JIRA and Zendesk issues related to using this ancient library in key plugins. We should upgrade Jenkins to use OkHttp3. NOTES: * OkHttp 2.x and 3.x exist and separate packages and can run side-by-side without conflict. However, different versions of 3.x may be incompatible if clients are using obsolete classes/methods. * OkHttp 3.12.2 is the last version that is reasonably compatible with 2.7.5. Upgrading will require some changes but not huge ones. * OkHttp 3.13.1 has some notable incompatibilities with 2.7.5, but also some better defaults. * OkHttp 3.14.1 removes UrlFactory which is a serious version-incompatible API change for several plugins. Early exploration of this upgrade was started to test whether it would address issues such ass Finding so far while using 3.12.2: * okio v2.2.x is needed for okhttp3. * Some special class loading settings are needed to get the right versions okhttp3 and okio to be loaded. * |
New:
The latest OkHttp (v2.7.5) is over three years old. The web has come a long way. There are a significant number of Jenkins JIRA and Zendesk issues related to using this ancient library in key plugins. We should upgrade Jenkins to use OkHttp3. NOTES: * OkHttp 2.x and 3.x exist and separate packages and can run side-by-side without conflict. However, different versions of 3.x may be incompatible if clients are using obsolete classes/methods. * OkHttp 3.12.2 is the last version that is reasonably compatible with 2.7.5. Upgrading will require some changes but not huge ones. * OkHttp 3.13.1 has some notable incompatibilities with 2.7.5, but also some better defaults. * OkHttp 3.14.1 removes UrlFactory which is a serious version-incompatible API change for several plugins. Early exploration of this upgrade was started to test whether it would address issues such ass Finding so far while using 3.12.2: * okio v2.2.x is needed for okhttp3. * Some special class loading settings are needed to get the right versions okhttp3 and okio to be loaded. * (Last updated May 9, 2019): Please give this version of the plugin a try: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/github-branch-source/2.5.3-rc841.52a0b90bff37/ |
Josh Soref
added a comment - There wasn't anything obvious in the scan repository logs. I'll check the master log…
Josh Soref
added a comment - There wasn't anything obvious in the scan repository logs. I'll check the master log… jsoref
Cool thanks.
I'm really not sure what would the periodic scans to not run. 
| Description |
Original:
The latest OkHttp (v2.7.5) is over three years old. The web has come a long way. There are a significant number of Jenkins JIRA and Zendesk issues related to using this ancient library in key plugins. We should upgrade Jenkins to use OkHttp3. NOTES: * OkHttp 2.x and 3.x exist and separate packages and can run side-by-side without conflict. However, different versions of 3.x may be incompatible if clients are using obsolete classes/methods. * OkHttp 3.12.2 is the last version that is reasonably compatible with 2.7.5. Upgrading will require some changes but not huge ones. * OkHttp 3.13.1 has some notable incompatibilities with 2.7.5, but also some better defaults. * OkHttp 3.14.1 removes UrlFactory which is a serious version-incompatible API change for several plugins. Early exploration of this upgrade was started to test whether it would address issues such ass Finding so far while using 3.12.2: * okio v2.2.x is needed for okhttp3. * Some special class loading settings are needed to get the right versions okhttp3 and okio to be loaded. * (Last updated May 9, 2019): Please give this version of the plugin a try: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/github-branch-source/2.5.3-rc841.52a0b90bff37/ |
New:
The latest OkHttp (v2.7.5) is over three years old. The web has come a long way. There are a significant number of Jenkins JIRA and Zendesk issues related to using this ancient library in key plugins. We should upgrade Jenkins to use OkHttp3. NOTES: * OkHttp 2.x and 3.x exist and separate packages and can run side-by-side without conflict. However, different versions of 3.x may be incompatible if clients are using obsolete classes/methods. * OkHttp 3.12.2 is the last version that is reasonably compatible with 2.7.5. Upgrading will require some changes but not huge ones. * OkHttp 3.13.1 has some notable incompatibilities with 2.7.5, but also some better defaults. * OkHttp 3.14.1 removes UrlFactory which is a serious version-incompatible API change for several plugins. Early exploration of this upgrade was started to test whether it would address issues such ass Finding so far while using 3.12.2: * okio v2.2.x is needed for okhttp3. * Some special class loading settings are needed to get the right versions okhttp3 and okio to be loaded. * (Last updated May 29, 2019): Please give this version of the plugin a try: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/github-branch-source/2.5.4-rc849.b58a1bae7fce/ |
jsoref
I'm pretty sure the periodic scans not running are unrelated. I've updated the patched plugin to include the latest fixes (see the description).
jsoref
Yeah, that's better than nothing.
Take a look at the Events log for the org/repo to see if there are errors. Otherwise, errors might only show in the Jenkins Master's console log output.