• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: support-core-plugin
• Labels:

  • triaged
• Environment:

  support-core-2.56

[JENKINS-57602] NPE in Support Core Plugin when reporting agents

Oleg Nenashev created issue - 2019-05-22 11:18

Oleg Nenashev made changes - 2019-05-22 11:21

Description

Original: I have a node which has been configured with JCasC and then never connected. When Support  Core Plugin generates a bundle, I see NPE in System logs. {code:java} WARNING: Could not attach ''nodes.md'' to support bundle java.lang.NullPointerException at com.cloudbees.jenkins.support.util.Markdown.escapeBacktick(Markdown.java:17) at com.cloudbees.jenkins.support.impl.AboutJenkins$NodesContent.printTo(AboutJenkins.java:877) at com.cloudbees.jenkins.support.api.PrintedContent.writeTo(PrintedContent.java:56) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:316) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:278) at com.cloudbees.jenkins.support.SupportPlugin$PeriodicWorkImpl.lambda$doRun$0(SupportPlugin.java:820) at java.lang.Thread.run(Thread.java:748) {code}

New: I have a node which has been configured with JCasC and then never connected. When Support  Core Plugin generates a bundle, I see NPE in System logs. Acceptance criteria:  * There is handling of null inputs in the reporting path Nice 2 have:  * Methods are annotated to ensure that there is no such mistakes happening in the future {code:java} WARNING: Could not attach ''nodes.md'' to support bundle java.lang.NullPointerException at com.cloudbees.jenkins.support.util.Markdown.escapeBacktick(Markdown.java:17) at com.cloudbees.jenkins.support.impl.AboutJenkins$NodesContent.printTo(AboutJenkins.java:877) at com.cloudbees.jenkins.support.api.PrintedContent.writeTo(PrintedContent.java:56) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:316) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:278) at com.cloudbees.jenkins.support.SupportPlugin$PeriodicWorkImpl.lambda$doRun$0(SupportPlugin.java:820) at java.lang.Thread.run(Thread.java:748) {code}

Collapse comment: Baptiste Mathus added a comment - 2019-05-27 08:30

Baptiste Mathus added a comment - 2019-05-27 08:30

I think we should check if this also reproducible out of JCasC configured.

At this stage, Oleg is saying it looks only like log spam, but we'd need to double check.

Expand comment: Baptiste Mathus added a comment - 2019-05-27 08:30

Baptiste Mathus added a comment - 2019-05-27 08:30 I think we should check if this also reproducible out of JCasC configured. At this stage, Oleg is saying it looks only like log spam, but we'd need to double check.

Baptiste Mathus made changes - 2019-05-27 08:31

Labels

New: triaged

Baptiste Mathus made changes - 2019-06-12 07:45

Assignee

Original: Emilio Escobar [ escoem ]

Ramon Leon made changes - 2019-07-11 16:39

Assignee

New: Ramon Leon [ mramonleon ]

Ramon Leon made changes - 2019-07-11 16:39

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Ramon Leon made changes - 2019-07-11 16:39

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Collapse comment: Ramon Leon added a comment - 2019-07-11 16:39, Edited by Ramon Leon - 2019-07-11 16:40

Ramon Leon added a comment - 2019-07-11 16:39 - edited

PR: https://github.com/jenkinsci/support-core-plugin/pull/179

Expand comment: Ramon Leon added a comment - 2019-07-11 16:39, Edited by Ramon Leon - 2019-07-11 16:40

Ramon Leon added a comment - 2019-07-11 16:39 - edited PR: https://github.com/jenkinsci/support-core-plugin/pull/179

Ramon Leon made changes - 2019-07-11 16:40

Remote Link

New: This issue links to "PR #179 (Web Link)" [ 23228 ]

Load more newer events