Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5769

RobustReflectionConverter is not used in some cases

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Minor Minor
    • core
    • None

      There are a few cases where XStream internally passes its default instance of ReflectionConverter to other converter instances. When these converters drill down into their fields, they do not use RobustReflectionConverter and the overall conversion becomes subject to the same failures that RobustReflectionConverter was created to avoid. Here is a list of converters that are passed the default ReflectionConverter in XStream 1.3.1:

      ThrowableConverter
      RegexPatternConverter
      SerializableConverter
      LookAndFeelConverter
      SelfStreamingInstanceChecker

      In our case, the fact that the ThrowableConverter was not calling RobustReflectionConvert combined with an error in class member munging described in JENKINS-5768 to cause our build.xml deserializable to fail, cause the build in question to not be loaded into memory on startup.

          [JENKINS-5769] RobustReflectionConverter is not used in some cases

          mdillon created issue -
          mdillon made changes -
          Attachment New: XStream2.java.diff [ 19190 ]
          Alan Harder made changes -
          Assignee New: Alan Harder [ mindless ]
          Alan Harder made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Andrew Bayer made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]
          R. Tyler Croy made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Closed [ 6 ] New: Reopened [ 4 ]
          R. Tyler Croy made changes -
          Reporter Original: mdillon [ mdillon ] New: Mike Dillon [ md5 ]
          R. Tyler Croy made changes -
          Resolution New: Done [ 10000 ]
          Status Original: Reopened [ 4 ] New: Closed [ 6 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 135861 ] New: JNJira + In-Review [ 203713 ]

            mindless Alan Harder
            md5 Mike Dillon
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: