-
Task
-
Resolution: Fixed
-
Minor
-
-
GSoC 2019. Coding Phase 2
The parsing for the plugin manager needs to be more robust. It needs to take into account unwanted characters, a better way to split on ":", and recognize requested plugin parameters.
[JENKINS-58126] Make Parsing for Plugin Manager CLI More Robust
Epic Link |
New:
|
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
Resolution | New: Fixed [ 1 ] | |
Status | Original: In Review [ 10005 ] | New: Resolved [ 5 ] |
Status | Original: Resolved [ 5 ] | New: Closed [ 6 ] |
Kept parsing to be on ":", but added checks for blank lines and comments. Pinged the platform sig Gitter channel and in the install-plugins.sh if a url was entered, a placeholder was still kept for version, so I kept it this way. Also asked them about changing delimiters and they wanted to keep the ":" delimiter.
Partially fixed in https://github.com/jenkinsci/plugin-installation-manager-tool/pull/27, but url input still broken.
Fixed again in: https://github.com/jenkinsci/plugin-installation-manager-tool/pull/28