Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5815

FXCop warnings on property accessors are not reported by violations plugin

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • violations-plugin
    • None

      I have attached an example fxcop output which contains 2 warnings. The violations plugin only reports the second one and ignores the first.

        1. FxCopReport.xsd
          14 kB
        2. HUDSON-5815.patch
          14 kB
        3. fxcop.xml
          11 kB

          [JENKINS-5815] FXCop warnings on property accessors are not reported by violations plugin

          gazzyt created issue -

          gazzyt added a comment -

          I have attached a patch file containing a unit test for this defect and the fix for the fxcop parser class.

          The patch file should be applied to the plugins\violations folder.

          gazzyt added a comment - I have attached a patch file containing a unit test for this defect and the fix for the fxcop parser class. The patch file should be applied to the plugins\violations folder.
          gazzyt made changes -
          Attachment New: JENKINS-5815.patch [ 19197 ]

          peterreilly added a comment -

          Thanks, do you know if "Accessors" (as against "Accessor") is ever used? or was is just a typo in the original code.

          peterreilly added a comment - Thanks, do you know if "Accessors" (as against "Accessor") is ever used? or was is just a typo in the original code.

          gazzyt added a comment -

          I have attached the xsd that comes with FxCop. From this it looks like Accessor can only exist as a child element of Accessors. So I suspect this is simply a typo.

          Gary

          gazzyt added a comment - I have attached the xsd that comes with FxCop. From this it looks like Accessor can only exist as a child element of Accessors. So I suspect this is simply a typo. Gary
          gazzyt made changes -
          Attachment New: FxCopReport.xsd [ 19198 ]

          peterreilly added a comment -

          Thanks, I have committed the patch
          Peter

          peterreilly added a comment - Thanks, I have committed the patch Peter

          SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : peterkittreilly
          Path:
          trunk/hudson/plugins/violations/src/main/java/hudson/plugins/violations/types/fxcop/FxCopParser.java
          trunk/hudson/plugins/violations/src/test/java/hudson/plugins/violations/types/fxcop/FxCopParserTest.java
          trunk/hudson/plugins/violations/src/test/resources/hudson/plugins/violations/types/fxcop/fxcop.xml
          http://jenkins-ci.org/commit/28169
          Log:
          JENKINS-5815: incorrect tag looked at for accessors violations in fxcop

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : peterkittreilly Path: trunk/hudson/plugins/violations/src/main/java/hudson/plugins/violations/types/fxcop/FxCopParser.java trunk/hudson/plugins/violations/src/test/java/hudson/plugins/violations/types/fxcop/FxCopParserTest.java trunk/hudson/plugins/violations/src/test/resources/hudson/plugins/violations/types/fxcop/fxcop.xml http://jenkins-ci.org/commit/28169 Log: JENKINS-5815 : incorrect tag looked at for accessors violations in fxcop

          evernat added a comment -

          The patch was committed so resolved as fixed.

          evernat added a comment - The patch was committed so resolved as fixed.
          evernat made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

            peterkittreilly peterkittreilly
            gazzyt gazzyt
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: