Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58160

Don't use Guava Beta APIs

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Blocker Blocker
    • ec2-plugin
    • None
    • Amazon EC2 plug-in v1.44.1

      The EC2 plug-in currently uses Guava Beta APIs:

      • hudson.plugins.ec2.EC2HostAddressProvider uses Guava's HostAndPort class, for no clear reason.
      • hudson.plugins.ec2.win.winrm.WindowsProcess uses Guava's Closeables utility methods.

      Using Guava's Beta APIs is strongly discouraged as they can change at any time.

      In fact, this issue is blocking me from finishing JENKINS-56839: Jenkins core provides Guava 11, but a test dependency I am using pulls in Guava 20. While a bit messy, this wouldn't usually be an issue due to Guava's API stability guarantee; however, because the EC2 plug-in is using the above two beta APIs that work differently in Guava 20 than they did in Guava 11, the tests break.

      I propose dropping the use of the above two Guava Beta APIs alltogether.

          [JENKINS-58160] Don't use Guava Beta APIs

          Tilman Blumenbach created issue -
          Tilman Blumenbach made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Tilman Blumenbach made changes -
          Link New: This issue blocks JENKINS-56839 [ JENKINS-56839 ]
          Tilman Blumenbach made changes -
          Description Original: The EC2 plug-in currently uses Guava Beta APIs:

          - {{hudson.plugins.ec2.EC2HostAddressProvider}} uses Guava's [{{HostAndPort}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/net/HostAndPort.html] class, for no clear reason.
          - {{hudson.plugins.ec2.win.winrm.WindowsProcess}} uses Guava's [{{Closeables}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/io/Closeables.html] utility methods.

          Using Guava's Beta APIs is [strongly discouraged|https://github.com/google/guava#important-warnings] as they can change at any time.

          In fact, this issue is blocking me from finishing JENKINS-56839: Jenkins core provides Guava 11, but a test dependency pulls in Guava 27. While a bit messy, this wouldn't usually be an issue due to [Guava's API stability guarantee|https://github.com/google/guava#important-warnings]; however, as the EC2 plug-in is using the above two beta APIs that work differently in Guava 27 than they did in Guava 11, the tests break.

          I propose dropping the use of the above two Guava Beta APIs alltogether.           		New: The EC2 plug-in currently uses Guava Beta APIs:

          - {{hudson.plugins.ec2.EC2HostAddressProvider}} uses Guava's [{{HostAndPort}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/net/HostAndPort.html] class, for no clear reason.
          - {{hudson.plugins.ec2.win.winrm.WindowsProcess}} uses Guava's [{{Closeables}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/io/Closeables.html] utility methods.

          Using Guava's Beta APIs is [strongly discouraged|https://github.com/google/guava#important-warnings] as they can change at any time.

          In fact, this issue is blocking me from finishing JENKINS-56839: Jenkins core provides Guava 11, but a test dependency I am using pulls in Guava 27. While a bit messy, this wouldn't usually be an issue due to [Guava's API stability guarantee|https://github.com/google/guava#important-warnings]; however, as the EC2 plug-in is using the above two beta APIs that work differently in Guava 27 than they did in Guava 11, the tests break.

          I propose dropping the use of the above two Guava Beta APIs alltogether.
          Tilman Blumenbach made changes -
          Description Original: The EC2 plug-in currently uses Guava Beta APIs:

          - {{hudson.plugins.ec2.EC2HostAddressProvider}} uses Guava's [{{HostAndPort}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/net/HostAndPort.html] class, for no clear reason.
          - {{hudson.plugins.ec2.win.winrm.WindowsProcess}} uses Guava's [{{Closeables}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/io/Closeables.html] utility methods.

          Using Guava's Beta APIs is [strongly discouraged|https://github.com/google/guava#important-warnings] as they can change at any time.

          In fact, this issue is blocking me from finishing JENKINS-56839: Jenkins core provides Guava 11, but a test dependency I am using pulls in Guava 27. While a bit messy, this wouldn't usually be an issue due to [Guava's API stability guarantee|https://github.com/google/guava#important-warnings]; however, as the EC2 plug-in is using the above two beta APIs that work differently in Guava 27 than they did in Guava 11, the tests break.

          I propose dropping the use of the above two Guava Beta APIs alltogether.           		New: The EC2 plug-in currently uses Guava Beta APIs:

          - {{hudson.plugins.ec2.EC2HostAddressProvider}} uses Guava's [{{HostAndPort}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/net/HostAndPort.html] class, for no clear reason.
          - {{hudson.plugins.ec2.win.winrm.WindowsProcess}} uses Guava's [{{Closeables}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/io/Closeables.html] utility methods.

          Using Guava's Beta APIs is [strongly discouraged|https://github.com/google/guava#important-warnings] as they can change at any time.

          In fact, this issue is blocking me from finishing JENKINS-56839: Jenkins core provides Guava 11, but a test dependency I am using pulls in Guava 27. While a bit messy, this wouldn't usually be an issue due to [Guava's API stability guarantee|https://github.com/google/guava#important-warnings]; however, because the EC2 plug-in is using the above two beta APIs that work differently in Guava 27 than they did in Guava 11, the tests break.

          I propose dropping the use of the above two Guava Beta APIs alltogether.
          Tilman Blumenbach made changes -
          Description Original: The EC2 plug-in currently uses Guava Beta APIs:

          - {{hudson.plugins.ec2.EC2HostAddressProvider}} uses Guava's [{{HostAndPort}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/net/HostAndPort.html] class, for no clear reason.
          - {{hudson.plugins.ec2.win.winrm.WindowsProcess}} uses Guava's [{{Closeables}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/io/Closeables.html] utility methods.

          Using Guava's Beta APIs is [strongly discouraged|https://github.com/google/guava#important-warnings] as they can change at any time.

          In fact, this issue is blocking me from finishing JENKINS-56839: Jenkins core provides Guava 11, but a test dependency I am using pulls in Guava 27. While a bit messy, this wouldn't usually be an issue due to [Guava's API stability guarantee|https://github.com/google/guava#important-warnings]; however, because the EC2 plug-in is using the above two beta APIs that work differently in Guava 27 than they did in Guava 11, the tests break.

          I propose dropping the use of the above two Guava Beta APIs alltogether.           		New: The EC2 plug-in currently uses Guava Beta APIs:

          - {{hudson.plugins.ec2.EC2HostAddressProvider}} uses Guava's [{{HostAndPort}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/net/HostAndPort.html] class, for no clear reason.
          - {{hudson.plugins.ec2.win.winrm.WindowsProcess}} uses Guava's [{{Closeables}}|https://guava.dev/releases/11.0.1/api/docs/com/google/common/io/Closeables.html] utility methods.

          Using Guava's Beta APIs is [strongly discouraged|https://github.com/google/guava#important-warnings] as they can change at any time.

          In fact, this issue is blocking me from finishing JENKINS-56839: Jenkins core provides Guava 11, but a test dependency I am using pulls in Guava 20. While a bit messy, this wouldn't usually be an issue due to [Guava's API stability guarantee|https://github.com/google/guava#important-warnings]; however, because the EC2 plug-in is using the above two beta APIs that work differently in Guava 20 than they did in Guava 11, the tests break.

          I propose dropping the use of the above two Guava Beta APIs alltogether.
          Tilman Blumenbach made changes -
          Released As New: Amazon EC2 plug-in v1.45
          Assignee Original: Tilman Blumenbach [ acrolinx_blumenbach ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Closed [ 6 ]
          Tilman Blumenbach made changes -
          Released As Original: Amazon EC2 plug-in v1.45
          Assignee New: Tilman Blumenbach [ acrolinx_blumenbach ]
          Resolution Original: Fixed [ 1 ] New: Done [ 10000 ]
          Status Original: Closed [ 6 ] New: Fixed but Unreleased [ 10203 ]
          Tilman Blumenbach made changes -
          Released As New: Amazon EC2 plug-in v1.44.1
          Assignee Original: Tilman Blumenbach [ acrolinx_blumenbach ]
          Status Original: Fixed but Unreleased [ 10203 ] New: Closed [ 6 ]

            Unassigned Unassigned
            acrolinx_blumenbach Tilman Blumenbach
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: